<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169532] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169532">169532</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2014-06-02 09:37:45 -0700 (Mon, 02 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/154622">r154622</a>): Borders disappear when hovering over cells in table
https://bugs.webkit.org/show_bug.cgi?id=133057
<rdar://problem/15922359>
Reviewed by Tim Horton.
Source/WebCore:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders): Revert recent
non-edge collapsed border optimization due to drawing
regressions.
LayoutTests:
* TestExpectations: Mark the test we added in <a href="http://trac.webkit.org/projects/webkit/changeset/154622">r154622</a> as failing
until we provide a permanent fix.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTableCellcpp">trunk/Source/WebCore/rendering/RenderTableCell.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (169531 => 169532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-06-02 16:05:25 UTC (rev 169531)
+++ trunk/LayoutTests/ChangeLog 2014-06-02 16:37:45 UTC (rev 169532)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-05-31 Brent Fulgham <bfulgham@apple.com>
+
+ REGRESSION (r154622): Borders disappear when hovering over cells in table
+ https://bugs.webkit.org/show_bug.cgi?id=133057
+ <rdar://problem/15922359>
+
+ Reviewed by Tim Horton.
+
+ * TestExpectations: Mark the test we added in r154622 as failing
+ until we provide a permanent fix.
+
</ins><span class="cx"> 2014-06-02 Kiran <kiran.guduru@samsung.com>
</span><span class="cx">
</span><span class="cx"> Add mock DTMFSender support.
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (169531 => 169532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2014-06-02 16:05:25 UTC (rev 169531)
+++ trunk/LayoutTests/TestExpectations 2014-06-02 16:37:45 UTC (rev 169532)
</span><span class="lines">@@ -123,3 +123,5 @@
</span><span class="cx"> webkit.org/b/132791 svg/as-object/sizing/svg-in-object-placeholder-height-auto.html [ Skip ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/133356 js/primitive-property-access-edge-cases.html [ Pass Crash ]
</span><ins>+
+webkit.org/b/133057 fast/table/border-collapsing/collapsed-borders-adjoining-sections.html [ Failure ]
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169531 => 169532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-02 16:05:25 UTC (rev 169531)
+++ trunk/Source/WebCore/ChangeLog 2014-06-02 16:37:45 UTC (rev 169532)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-05-31 Brent Fulgham <bfulgham@apple.com>
+
+ REGRESSION (r154622): Borders disappear when hovering over cells in table
+ https://bugs.webkit.org/show_bug.cgi?id=133057
+ <rdar://problem/15922359>
+
+ Reviewed by Tim Horton.
+
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::paintCollapsedBorders): Revert recent
+ non-edge collapsed border optimization due to drawing
+ regressions.
+
</ins><span class="cx"> 2014-06-02 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Provide better encapsulation for image related painting properties.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTableCellcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTableCell.cpp (169531 => 169532)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTableCell.cpp 2014-06-02 16:05:25 UTC (rev 169531)
+++ trunk/Source/WebCore/rendering/RenderTableCell.cpp 2014-06-02 16:37:45 UTC (rev 169532)
</span><span class="lines">@@ -1203,14 +1203,12 @@
</span><span class="cx"> int bottomYOffsetLeft = bottomWidth;
</span><span class="cx"> int bottomYOffsetRight = bottomWidth;
</span><span class="cx">
</span><del>- // We use the direction/writing-mode given by the section here because we want to know if we're
- // at the section's edge.
- bool shouldDrawTopBorder = !cellAtTop(&section()->style());
- bool shouldDrawLeftBorder = !cellAtLeft(&section()->style());
</del><ins>+ bool shouldDrawTopBorder = true;
+ bool shouldDrawLeftBorder = true;
</ins><span class="cx"> bool shouldDrawRightBorder = true;
</span><span class="cx">
</span><span class="cx"> if (RenderTableCell* top = cellAtTop(&styleForCellFlow)) {
</span><del>- shouldDrawTopBorder = shouldDrawTopBorder && top->alignLeftRightBorderPaintRect(leftXOffsetTop, rightXOffsetTop);
</del><ins>+ shouldDrawTopBorder = top->alignLeftRightBorderPaintRect(leftXOffsetTop, rightXOffsetTop);
</ins><span class="cx"> if (this->colSpan() > 1)
</span><span class="cx"> shouldDrawTopBorder = false;
</span><span class="cx"> }
</span><span class="lines">@@ -1219,7 +1217,7 @@
</span><span class="cx"> bottom->alignLeftRightBorderPaintRect(leftXOffsetBottom, rightXOffsetBottom);
</span><span class="cx">
</span><span class="cx"> if (RenderTableCell* left = cellAtLeft(&styleForCellFlow))
</span><del>- shouldDrawLeftBorder = shouldDrawLeftBorder && left->alignTopBottomBorderPaintRect(topYOffsetLeft, bottomYOffsetLeft);
</del><ins>+ shouldDrawLeftBorder = left->alignTopBottomBorderPaintRect(topYOffsetLeft, bottomYOffsetLeft);
</ins><span class="cx">
</span><span class="cx"> if (RenderTableCell* right = cellAtRight(&styleForCellFlow))
</span><span class="cx"> shouldDrawRightBorder = right->alignTopBottomBorderPaintRect(topYOffsetRight, bottomYOffsetRight);
</span></span></pre>
</div>
</div>
</body>
</html>