<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169528] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169528">169528</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-06-02 03:55:37 -0700 (Mon, 02 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add mock DTMFSender support.
https://bugs.webkit.org/show_bug.cgi?id=133298
Patch by Kiran <kiran.guduru@samsung.com> on 2014-06-02
Reviewed by Eric Carlson.
Source/WebCore:
Implemented mock implementation for RTCPeerConnectionHandler. Now creating
RTCDTMFSenderHandlerMock and returning while creating DTMFSender instead of
returning null.
Test: fast/mediastream/RTCPeerConnection-dtmf.html.
* CMakeLists.txt:
* platform/mock/RTCDTMFSenderHandlerMock.cpp: Added.
(WebCore::RTCDTMFSenderHandlerMock::RTCDTMFSenderHandlerMock):
(WebCore::RTCDTMFSenderHandlerMock::setClient):
(WebCore::RTCDTMFSenderHandlerMock::insertDTMF):
* platform/mock/RTCDTMFSenderHandlerMock.h: Added.
* platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::createDTMFSender):
LayoutTests:
* fast/mediastream/RTCPeerConnection-dtmf-expected.txt:
* fast/mediastream/RTCPeerConnection-dtmf.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectiondtmfexpectedtxt">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectiondtmfhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html</a></li>
<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformmockRTCPeerConnectionHandlerMockcpp">trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreplatformmockRTCDTMFSenderHandlerMockcpp">trunk/Source/WebCore/platform/mock/RTCDTMFSenderHandlerMock.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformmockRTCDTMFSenderHandlerMockh">trunk/Source/WebCore/platform/mock/RTCDTMFSenderHandlerMock.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (169527 => 169528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-06-02 08:31:26 UTC (rev 169527)
+++ trunk/LayoutTests/ChangeLog 2014-06-02 10:55:37 UTC (rev 169528)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-06-02 Kiran <kiran.guduru@samsung.com>
+
+ Add mock DTMFSender support.
+ https://bugs.webkit.org/show_bug.cgi?id=133298
+
+ Reviewed by Eric Carlson.
+
+ * fast/mediastream/RTCPeerConnection-dtmf-expected.txt:
+ * fast/mediastream/RTCPeerConnection-dtmf.html:
+
</ins><span class="cx"> 2014-06-02 Jinwoo Song <jinwoo7.song@samsung.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed EFL gardening.
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectiondtmfexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf-expected.txt (169527 => 169528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf-expected.txt 2014-06-02 08:31:26 UTC (rev 169527)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf-expected.txt 2014-06-02 10:55:37 UTC (rev 169528)
</span><span class="lines">@@ -11,10 +11,23 @@
</span><span class="cx"> PASS dtmfsender = pc.createDTMFSender(track); threw exception Error: SyntaxError: DOM Exception 12.
</span><span class="cx"> PASS dtmfsender = pc.createDTMFSender(track); did not throw exception.
</span><span class="cx"> PASS dtmfsender.canInsertDTMF is true
</span><del>-PASS dtmfsender.toneBuffer is "1"
-PASS ontonechange was called.
-PASS event.tone is "1"
-PASS ontonechange was called.
</del><ins>+PASS dtmfsender.duration is 100
+PASS dtmfsender.interToneGap is 70
+PASS dtmfsender.duration is 40
+PASS dtmfsender.interToneGap is 30
+PASS dtmfsender.duration is 6000
+PASS dtmfsender.interToneGap is 70
+PASS dtmfsender.insertDTMF("1", "20"); threw exception Error: SyntaxError: DOM Exception 12.
+PASS dtmfsender.insertDTMF("1", "7000"); threw exception Error: SyntaxError: DOM Exception 12.
+PASS dtmfsender.insertDTMF("1", "70", "10"); threw exception Error: SyntaxError: DOM Exception 12.
+PASS ontonechange was called 1
+PASS ontonechange was called
+PASS ontonechange was called 4
+PASS ontonechange was called
+PASS ontonechange was called 1
+PASS ontonechange was called 2
+PASS ontonechange was called 3
+PASS ontonechange was called
</ins><span class="cx"> PASS event.tone is ""
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectiondtmfhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html (169527 => 169528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html 2014-06-02 08:31:26 UTC (rev 169527)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html 2014-06-02 10:55:37 UTC (rev 169528)
</span><span class="lines">@@ -20,15 +20,14 @@
</span><span class="cx"> var callCount = 1;
</span><span class="cx">
</span><span class="cx"> function ontonechange(e) {
</span><del>- testPassed("ontonechange was called.");
</del><span class="cx"> event = e;
</span><ins>+ testPassed("ontonechange was called " + event.tone);
</ins><span class="cx"> if (!lastCall) {
</span><del>- shouldBeEqualToString('event.tone', "1");
</del><span class="cx"> callCount++;
</span><del>- if (3 == callCount)
</del><ins>+ if (8 == callCount)
</ins><span class="cx"> lastCall = true;
</span><span class="cx"> } else {
</span><del>- shouldBeEqualToString('event.tone', "");
</del><ins>+ shouldBeEmptyString('event.tone');
</ins><span class="cx"> finishJSTest();
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -45,25 +44,21 @@
</span><span class="cx">
</span><span class="cx"> dtmfsender.ontonechange = ontonechange;
</span><span class="cx"> dtmfsender.insertDTMF("1");
</span><del>- shouldBeEqualToString('dtmfsender.toneBuffer', "1");
- shouldBeEqualToString('dtmfsender.duration', "100");
- shouldBeEqualToString('dtmfsender.interToneGap', "70");
</del><ins>+ shouldBe('dtmfsender.duration', "100");
+ shouldBe('dtmfsender.interToneGap', "70");
</ins><span class="cx">
</span><del>- dtmfsender.insertDTMF("1", "40", "30");
- shouldBeEqualToString('dtmfsender.toneBuffer', "1");
- shouldBeEqualToString('dtmfsender.duration', "40");
- shouldBeEqualToString('dtmfsender.interToneGap', "30");
</del><ins>+ dtmfsender.insertDTMF("4", "40", "30");
+ shouldBe('dtmfsender.duration', "40");
+ shouldBe('dtmfsender.interToneGap', "30");
</ins><span class="cx">
</span><del>- dtmfsender.insertDTMF("1", "6000");
- shouldBeEqualToString('dtmfsender.toneBuffer', "1");
- shouldBeEqualToString('dtmfsender.duration', "6000");
- shouldBeEqualToString('dtmfsender.interToneGap', "70");
</del><ins>+ dtmfsender.insertDTMF("123", "6000");
+ shouldBe('dtmfsender.duration', "6000");
+ shouldBe('dtmfsender.interToneGap', "70");
</ins><span class="cx">
</span><span class="cx"> shouldThrow('dtmfsender.insertDTMF("1", "20");');
</span><span class="cx"> shouldThrow('dtmfsender.insertDTMF("1", "7000");');
</span><span class="cx"> shouldThrow('dtmfsender.insertDTMF("1", "70", "10");');
</span><span class="cx">
</span><del>-
</del><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/CMakeLists.txt (169527 => 169528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/CMakeLists.txt 2014-06-02 08:31:26 UTC (rev 169527)
+++ trunk/Source/WebCore/CMakeLists.txt 2014-06-02 10:55:37 UTC (rev 169528)
</span><span class="lines">@@ -2170,6 +2170,7 @@
</span><span class="cx"> platform/mock/MediaConstraintsMock.cpp
</span><span class="cx"> platform/mock/MockMediaStreamCenter.cpp
</span><span class="cx"> platform/mock/RTCDataChannelHandlerMock.cpp
</span><ins>+ platform/mock/RTCDTMFSenderHandlerMock.cpp
</ins><span class="cx"> platform/mock/RTCNotifiersMock.cpp
</span><span class="cx"> platform/mock/RTCPeerConnectionHandlerMock.cpp
</span><span class="cx"> platform/mock/ScrollbarThemeMock.cpp
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169527 => 169528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-02 08:31:26 UTC (rev 169527)
+++ trunk/Source/WebCore/ChangeLog 2014-06-02 10:55:37 UTC (rev 169528)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2014-06-02 Kiran <kiran.guduru@samsung.com>
+
+ Add mock DTMFSender support.
+ https://bugs.webkit.org/show_bug.cgi?id=133298
+
+ Reviewed by Eric Carlson.
+
+ Implemented mock implementation for RTCPeerConnectionHandler. Now creating
+ RTCDTMFSenderHandlerMock and returning while creating DTMFSender instead of
+ returning null.
+
+ Test: fast/mediastream/RTCPeerConnection-dtmf.html.
+
+ * CMakeLists.txt:
+ * platform/mock/RTCDTMFSenderHandlerMock.cpp: Added.
+ (WebCore::RTCDTMFSenderHandlerMock::RTCDTMFSenderHandlerMock):
+ (WebCore::RTCDTMFSenderHandlerMock::setClient):
+ (WebCore::RTCDTMFSenderHandlerMock::insertDTMF):
+ * platform/mock/RTCDTMFSenderHandlerMock.h: Added.
+ * platform/mock/RTCPeerConnectionHandlerMock.cpp:
+ (WebCore::RTCPeerConnectionHandlerMock::createDTMFSender):
+
</ins><span class="cx"> 2014-06-02 Xabier Rodriguez Calvar <calvaris@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] media controls should prevent 'click' events from reaching the page
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmockRTCDTMFSenderHandlerMockcpp"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/platform/mock/RTCDTMFSenderHandlerMock.cpp (0 => 169528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mock/RTCDTMFSenderHandlerMock.cpp (rev 0)
+++ trunk/Source/WebCore/platform/mock/RTCDTMFSenderHandlerMock.cpp 2014-06-02 10:55:37 UTC (rev 169528)
</span><span class="lines">@@ -0,0 +1,62 @@
</span><ins>+/*
+ * Copyright (C) 2014 Samsung Electornics and/or its subsidiary(-ies).
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+
+#if ENABLE(MEDIA_STREAM)
+#include "RTCDTMFSenderHandlerMock.h"
+
+#include "RTCDTMFSenderHandlerClient.h"
+
+namespace WebCore {
+
+RTCDTMFSenderHandlerMock::RTCDTMFSenderHandlerMock()
+ : m_duration(0)
+ , m_interToneGap(0)
+{
+}
+
+void RTCDTMFSenderHandlerMock::setClient(RTCDTMFSenderHandlerClient* client)
+{
+ m_client = client;
+}
+
+bool RTCDTMFSenderHandlerMock::insertDTMF(const String& tones, long duration, long interToneGap)
+{
+ m_duration = duration;
+ m_interToneGap = interToneGap;
+ m_toneBuffer.append(tones);
+ if (m_client) {
+ for (size_t i = 0; i < m_toneBuffer.length(); ++i)
+ m_client->didPlayTone(m_toneBuffer.substring(i, 1));
+ m_toneBuffer = emptyString();
+ m_client->didPlayTone(emptyString());
+ }
+ return true;
+}
+
+} // namespace WebCore
+
+#endif // ENABLE(MEDIA_STREAM)
</ins></span></pre></div>
<a id="trunkSourceWebCoreplatformmockRTCDTMFSenderHandlerMockh"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/platform/mock/RTCDTMFSenderHandlerMock.h (0 => 169528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mock/RTCDTMFSenderHandlerMock.h (rev 0)
+++ trunk/Source/WebCore/platform/mock/RTCDTMFSenderHandlerMock.h 2014-06-02 10:55:37 UTC (rev 169528)
</span><span class="lines">@@ -0,0 +1,58 @@
</span><ins>+/*
+ * Copyright (C) 2014 Samsung Electornics and/or its subsidiary(-ies).
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef RTCDTMFSenderHandlerMock_h
+#define RTCDTMFSenderHandlerMock_h
+
+#if ENABLE(MEDIA_STREAM)
+
+#include "RTCDTMFSenderHandler.h"
+#include "RTCPeerConnectionHandler.h"
+
+namespace WebCore {
+
+class RTCDTMFSenderHandlerMock final : public RTCDTMFSenderHandler {
+public:
+ RTCDTMFSenderHandlerMock();
+ virtual ~RTCDTMFSenderHandlerMock() { }
+
+ virtual void setClient(RTCDTMFSenderHandlerClient*) override;
+ virtual String currentToneBuffer() override { return m_toneBuffer; }
+ virtual bool canInsertDTMF() override { return true; }
+ virtual bool insertDTMF(const String& tones, long duration, long interToneGap) override;
+
+private:
+ RTCDTMFSenderHandlerClient* m_client;
+
+ String m_toneBuffer;
+ long m_duration;
+ long m_interToneGap;
+};
+
+} // namespace WebCore
+
+#endif // ENABLE(MEDIA_STREAM)
+
+#endif // RTCDataChannelHandlerMock_h
</ins></span></pre></div>
<a id="trunkSourceWebCoreplatformmockRTCPeerConnectionHandlerMockcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.cpp (169527 => 169528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.cpp 2014-06-02 08:31:26 UTC (rev 169527)
+++ trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.cpp 2014-06-02 10:55:37 UTC (rev 169528)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> #include "MediaConstraintsMock.h"
</span><span class="cx"> #include "NotImplemented.h"
</span><span class="cx"> #include "RTCDTMFSenderHandler.h"
</span><ins>+#include "RTCDTMFSenderHandlerMock.h"
</ins><span class="cx"> #include "RTCDataChannelHandler.h"
</span><span class="cx"> #include "RTCDataChannelHandlerMock.h"
</span><span class="cx"> #include "RTCNotifiersMock.h"
</span><span class="lines">@@ -167,10 +168,7 @@
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<RTCDTMFSenderHandler> RTCPeerConnectionHandlerMock::createDTMFSender(PassRefPtr<MediaStreamSource>)
</span><span class="cx"> {
</span><del>- // Requires a mock implementation of RTCDTMFSenderHandler.
- // This must be implemented once the mock implementation of RTCDataChannelHandler is ready.
- notImplemented();
- return nullptr;
</del><ins>+ return std::make_unique<RTCDTMFSenderHandlerMock>();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RTCPeerConnectionHandlerMock::stop()
</span></span></pre>
</div>
</div>
</body>
</html>