<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169527] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169527">169527</a></dd>
<dt>Author</dt> <dd>calvaris@igalia.com</dd>
<dt>Date</dt> <dd>2014-06-02 01:31:26 -0700 (Mon, 02 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] media controls should prevent 'click' events from reaching the page
https://bugs.webkit.org/show_bug.cgi?id=133402
Reviewed by Eric Carlson.
When handling events, we events we need to return true in order
that the superclass gets the value and prevents the execution of
the default event handler in the page.
Test: media/media-controls-cancel-events.html
* Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.handleMuteButtonMouseOver):
(ControllerGtk.prototype.handleVolumeBoxMouseOut):
(ControllerGtk.prototype.handleCaptionButtonClicked):
(ControllerGtk.prototype.handleCaptionButtonMouseOver):
(ControllerGtk.prototype.handleCaptionButtonShowMenu):
(ControllerGtk.prototype.handleCaptionButtonMouseOut):
(ControllerGtk.prototype.handleCaptionMouseOut): Return true to
prevent forwarding the event execution.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsGtkjs">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169526 => 169527)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-02 07:32:13 UTC (rev 169526)
+++ trunk/Source/WebCore/ChangeLog 2014-06-02 08:31:26 UTC (rev 169527)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2014-06-02 Xabier Rodriguez Calvar <calvaris@igalia.com>
+
+ [GTK] media controls should prevent 'click' events from reaching the page
+ https://bugs.webkit.org/show_bug.cgi?id=133402
+
+ Reviewed by Eric Carlson.
+
+ When handling events, we events we need to return true in order
+ that the superclass gets the value and prevents the execution of
+ the default event handler in the page.
+
+ Test: media/media-controls-cancel-events.html
+
+ * Modules/mediacontrols/mediaControlsGtk.js:
+ (ControllerGtk.prototype.handleMuteButtonMouseOver):
+ (ControllerGtk.prototype.handleVolumeBoxMouseOut):
+ (ControllerGtk.prototype.handleCaptionButtonClicked):
+ (ControllerGtk.prototype.handleCaptionButtonMouseOver):
+ (ControllerGtk.prototype.handleCaptionButtonShowMenu):
+ (ControllerGtk.prototype.handleCaptionButtonMouseOut):
+ (ControllerGtk.prototype.handleCaptionMouseOut): Return true to
+ prevent forwarding the event execution.
+
</ins><span class="cx"> 2014-06-02 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> CSS JIT: add support for the "not" pseudo class
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsGtkjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js (169526 => 169527)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js 2014-06-02 07:32:13 UTC (rev 169526)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js 2014-06-02 08:31:26 UTC (rev 169527)
</span><span class="lines">@@ -121,11 +121,13 @@
</span><span class="cx"> this.controls.panel.classList.remove(this.ClassNames.down);
</span><span class="cx"> }
</span><span class="cx"> this.controls.volumeBox.classList.remove(this.ClassNames.hiding);
</span><ins>+ return true;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> handleVolumeBoxMouseOut: function(event)
</span><span class="cx"> {
</span><span class="cx"> this.controls.volumeBox.classList.add(this.ClassNames.hiding);
</span><ins>+ return true;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> addControls: function()
</span><span class="lines">@@ -165,6 +167,7 @@
</span><span class="cx"> handleCaptionButtonClicked: function(event)
</span><span class="cx"> {
</span><span class="cx"> this.handleCaptionButtonShowMenu(event)
</span><ins>+ return true;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> buildCaptionMenu: function()
</span><span class="lines">@@ -212,6 +215,7 @@
</span><span class="cx"> handleCaptionButtonMouseOver: function(event)
</span><span class="cx"> {
</span><span class="cx"> this.handleCaptionButtonShowMenu(event);
</span><ins>+ return true;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> handleCaptionButtonShowMenu: function(event)
</span><span class="lines">@@ -220,12 +224,14 @@
</span><span class="cx"> this.buildCaptionMenu();
</span><span class="cx"> if (!contains(this.captionMenu.captionMenuTreeElements, event.relatedTarget))
</span><span class="cx"> this.showCaptionMenu();
</span><ins>+ return true;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> handleCaptionButtonMouseOut: function(event)
</span><span class="cx"> {
</span><span class="cx"> if (this.captionMenu && !contains(this.captionMenu.captionMenuTreeElements, event.relatedTarget))
</span><span class="cx"> this.hideCaptionMenu();
</span><ins>+ return true;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> handleCaptionMouseOut: function(event)
</span><span class="lines">@@ -233,6 +239,7 @@
</span><span class="cx"> if (event.relatedTarget != this.controls.captionButton &&
</span><span class="cx"> !contains(this.captionMenu.captionMenuTreeElements, event.relatedTarget))
</span><span class="cx"> this.hideCaptionMenu();
</span><ins>+ return true;
</ins><span class="cx"> },
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>