<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169517] trunk/PerformanceTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169517">169517</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-06-01 14:12:00 -0700 (Sun, 01 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>DYEBench: Move test states into benchmarkClient and remove the closure
https://bugs.webkit.org/show_bug.cgi?id=133438
Reviewed by Benjamin Poulain.
Moved all local variables in the closure wrapping benchmarkClient onto the object itself
and removed the closure to improve the readability of the code.
* DoYouEvenBench/Full.html:
* DoYouEvenBench/resources/main.js:
(window.benchmarkClient.willRunTest):
(window.benchmarkClient.didRunTest):
(window.benchmarkClient.didRunSuites):
(window.benchmarkClient.willStartFirstIteration):
(window.benchmarkClient.didFinishLastIteration):
(window.benchmarkClient._addResult): Moved.
(.): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>
<li><a href="#trunkPerformanceTestsDoYouEvenBenchFullhtml">trunk/PerformanceTests/DoYouEvenBench/Full.html</a></li>
<li><a href="#trunkPerformanceTestsDoYouEvenBenchresourcesmainjs">trunk/PerformanceTests/DoYouEvenBench/resources/main.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkPerformanceTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (169516 => 169517)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/ChangeLog 2014-06-01 20:38:55 UTC (rev 169516)
+++ trunk/PerformanceTests/ChangeLog 2014-06-01 21:12:00 UTC (rev 169517)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2014-06-01 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ DYEBench: Move test states into benchmarkClient and remove the closure
+ https://bugs.webkit.org/show_bug.cgi?id=133438
+
+ Reviewed by Benjamin Poulain.
+
+ Moved all local variables in the closure wrapping benchmarkClient onto the object itself
+ and removed the closure to improve the readability of the code.
+
+ * DoYouEvenBench/Full.html:
+ * DoYouEvenBench/resources/main.js:
+ (window.benchmarkClient.willRunTest):
+ (window.benchmarkClient.didRunTest):
+ (window.benchmarkClient.didRunSuites):
+ (window.benchmarkClient.willStartFirstIteration):
+ (window.benchmarkClient.didFinishLastIteration):
+ (window.benchmarkClient._addResult): Moved.
+ (.): Deleted.
+
+2014-06-01 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> DYEBench: Split stylesheets and scripts in Full.html into separate files
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=133437
</span><span class="cx">
</span></span></pre></div>
<a id="trunkPerformanceTestsDoYouEvenBenchFullhtml"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/DoYouEvenBench/Full.html (169516 => 169517)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/DoYouEvenBench/Full.html 2014-06-01 20:38:55 UTC (rev 169516)
+++ trunk/PerformanceTests/DoYouEvenBench/Full.html 2014-06-01 21:12:00 UTC (rev 169517)
</span><span class="lines">@@ -2,7 +2,7 @@
</span><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</span><del>- <title>DoYouEvenBench v0.16</title>
</del><ins>+ <title>DoYouEvenBench v0.17</title>
</ins><span class="cx"> <link rel="stylesheet" href="resources/main.css">
</span><span class="cx"> <script src="resources/main.js" defer></script>
</span><span class="cx"> <script src="resources/benchmark-runner.js" defer></script>
</span></span></pre></div>
<a id="trunkPerformanceTestsDoYouEvenBenchresourcesmainjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/DoYouEvenBench/resources/main.js (169516 => 169517)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/DoYouEvenBench/resources/main.js 2014-06-01 20:38:55 UTC (rev 169516)
+++ trunk/PerformanceTests/DoYouEvenBench/resources/main.js 2014-06-01 21:12:00 UTC (rev 169517)
</span><span class="lines">@@ -1,56 +1,37 @@
</span><del>-(function () {
-
-var values = [];
-var resultContainer = null;
-var title;
-var progressContainer;
-var progress;
-var iterationNumber = 0;
-var finishedTestCount = 0;
-
-function addResult(title, value) {
- if (!resultContainer) {
- resultContainer = document.createElement('table');
- var caption = document.createElement('caption');
- caption.textContent = document.title;
- resultContainer.appendChild(caption);
- document.body.appendChild(resultContainer);
- }
- if (!title)
- return;
- var row = document.createElement('tr');
- var th = document.createElement('th');
- th.textContent = title;
- var td = document.createElement('td');
- td.textContent = value;
- row.appendChild(th);
- row.appendChild(td);
- resultContainer.appendChild(row);
-}
-
</del><span class="cx"> window.benchmarkClient = {
</span><span class="cx"> iterationCount: 20,
</span><del>- willRunTest: function () {
- if (!progress) {
- // We don't use the real progress element as some implementations animate it.
- progressContainer = document.createElement('div');
- progressContainer.appendChild(document.createElement('div'));
- progressContainer.id = 'progressContainer';
- document.body.appendChild(progressContainer);
- progress = progressContainer.firstChild;
- }
- addResult();
- },
</del><ins>+ _timeValues: [],
+ _finishedTestCount: 0,
+ _iterationNumber: 0,
+ _progress: null,
+ _progressCompleted: null,
+ _resultContainer: null,
+ willRunTest: function () { },
</ins><span class="cx"> didRunTest: function () {
</span><del>- finishedTestCount++;
- progress.style.width = (finishedTestCount * 100 / this.testsCount) + '%';
</del><ins>+ this._finishedTestCount++;
+ this._progressCompleted.style.width = (this._finishedTestCount * 100 / this.testsCount) + '%';
</ins><span class="cx"> },
</span><span class="cx"> didRunSuites: function (measuredValues) {
</span><del>- values.push(measuredValues.total);
- iterationNumber++;
- addResult('Iteration ' + iterationNumber, measuredValues.total.toFixed(2) + ' ms');
</del><ins>+ this._timeValues.push(measuredValues.total);
+ this._iterationNumber++;
+ this._addResult('Iteration ' + this._iterationNumber, measuredValues.total.toFixed(2) + ' ms');
</ins><span class="cx"> },
</span><ins>+ willStartFirstIteration: function () {
+ // We don't use the real progress element as some implementations animate it.
+ this._progress = document.createElement('div');
+ this._progress.appendChild(document.createElement('div'));
+ this._progress.id = 'progressContainer';
+ document.body.appendChild(this._progress);
+ this._progressCompleted = this._progress.firstChild;
+
+ this._resultContainer = document.createElement('table');
+ var caption = document.createElement('caption');
+ caption.textContent = document.title;
+ this._resultContainer.appendChild(caption);
+ document.body.appendChild(this._resultContainer);
+ },
</ins><span class="cx"> didFinishLastIteration: function () {
</span><ins>+ var values = this._timeValues;
</ins><span class="cx"> var sum = values.reduce(function (a, b) { return a + b; }, 0);
</span><span class="cx"> var arithmeticMean = sum / values.length;
</span><span class="cx"> var meanLabel = arithmeticMean.toFixed(2) + ' ms';
</span><span class="lines">@@ -59,13 +40,21 @@
</span><span class="cx"> var precentDelta = delta * 100 / arithmeticMean;
</span><span class="cx"> meanLabel += ' \xb1 ' + delta.toFixed(2) + ' ms (' + precentDelta.toFixed(2) + '%)';
</span><span class="cx"> }
</span><del>- addResult('Arithmetic Mean', meanLabel);
- progressContainer.parentNode.removeChild(progressContainer);
</del><ins>+ this._addResult('Arithmetic Mean', meanLabel);
+ this._progress.parentNode.removeChild(this._progress);
+ },
+ _addResult: function (title, value) {
+ var row = document.createElement('tr');
+ var th = document.createElement('th');
+ th.textContent = title;
+ var td = document.createElement('td');
+ td.textContent = value;
+ row.appendChild(th);
+ row.appendChild(td);
+ this._resultContainer.appendChild(row);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-})();
-
</del><span class="cx"> function startBenchmark() {
</span><span class="cx"> var enabledSuites = Suites.filter(function (suite) { return !suite.disabled });
</span><span class="cx"> var totalSubtestCount = enabledSuites.reduce(function (testsCount, suite) { return testsCount + suite.tests.length; }, 0);
</span></span></pre>
</div>
</div>
</body>
</html>