<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169515] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169515">169515</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-06-01 09:30:58 -0700 (Sun, 01 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: Selection gap produces a pixel line overlap on inline boxes.
https://bugs.webkit.org/show_bug.cgi?id=133429
Reviewed by Simon Fraser.
Do not floor logical right/left values when selection gap is calculated for RenderBlocks.
It produces overlapping line/gap because the floored value is intersecting/too far from the
non-floored content selection rect.
Source/WebCore:
Tests: fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html
fast/inline/hidpi-selection-gap-overlaps-inline-selection.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
LayoutTests:
* platform/mac/TestExpectations: add ML failure due to font sizing. (Ahem can't be used here)
* fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl-expected.html: Added.
* fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html: Added.
* fast/inline/hidpi-selection-gap-overlaps-inline-selection-expected.html: Added.
* fast/inline/hidpi-selection-gap-overlaps-inline-selection.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockcpp">trunk/Source/WebCore/rendering/RenderBlock.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastinlinehidpiselectiongapandinlineselectionhavegaprtlexpectedhtml">trunk/LayoutTests/fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastinlinehidpiselectiongapandinlineselectionhavegaprtlhtml">trunk/LayoutTests/fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html</a></li>
<li><a href="#trunkLayoutTestsfastinlinehidpiselectiongapoverlapsinlineselectionexpectedhtml">trunk/LayoutTests/fast/inline/hidpi-selection-gap-overlaps-inline-selection-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastinlinehidpiselectiongapoverlapsinlineselectionhtml">trunk/LayoutTests/fast/inline/hidpi-selection-gap-overlaps-inline-selection.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (169514 => 169515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-06-01 13:44:32 UTC (rev 169514)
+++ trunk/LayoutTests/ChangeLog 2014-06-01 16:30:58 UTC (rev 169515)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-06-01 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Selection gap produces a pixel line overlap on inline boxes.
+ https://bugs.webkit.org/show_bug.cgi?id=133429
+
+ Reviewed by Simon Fraser.
+
+ Do not floor logical right/left values when selection gap is calculated for RenderBlocks.
+ It produces overlapping line/gap because the floored value is intersecting/too far from the
+ non-floored content selection rect.
+
+ * platform/mac/TestExpectations: add ML failure due to font sizing. (Ahem can't be used here)
+ * fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl-expected.html: Added.
+ * fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html: Added.
+ * fast/inline/hidpi-selection-gap-overlaps-inline-selection-expected.html: Added.
+ * fast/inline/hidpi-selection-gap-overlaps-inline-selection.html: Added.
+
</ins><span class="cx"> 2014-05-31 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> One more missed piece of that last check-in.
</span></span></pre></div>
<a id="trunkLayoutTestsfastinlinehidpiselectiongapandinlineselectionhavegaprtlexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl-expected.html (0 => 169515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl-expected.html (rev 0)
+++ trunk/LayoutTests/fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl-expected.html 2014-06-01 16:30:58 UTC (rev 169515)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that there's no pixel gap between the selection gap and inlines when selected (RTL).</title>
+<style>
+ body {
+ margin: 0px;
+ }
+ .bckg {
+ width: 100%;
+ height: 30px;
+ background: rgba(255, 0, 0, 0.9);
+ z-index: -10000;
+ }
+</style>
+</head>
+<body>
+<div class=bckg></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastinlinehidpiselectiongapandinlineselectionhavegaprtlhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html (0 => 169515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html (rev 0)
+++ trunk/LayoutTests/fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html 2014-06-01 16:30:58 UTC (rev 169515)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that there's no pixel gap between the selection gap and inlines when selected (RTL).</title>
+<style>
+ body {
+ direction: rtl;
+ margin: 0px;
+ color: rgba(255, 255, 255, 0);
+ font-size: 26px;
+ font-family: '.LucidaGrandeUI';
+ }
+ ::selection {
+ background: rgba(255, 0, 0, 0.9);
+ }
+</style>
+</head>
+<body>
+<div id="container">foo</div>
+bar
+<script>
+ var range = document.createRange();
+ range.selectNode(document.getElementById("container"));
+ window.getSelection().addRange(range);
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastinlinehidpiselectiongapoverlapsinlineselectionexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/inline/hidpi-selection-gap-overlaps-inline-selection-expected.html (0 => 169515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/inline/hidpi-selection-gap-overlaps-inline-selection-expected.html (rev 0)
+++ trunk/LayoutTests/fast/inline/hidpi-selection-gap-overlaps-inline-selection-expected.html 2014-06-01 16:30:58 UTC (rev 169515)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that there's no overlapping line between the selection gap and inlines when selected.</title>
+<style>
+ body {
+ margin: 0px;
+ }
+ .bckg {
+ width: 100%;
+ height: 30px;
+ background: rgba(255, 0, 0, 0.9);
+ z-index: -10000;
+ }
+</style>
+</head>
+<body>
+<div class=bckg></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastinlinehidpiselectiongapoverlapsinlineselectionhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/inline/hidpi-selection-gap-overlaps-inline-selection.html (0 => 169515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/inline/hidpi-selection-gap-overlaps-inline-selection.html (rev 0)
+++ trunk/LayoutTests/fast/inline/hidpi-selection-gap-overlaps-inline-selection.html 2014-06-01 16:30:58 UTC (rev 169515)
</span><span class="lines">@@ -0,0 +1,26 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that there's no overlapping line between the selection gap and inlines when selected.</title>
+<style>
+ body {
+ margin: 0px;
+ color: rgba(255, 255, 255, 0);
+ font-size: 26px;
+ font-family: '.LucidaGrandeUI';
+ }
+ ::selection {
+ background: rgba(255, 0, 0, 0.9);
+ }
+</style>
+</head>
+<body>
+<div id="container">foo</div>
+bar
+<script>
+ var range = document.createRange();
+ range.selectNode(document.getElementById("container"));
+ window.getSelection().addRange(range);
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (169514 => 169515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2014-06-01 13:44:32 UTC (rev 169514)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2014-06-01 16:30:58 UTC (rev 169515)
</span><span class="lines">@@ -1285,6 +1285,9 @@
</span><span class="cx"> webkit.org/b/132990 fast/regions/overflow-size-change-with-stacking-context.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/132990 fast/regions/overflow-size-change-in-variable-width-regions.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/132990 fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html [ ImageOnlyFailure ]
</span><ins>+# These tests require fractional text widths. Ahem can't provide it -> using LucidaGrandeUI -> fails on ML due to different font size.
+[ MountainLion ] fast/inline/hidpi-selection-gap-overlaps-inline-selection.html [ ImageOnlyFailure ]
+[ MountainLion ] fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html [ ImageOnlyFailure ]
</ins><span class="cx"> # End of subpixel failures.
</span><span class="cx">
</span><span class="cx"> webkit.org/b/35297 media/video-display-aspect-ratio.html [ Pass Failure ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169514 => 169515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-01 13:44:32 UTC (rev 169514)
+++ trunk/Source/WebCore/ChangeLog 2014-06-01 16:30:58 UTC (rev 169515)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-06-01 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Selection gap produces a pixel line overlap on inline boxes.
+ https://bugs.webkit.org/show_bug.cgi?id=133429
+
+ Reviewed by Simon Fraser.
+
+ Do not floor logical right/left values when selection gap is calculated for RenderBlocks.
+ It produces overlapping line/gap because the floored value is intersecting/too far from the
+ non-floored content selection rect.
+
+ Tests: fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html
+ fast/inline/hidpi-selection-gap-overlaps-inline-selection.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::logicalLeftSelectionGap):
+ (WebCore::RenderBlock::logicalRightSelectionGap):
+
</ins><span class="cx"> 2014-05-31 Timothy Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r169412): Garbage pixels when vertical rubber-banding on http://yvoschaap.com/pmarca/
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (169514 => 169515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-06-01 13:44:32 UTC (rev 169514)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-06-01 16:30:58 UTC (rev 169515)
</span><span class="lines">@@ -2074,7 +2074,7 @@
</span><span class="cx"> {
</span><span class="cx"> LayoutUnit rootBlockLogicalTop = blockDirectionOffset(rootBlock, offsetFromRootBlock) + logicalTop;
</span><span class="cx"> LayoutUnit rootBlockLogicalLeft = std::max(logicalLeftSelectionOffset(rootBlock, logicalTop, cache), logicalLeftSelectionOffset(rootBlock, logicalTop + logicalHeight, cache));
</span><del>- LayoutUnit rootBlockLogicalRight = std::min(inlineDirectionOffset(rootBlock, offsetFromRootBlock) + floorToInt(logicalLeft),
</del><ins>+ LayoutUnit rootBlockLogicalRight = std::min(inlineDirectionOffset(rootBlock, offsetFromRootBlock) + logicalLeft,
</ins><span class="cx"> std::min(logicalRightSelectionOffset(rootBlock, logicalTop, cache), logicalRightSelectionOffset(rootBlock, logicalTop + logicalHeight, cache)));
</span><span class="cx"> LayoutUnit rootBlockLogicalWidth = rootBlockLogicalRight - rootBlockLogicalLeft;
</span><span class="cx"> if (rootBlockLogicalWidth <= 0)
</span><span class="lines">@@ -2090,7 +2090,7 @@
</span><span class="cx"> RenderObject* selObj, LayoutUnit logicalRight, LayoutUnit logicalTop, LayoutUnit logicalHeight, const LogicalSelectionOffsetCaches& cache, const PaintInfo* paintInfo)
</span><span class="cx"> {
</span><span class="cx"> LayoutUnit rootBlockLogicalTop = blockDirectionOffset(rootBlock, offsetFromRootBlock) + logicalTop;
</span><del>- LayoutUnit rootBlockLogicalLeft = std::max(inlineDirectionOffset(rootBlock, offsetFromRootBlock) + floorToInt(logicalRight),
</del><ins>+ LayoutUnit rootBlockLogicalLeft = std::max(inlineDirectionOffset(rootBlock, offsetFromRootBlock) + logicalRight,
</ins><span class="cx"> std::max(logicalLeftSelectionOffset(rootBlock, logicalTop, cache), logicalLeftSelectionOffset(rootBlock, logicalTop + logicalHeight, cache)));
</span><span class="cx"> LayoutUnit rootBlockLogicalRight = std::min(logicalRightSelectionOffset(rootBlock, logicalTop, cache), logicalRightSelectionOffset(rootBlock, logicalTop + logicalHeight, cache));
</span><span class="cx"> LayoutUnit rootBlockLogicalWidth = rootBlockLogicalRight - rootBlockLogicalLeft;
</span></span></pre>
</div>
</div>
</body>
</html>