<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169488] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169488">169488</a></dd>
<dt>Author</dt> <dd>mario.prada@samsung.com</dd>
<dt>Date</dt> <dd>2014-05-30 09:49:26 -0700 (Fri, 30 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Don't use logAccessibilityEvents() in aria-slider-required-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=133405
Reviewed by Chris Fleizach.
Change the test to use addNotificationListener() instead.
* platform/gtk/TestExpectations: Removed failure expectation
* platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated
* platform/gtk/accessibility/aria-slider-required-attributes.html: Updated</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilityariasliderrequiredattributesexpectedtxt">trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkaccessibilityariasliderrequiredattributeshtml">trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (169487 => 169488)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-30 16:47:06 UTC (rev 169487)
+++ trunk/LayoutTests/ChangeLog 2014-05-30 16:49:26 UTC (rev 169488)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2014-05-30 Mario Sanchez Prada <mario.prada@samsung.com>
</span><span class="cx">
</span><ins>+ [GTK] Don't use logAccessibilityEvents() in aria-slider-required-attributes.html
+ https://bugs.webkit.org/show_bug.cgi?id=133405
+
+ Reviewed by Chris Fleizach.
+
+ Change the test to use addNotificationListener() instead.
+
+ * platform/gtk/TestExpectations: Removed failure expectation
+ * platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated
+ * platform/gtk/accessibility/aria-slider-required-attributes.html: Updated
+
+2014-05-30 Mario Sanchez Prada <mario.prada@samsung.com>
+
</ins><span class="cx"> [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=132280
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (169487 => 169488)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-05-30 16:47:06 UTC (rev 169487)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-05-30 16:49:26 UTC (rev 169488)
</span><span class="lines">@@ -1641,7 +1641,6 @@
</span><span class="cx"> webkit.org/b/113772 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html [ Failure ]
</span><span class="cx"> webkit.org/b/113772 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached.html [ Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/114259 platform/gtk/accessibility/aria-slider-required-attributes.html [ Failure ]
</del><span class="cx"> webkit.org/b/114259 platform/gtk/accessibility/combo-box-collapsed-selection-changed.html [ Failure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/115025 fast/events/constructors/mouse-event-constructor.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilityariasliderrequiredattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt (169487 => 169488)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt 2014-05-30 16:47:06 UTC (rev 169487)
+++ trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt 2014-05-30 16:49:26 UTC (rev 169488)
</span><span class="lines">@@ -1,18 +1,16 @@
</span><del>-Accessibility object emitted "state-change:busy = 0" / Name: "(No name)" / Role: 80
-Accessibility object emitted "property-change:accessible-value" / Name: "(No name)" / Role: 50
-Accessibility object emitted "property-change:accessible-value" / Name: "(No name)" / Role: 50
</del><span class="cx"> This tests the exposure of attributes for an ARIA slider.
</span><span class="cx">
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS successfullyParsed is true
-
-TEST COMPLETE
</del><span class="cx"> PASS axSlider.role is 'AXRole: AXSlider'
</span><span class="cx"> PASS axSlider.intValue is 50
</span><span class="cx"> PASS axSlider.minValue is 0
</span><span class="cx"> PASS axSlider.maxValue is 100
</span><span class="cx"> PASS axSlider.intValue is 75
</span><span class="cx"> PASS axSlider.intValue is 35
</span><ins>+PASS valueChangedNotifications is 2
+PASS successfullyParsed is true
</ins><span class="cx">
</span><ins>+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformgtkaccessibilityariasliderrequiredattributeshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html (169487 => 169488)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html 2014-05-30 16:47:06 UTC (rev 169487)
+++ trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html 2014-05-30 16:49:26 UTC (rev 169488)
</span><span class="lines">@@ -1,19 +1,34 @@
</span><span class="cx"> <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
</span><span class="cx"> <html>
</span><span class="cx"> <head>
</span><ins>+<script src="../../../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+<div role="application">
+ <span id="slider" tabindex="0" role="slider" aria-valuemin="0" aria-valuemax="100" aria-valuenow="50"></span>
+</div>
+<p id="description"></p>
+<div id="console"></div>
</ins><span class="cx"> <script>
</span><ins>+window.jsTestIsAsync = true;
</ins><span class="cx">
</span><del>-function finishTest()
-{
- testRunner.notifyDone();
</del><ins>+description("This tests the exposure of attributes for an ARIA slider.");
+
+var valueChangedNotifications = 0;
+
+function notificationCallback(element, notification) {
+ if (element.role == "AXRole: AXSlider" && notification == "AXValueChanged")
+ valueChangedNotifications++;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-function runTest()
-{
</del><ins>+if (window.testRunner && window.accessibilityController) {
+ testRunner.dumpAsText();
+
</ins><span class="cx"> slider = document.getElementById("slider");
</span><span class="cx"> slider.focus();
</span><span class="cx">
</span><span class="cx"> axSlider = accessibilityController.focusedElement;
</span><ins>+ accessibilityController.addNotificationListener(notificationCallback);
</ins><span class="cx">
</span><span class="cx"> shouldBe("axSlider.role", "'AXRole: AXSlider'");
</span><span class="cx"> shouldBe("axSlider.intValue", "50");
</span><span class="lines">@@ -26,29 +41,16 @@
</span><span class="cx"> slider.setAttribute("aria-valuenow", "35");
</span><span class="cx"> shouldBe("axSlider.intValue", "35");
</span><span class="cx">
</span><del>- window.setTimeout("finishTest();", 0);
-}
-</script>
-<script src="../../../resources/js-test-pre.js"></script>
-</head>
-<body id="body" onload="runTest();">
-<div role="application">
- <span id="slider" tabindex="0" role="slider" aria-valuemin="0" aria-valuemax="100" aria-valuenow="50"></span>
-</div>
-<p id="description"></p>
-<div id="console"></div>
-<script>
-description("This tests the exposure of attributes for an ARIA slider.");
</del><ins>+ window.setTimeout(function() {
+ if (window.accessibilityController)
+ accessibilityController.removeNotificationListener();
</ins><span class="cx">
</span><del>-if (window.accessibilityController) {
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
</del><ins>+ shouldBe("valueChangedNotifications", "2");
+ finishJSTest();
+ },
+ 0);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-if (window.accessibilityController) {
- accessibilityController.logAccessibilityEvents();
-}
-
</del><span class="cx"> </script>
</span><span class="cx"> <script src="../../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre>
</div>
</div>
</body>
</html>