<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169363] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169363">169363</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-26 17:19:17 -0700 (Mon, 26 May 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>CSS JIT: Fix build error raised when CSS_SELECTOR_JIT_DEBUGGING is 1
https://bugs.webkit.org/show_bug.cgi?id=133266

Patch by Yusuke Suzuki &lt;utatane.tea@gmail.com&gt; on 2014-05-26
Reviewed by Benjamin Poulain.

When CSS_SELECTOR_JIT_DEBUGGING is 1, build erros occur on x86_64.

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateEpilogue):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssjitSelectorCompilercpp">trunk/Source/WebCore/cssjit/SelectorCompiler.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169362 => 169363)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-05-27 00:02:34 UTC (rev 169362)
+++ trunk/Source/WebCore/ChangeLog        2014-05-27 00:19:17 UTC (rev 169363)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-05-26  Yusuke Suzuki  &lt;utatane.tea@gmail.com&gt;
+
+        CSS JIT: Fix build error raised when CSS_SELECTOR_JIT_DEBUGGING is 1
+        https://bugs.webkit.org/show_bug.cgi?id=133266
+
+        Reviewed by Benjamin Poulain.
+
+        When CSS_SELECTOR_JIT_DEBUGGING is 1, build erros occur on x86_64.
+
+        * cssjit/SelectorCompiler.cpp:
+        (WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
+        (WebCore::SelectorCompiler::SelectorCodeGenerator::generateEpilogue):
+
</ins><span class="cx"> 2014-05-26  Benjamin Poulain  &lt;benjamin@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Fix the quirks mode selector matching of the pseudo classes :hover and :active
</span></span></pre></div>
<a id="trunkSourceWebCorecssjitSelectorCompilercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/cssjit/SelectorCompiler.cpp (169362 => 169363)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/cssjit/SelectorCompiler.cpp        2014-05-27 00:02:34 UTC (rev 169362)
+++ trunk/Source/WebCore/cssjit/SelectorCompiler.cpp        2014-05-27 00:19:17 UTC (rev 169363)
</span><span class="lines">@@ -45,6 +45,7 @@
</span><span class="cx"> #include &quot;SelectorCheckerTestFunctions.h&quot;
</span><span class="cx"> #include &quot;StackAllocator.h&quot;
</span><span class="cx"> #include &quot;StyledElement.h&quot;
</span><ins>+#include &lt;JavaScriptCore/GPRInfo.h&gt;
</ins><span class="cx"> #include &lt;JavaScriptCore/LinkBuffer.h&gt;
</span><span class="cx"> #include &lt;JavaScriptCore/MacroAssembler.h&gt;
</span><span class="cx"> #include &lt;JavaScriptCore/VM.h&gt;
</span><span class="lines">@@ -174,9 +175,10 @@
</span><span class="cx">     SelectorCompilationStatus compile(JSC::VM*, JSC::MacroAssemblerCodeRef&amp;);
</span><span class="cx"> 
</span><span class="cx"> private:
</span><del>-    static const Assembler::RegisterID returnRegister = JSC::GPRInfo::returnValueGPR;
-    static const Assembler::RegisterID elementAddressRegister = JSC::GPRInfo::argumentGPR0;
-    static const Assembler::RegisterID checkingContextRegister = JSC::GPRInfo::argumentGPR1;
</del><ins>+    static const Assembler::RegisterID returnRegister;
+    static const Assembler::RegisterID elementAddressRegister;
+    static const Assembler::RegisterID checkingContextRegister;
+    static const Assembler::RegisterID callFrameRegister;
</ins><span class="cx"> 
</span><span class="cx">     void computeBacktrackingInformation();
</span><span class="cx">     void generateSelectorChecker();
</span><span class="lines">@@ -259,6 +261,11 @@
</span><span class="cx"> #endif
</span><span class="cx"> };
</span><span class="cx"> 
</span><ins>+const Assembler::RegisterID SelectorCodeGenerator::returnRegister = JSC::GPRInfo::returnValueGPR;
+const Assembler::RegisterID SelectorCodeGenerator::elementAddressRegister = JSC::GPRInfo::argumentGPR0;
+const Assembler::RegisterID SelectorCodeGenerator::checkingContextRegister = JSC::GPRInfo::argumentGPR1;
+const Assembler::RegisterID SelectorCodeGenerator::callFrameRegister = JSC::GPRInfo::callFrameRegister;
+
</ins><span class="cx"> SelectorCompilationStatus compileSelector(const CSSSelector* lastSelector, JSC::VM* vm, SelectorContext selectorContext, JSC::MacroAssemblerCodeRef&amp; codeRef)
</span><span class="cx"> {
</span><span class="cx">     if (!vm-&gt;canUseJIT())
</span><span class="lines">@@ -939,7 +946,7 @@
</span><span class="cx">     return true;
</span><span class="cx"> #elif CPU(X86_64) &amp;&amp; CSS_SELECTOR_JIT_DEBUGGING
</span><span class="cx">     Vector&lt;JSC::MacroAssembler::RegisterID, 1&gt; prologueRegister;
</span><del>-    prologueRegister.append(GPRInfo::callFrameRegister);
</del><ins>+    prologueRegister.append(callFrameRegister);
</ins><span class="cx">     m_prologueStackReferences = m_stackAllocator.push(prologueRegister);
</span><span class="cx">     return true;
</span><span class="cx"> #endif
</span><span class="lines">@@ -955,7 +962,7 @@
</span><span class="cx">     m_stackAllocator.pop(m_prologueStackReferences, prologueRegisters);
</span><span class="cx"> #elif CPU(X86_64) &amp;&amp; CSS_SELECTOR_JIT_DEBUGGING
</span><span class="cx">     Vector&lt;JSC::MacroAssembler::RegisterID, 1&gt; prologueRegister;
</span><del>-    prologueRegister.append(GPRInfo::callFrameRegister);
</del><ins>+    prologueRegister.append(callFrameRegister);
</ins><span class="cx">     m_stackAllocator.pop(m_prologueStackReferences, prologueRegister);
</span><span class="cx"> #endif
</span><span class="cx"> }
</span></span></pre>
</div>
</div>

</body>
</html>