<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169319] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169319">169319</a></dd>
<dt>Author</dt> <dd>ddkilzer@apple.com</dd>
<dt>Date</dt> <dd>2014-05-25 11:00:09 -0700 (Sun, 25 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use type-checking FilterOperation casts in CoordinatedGraphicsArgumentCoders.cpp
<http://webkit.org/b/133203>
Reviewed by Simon Fraser.
* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::FilterOperations>::encode):
- Replace static_cast<>() operators with type-checking
FilterOperation casts.
- Replace 'default' statement with 'case' statements so new
filters added later require an explicit decision to be made.
(IPC::ArgumentCoder<WebCore::FilterOperations>::decode):
- Replace 'default' statement with 'case' statements so new
filters added later require an explicit decision to be made.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedCoordinatedGraphicsCoordinatedGraphicsArgumentCoderscpp">trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (169318 => 169319)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-05-25 16:37:38 UTC (rev 169318)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-25 18:00:09 UTC (rev 169319)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-05-25 David Kilzer <ddkilzer@apple.com>
+
+ Use type-checking FilterOperation casts in CoordinatedGraphicsArgumentCoders.cpp
+ <http://webkit.org/b/133203>
+
+ Reviewed by Simon Fraser.
+
+ * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
+ (IPC::ArgumentCoder<WebCore::FilterOperations>::encode):
+ - Replace static_cast<>() operators with type-checking
+ FilterOperation casts.
+ - Replace 'default' statement with 'case' statements so new
+ filters added later require an explicit decision to be made.
+ (IPC::ArgumentCoder<WebCore::FilterOperations>::decode):
+ - Replace 'default' statement with 'case' statements so new
+ filters added later require an explicit decision to be made.
+
</ins><span class="cx"> 2014-05-24 Jon Honeycutt <jhoneycutt@apple.com>
</span><span class="cx">
</span><span class="cx"> Potential null dereference in
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedCoordinatedGraphicsCoordinatedGraphicsArgumentCoderscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp (169318 => 169319)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp 2014-05-25 16:37:38 UTC (rev 169318)
+++ trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp 2014-05-25 18:00:09 UTC (rev 169319)
</span><span class="lines">@@ -76,25 +76,28 @@
</span><span class="cx"> case FilterOperation::SEPIA:
</span><span class="cx"> case FilterOperation::SATURATE:
</span><span class="cx"> case FilterOperation::HUE_ROTATE:
</span><del>- encoder << static_cast<double>(static_cast<const BasicColorMatrixFilterOperation*>(filter)->amount());
</del><ins>+ encoder << static_cast<double>(toBasicColorMatrixFilterOperation(filter)->amount());
</ins><span class="cx"> break;
</span><span class="cx"> case FilterOperation::INVERT:
</span><span class="cx"> case FilterOperation::BRIGHTNESS:
</span><span class="cx"> case FilterOperation::CONTRAST:
</span><span class="cx"> case FilterOperation::OPACITY:
</span><del>- encoder << static_cast<double>(static_cast<const BasicComponentTransferFilterOperation*>(filter)->amount());
</del><ins>+ encoder << static_cast<double>(toBasicComponentTransferFilterOperation(filter)->amount());
</ins><span class="cx"> break;
</span><span class="cx"> case FilterOperation::BLUR:
</span><del>- ArgumentCoder<Length>::encode(encoder, static_cast<const BlurFilterOperation*>(filter)->stdDeviation());
</del><ins>+ ArgumentCoder<Length>::encode(encoder, toBlurFilterOperation(filter)->stdDeviation());
</ins><span class="cx"> break;
</span><span class="cx"> case FilterOperation::DROP_SHADOW: {
</span><del>- const DropShadowFilterOperation* shadow = static_cast<const DropShadowFilterOperation*>(filter);
</del><ins>+ const DropShadowFilterOperation* shadow = toDropShadowFilterOperation(filter);
</ins><span class="cx"> ArgumentCoder<IntPoint>::encode(encoder, shadow->location());
</span><span class="cx"> encoder << static_cast<int32_t>(shadow->stdDeviation());
</span><span class="cx"> ArgumentCoder<Color>::encode(encoder, shadow->color());
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- default:
</del><ins>+ case FilterOperation::REFERENCE:
+ case FilterOperation::PASSTHROUGH:
+ case FilterOperation::DEFAULT:
+ case FilterOperation::NONE:
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -155,7 +158,10 @@
</span><span class="cx"> filter = DropShadowFilterOperation::create(location, stdDeviation, color);
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- default:
</del><ins>+ case FilterOperation::REFERENCE:
+ case FilterOperation::PASSTHROUGH:
+ case FilterOperation::DEFAULT:
+ case FilterOperation::NONE:
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>