<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169177] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169177">169177</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2014-05-21 14:35:53 -0700 (Wed, 21 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS] Update some of the media controls buttons to be bigger
https://bugs.webkit.org/show_bug.cgi?id=133158
<rdar://problem/16475828>
Reviewed by Simon Fraser.
The buttons in the media controls on iOS are too small
to be comfortably pressed. Make them the size of the controls
panel and the expected iOS button size (44x44px).
The artwork for the buttons now includes the padding. I've
added a file from which you can edit the artwork, then
copy it into the CSS (because editing directly in CSS is
a huge pain).
So far just the play/pause and fullscreen button have been
updated. There will be a follow-up patch to fix the remaining
buttons and the scrubber.
* Modules/mediacontrols/assets-apple-iOS.svg: Added.
* Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-panel):
(audio::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-play-button:active):
(audio::-webkit-media-controls-play-button.paused):
(audio::-webkit-media-controls-fullscreen-button:active):
(@media only screen and (-webkit-min-device-pixel-ratio: 2)): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsiOScss">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsassetsappleiOSsvg">trunk/Source/WebCore/Modules/mediacontrols/assets-apple-iOS.svg</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169176 => 169177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-21 20:52:21 UTC (rev 169176)
+++ trunk/Source/WebCore/ChangeLog 2014-05-21 21:35:53 UTC (rev 169177)
</span><span class="lines">@@ -1,3 +1,34 @@
</span><ins>+2014-05-21 Dean Jackson <dino@apple.com>
+
+ [iOS] Update some of the media controls buttons to be bigger
+ https://bugs.webkit.org/show_bug.cgi?id=133158
+ <rdar://problem/16475828>
+
+ Reviewed by Simon Fraser.
+
+ The buttons in the media controls on iOS are too small
+ to be comfortably pressed. Make them the size of the controls
+ panel and the expected iOS button size (44x44px).
+
+ The artwork for the buttons now includes the padding. I've
+ added a file from which you can edit the artwork, then
+ copy it into the CSS (because editing directly in CSS is
+ a huge pain).
+
+ So far just the play/pause and fullscreen button have been
+ updated. There will be a follow-up patch to fix the remaining
+ buttons and the scrubber.
+
+ * Modules/mediacontrols/assets-apple-iOS.svg: Added.
+ * Modules/mediacontrols/mediaControlsiOS.css:
+ (audio::-webkit-media-controls-panel):
+ (audio::-webkit-media-controls-fullscreen-button):
+ (audio::-webkit-media-controls-play-button):
+ (audio::-webkit-media-controls-play-button:active):
+ (audio::-webkit-media-controls-play-button.paused):
+ (audio::-webkit-media-controls-fullscreen-button:active):
+ (@media only screen and (-webkit-min-device-pixel-ratio: 2)): Deleted.
+
</ins><span class="cx"> 2014-05-21 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Garbage when rubber-banding at the right edge of a page zoomed to non-integral scale.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsassetsappleiOSsvg"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/Modules/mediacontrols/assets-apple-iOS.svg (0 => 169177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/assets-apple-iOS.svg (rev 0)
+++ trunk/Source/WebCore/Modules/mediacontrols/assets-apple-iOS.svg 2014-05-21 21:35:53 UTC (rev 169177)
</span><span class="lines">@@ -0,0 +1,52 @@
</span><ins>+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 190 44">
+
+ <!--
+ NOTE: THIS FILE IS NOT PART OF THE BUILD PROCESS. EDITS
+ HERE ARE NOT AUTOMATICALLY COPIED TO THE CSS FILES.
+
+ This file holds the raw assets used in mediaControlsApple.css.
+ This is not part of the build process at the moment, but manually
+ copied into the CSS. However, editing from CSS is a burden, so
+ the idea is that you develop here and then paste into CSS.
+ -->
+
+ <!-- PLAY -->
+
+ <g transform="translate(0 0)">
+ <rect width="44" height="44" fill="rgb(255, 255, 200)"/>
+ <svg width="44" height="44">
+ <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 44">
+ <path fill="rgba(0, 0, 0, 0.8)" d="M10,11 32,22 10,33z"/>
+ </svg>
+ </svg>
+ </g>
+
+ <!-- PAUSE -->
+
+ <g transform="translate(46 0)">
+ <rect width="44" height="44" fill="rgb(255, 255, 200)"/>
+ <svg width="44" height="44">
+ <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 44">
+ <g fill="rgba(0, 0, 0, 0.8)">
+ <rect x="13" y="11" width="6" height="22"/>
+ <rect x="24" y="11" width="6" height="22"/>
+ </g>
+ </svg>
+ </svg>
+ </g>
+
+ <!-- FULLSCREEN -->
+
+ <g transform="translate(92 0)">
+ <rect width="44" height="44" fill="rgb(255, 255, 200)"/>
+ <svg width="44" height="44">
+ <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 44">
+ <g stroke="rgba(0, 0, 0, 0.8)" fill="none">
+ <path d="M 14,20 v -6 h 6 M 14,14 l 6,6"/>
+ <path d="M 30,24 v 6 h -6 M 30,30 l -6,-6"/>
+ </g>
+ </svg>
+ </svg>
+ </g>
+
+</svg>
</ins><span class="cx">\ No newline at end of file
</span><span class="cx">Property changes on: trunk/Source/WebCore/Modules/mediacontrols/assets-apple-iOS.svg
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="svnkeywords"></a>
<div class="addfile"><h4>Added: svn:keywords</h4></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsiOScss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (169176 => 169177)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2014-05-21 20:52:21 UTC (rev 169176)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2014-05-21 21:35:53 UTC (rev 169177)
</span><span class="lines">@@ -109,9 +109,8 @@
</span><span class="cx"> position: absolute;
</span><span class="cx"> bottom: 0;
</span><span class="cx"> width: 100%;
</span><del>- padding-bottom: 1px;
</del><ins>+ padding: none;
</ins><span class="cx"> height: 44px;
</span><del>- line-height: 44px;
</del><span class="cx"> -webkit-user-select: none;
</span><span class="cx"> background-color: rgba(245, 245, 245, .75);
</span><span class="cx">
</span><span class="lines">@@ -178,50 +177,39 @@
</span><span class="cx"> display: block;
</span><span class="cx"> padding: 0;
</span><span class="cx"> border: 0;
</span><del>- background-color: rgba(0, 0, 0, .5);
- -webkit-mask-origin: content-box;
- -webkit-mask-repeat: no-repeat;
- -webkit-mask-size: contain;
</del><span class="cx"> -webkit-user-select: none;
</span><ins>+ margin-left: 8px;
+ margin-right: 8px;
+ width: 44px;
+ height: 44px;
+ background-color: transparent;
+ background-size: 44px 44px;
+ background-repeat: no-repeat;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-video::-webkit-media-controls-play-button:active,
-audio::-webkit-media-controls-play-button:active,
-video::-webkit-media-controls-fullscreen-button:active,
-audio::-webkit-media-controls-fullscreen-button:active {
- background-color: white;
-}
-
</del><span class="cx"> video::-webkit-media-controls-play-button,
</span><span class="cx"> audio::-webkit-media-controls-play-button {
</span><del>- margin-left: 34px;
- margin-right: 15px;
- margin-top: 1px;
- width: 21px;
- height: 23px;
- -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="21" height="22"><rect x="1" y="0" width="6" height="22" fill="white"/><rect x="13" y="0" width="6" height="22" fill="white"/></svg>');
</del><ins>+ background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 44"><g fill="rgba(0, 0, 0, 0.8)"><rect x="13" y="11" width="6" height="22"/><rect x="24" y="11" width="6" height="22"/></g></svg>');
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+video::-webkit-media-controls-play-button:active,
+audio::-webkit-media-controls-play-button:active {
+ background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 44"><g fill="white"><rect x="13" y="11" width="6" height="22"/><rect x="24" y="11" width="6" height="22"/></g></svg>');
+}
+
</ins><span class="cx"> video::-webkit-media-controls-play-button.paused,
</span><span class="cx"> audio::-webkit-media-controls-play-button.paused {
</span><del>- -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="21" height="23"><path d="M 0,0.25 21,10.5 0,21.75 z" fill="white"/></svg>');
</del><ins>+ background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 44"><path fill="rgba(0, 0, 0, 0.8)" d="M11,11 32,22 11,33z"/></svg>');
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> video::-webkit-media-controls-fullscreen-button,
</span><span class="cx"> audio::-webkit-media-controls-fullscreen-button {
</span><del>- margin-right: 34px;
- margin-left: 13px;
- width: 15px;
- height: 15px;
- -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="15px" height="15px"><g stroke="white" fill="transparent"><path d="M .5,5 v -4.5 h 4.5M .5,.5 l 5.5,5.5" /> <path d="M 14.5,10 v 4.5 h -4.5 M 14.5,14.5 l -5.5,-5.5" /></g></svg>');
</del><ins>+ background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 44"><g stroke="rgba(0, 0, 0, 0.8)" fill="none"><path d="M 14,20 v -6 h 6 M 14,14 l 6,6"/><path d="M 30,24 v 6 h -6 M 30,30 l -6,-6"/></g></svg>');
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-/* Retina images */
-@media only screen and (-webkit-min-device-pixel-ratio: 2) {
- video::-webkit-media-controls-fullscreen-button,
- audio::-webkit-media-controls-fullscreen-button {
- -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 30 30"><g stroke="white" stroke-width="2" fill="transparent"><path d="M 1,9 v -8 h 8 M 1,1 l 11,11" /> <path d="M 29,21 v 8 h -8 M 29,29 l -11,-11" /></g></svg>');
- }
</del><ins>+video::-webkit-media-controls-fullscreen-button:active,
+audio::-webkit-media-controls-fullscreen-button:active {
+ background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 44 44"><g stroke="white" fill="none"><path d="M 14,20 v -6 h 6 M 14,14 l 6,6"/><path d="M 30,24 v 6 h -6 M 30,30 l -6,-6"/></g></svg>');
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> video::-webkit-media-controls-timeline,
</span></span></pre>
</div>
</div>
</body>
</html>