<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169181] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169181">169181</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-21 17:12:47 -0700 (Wed, 21 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
https://bugs.webkit.org/show_bug.cgi?id=132907
Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-05-21
Reviewed by Gyuyoung Kim.
.:
* Source/cmake/FindLIBCXXABI.cmake: Added.
* Source/cmake/OptionsEfl.cmake:
Source/JavaScriptCore:
* CMakeLists.txt:
Tools:
We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
* efl/install-dependencies:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreCMakeListstxt">trunk/Source/JavaScriptCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourcecmakeOptionsEflcmake">trunk/Source/cmake/OptionsEfl.cmake</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolseflinstalldependencies">trunk/Tools/efl/install-dependencies</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourcecmakeFindLIBCXXABIcmake">trunk/Source/cmake/FindLIBCXXABI.cmake</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (169180 => 169181)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2014-05-22 00:11:07 UTC (rev 169180)
+++ trunk/ChangeLog 2014-05-22 00:12:47 UTC (rev 169181)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-05-21 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
+
+ [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=132907
+
+ Reviewed by Gyuyoung Kim.
+
+ * Source/cmake/FindLIBCXXABI.cmake: Added.
+ * Source/cmake/OptionsEfl.cmake:
+
</ins><span class="cx"> 2014-05-21 Michał Pakuła vel Rutka <m.pakula@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL] Turn on ENABLE_CSS_FILTERS
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/CMakeLists.txt (169180 => 169181)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/CMakeLists.txt 2014-05-22 00:11:07 UTC (rev 169180)
+++ trunk/Source/JavaScriptCore/CMakeLists.txt 2014-05-22 00:12:47 UTC (rev 169181)
</span><span class="lines">@@ -688,6 +688,7 @@
</span><span class="cx"> # Added extra items for JavaScriptCore
</span><span class="cx"> list(APPEND JavaScriptCore_INCLUDE_DIRECTORIES
</span><span class="cx"> ${LLVM_INCLUDE_DIRS}
</span><ins>+ ${LIBCXXABI_INCLUDE_DIRS}
</ins><span class="cx"> )
</span><span class="cx">
</span><span class="cx"> list(APPEND JavaScriptCore_SOURCES
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (169180 => 169181)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-05-22 00:11:07 UTC (rev 169180)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-05-22 00:12:47 UTC (rev 169181)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-05-21 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
+
+ [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=132907
+
+ Reviewed by Gyuyoung Kim.
+
+ * CMakeLists.txt:
+
</ins><span class="cx"> 2014-05-16 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CMake] Improve handling of LIB_INSTALL_DIR, EXEC_INSTALL_DIR, and LIBEXEC_INSTALL_DIR
</span></span></pre></div>
<a id="trunkSourcecmakeFindLIBCXXABIcmake"></a>
<div class="addfile"><h4>Added: trunk/Source/cmake/FindLIBCXXABI.cmake (0 => 169181)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/FindLIBCXXABI.cmake (rev 0)
+++ trunk/Source/cmake/FindLIBCXXABI.cmake 2014-05-22 00:12:47 UTC (rev 169181)
</span><span class="lines">@@ -0,0 +1,40 @@
</span><ins>+# - Try to find libcxxabi
+# This module defines the following variable:
+#
+# LIBCXXABI_FOUND - true if libcxxabi found
+# LIBCXXABI_INCLUDE_DIRS - the libcxxabi include directories
+#
+# Copyright (C) 2014 Samsung Electronics
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER AND ITS CONTRIBUTORS ``AS
+# IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR ITS
+# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
+# OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
+# OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
+# ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+find_path(LIBCXXABI_INCLUDE_DIRS
+ NAMES mach-o/compact_unwind_encoding.h
+ PATH_SUFFIXES libcxxabi
+)
+
+include(FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(Libcxxabi DEFAULT_MSG LIBCXXABI_INCLUDE_DIRS)
+
+mark_as_advanced(
+ LIBCXXABI_INCLUDE_DIRS
+)
</ins></span></pre></div>
<a id="trunkSourcecmakeOptionsEflcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmake/OptionsEfl.cmake (169180 => 169181)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/OptionsEfl.cmake 2014-05-22 00:11:07 UTC (rev 169180)
+++ trunk/Source/cmake/OptionsEfl.cmake 2014-05-22 00:12:47 UTC (rev 169181)
</span><span class="lines">@@ -292,6 +292,7 @@
</span><span class="cx">
</span><span class="cx"> if (ENABLE_FTL_JIT)
</span><span class="cx"> find_package(LLVM REQUIRED)
</span><ins>+ find_package(LIBCXXABI REQUIRED)
</ins><span class="cx"> set(HAVE_LLVM ON)
</span><span class="cx"> endif ()
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (169180 => 169181)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-05-22 00:11:07 UTC (rev 169180)
+++ trunk/Tools/ChangeLog 2014-05-22 00:12:47 UTC (rev 169181)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-05-21 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
+
+ [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=132907
+
+ Reviewed by Gyuyoung Kim.
+
+ We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
+ in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
+
+ * efl/install-dependencies:
+
</ins><span class="cx"> 2014-05-21 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
</span></span></pre></div>
<a id="trunkToolseflinstalldependencies"></a>
<div class="modfile"><h4>Modified: trunk/Tools/efl/install-dependencies (169180 => 169181)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/efl/install-dependencies 2014-05-22 00:11:07 UTC (rev 169180)
+++ trunk/Tools/efl/install-dependencies 2014-05-22 00:12:47 UTC (rev 169181)
</span><span class="lines">@@ -62,6 +62,7 @@
</span><span class="cx"> libxrender-dev \
</span><span class="cx"> libp11-kit-dev \
</span><span class="cx"> libgpg-error-dev \
</span><ins>+ libc++abi-dev \
</ins><span class="cx"> libgcrypt11-dev
</span><span class="cx">
</span><span class="cx"> # These are dependencies necessary for running tests.
</span></span></pre>
</div>
</div>
</body>
</html>