<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169172] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169172">169172</a></dd>
<dt>Author</dt> <dd>m.pakula@samsung.com</dd>
<dt>Date</dt> <dd>2014-05-21 11:22:28 -0700 (Wed, 21 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] Turn on ENABLE_CSS_FILTERS
https://bugs.webkit.org/show_bug.cgi?id=133153
Reviewed by Gyuyoung Kim.
.:
* Source/cmake/OptionsEfl.cmake: Enable CSS_FILTERS as default option value.
Source/WebKit2:
Make WebKit2 compile after <a href="http://trac.webkit.org/projects/webkit/changeset/166741">r166741</a> when CSS_FILTERS are enabled.
* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::FilterOperations>::decode):
LayoutTests:
Remove failure test expectations for tests passing after turning on CSS_FILTERS.
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformeflwk2TestExpectations">trunk/LayoutTests/platform/efl-wk2/TestExpectations</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedCoordinatedGraphicsCoordinatedGraphicsArgumentCoderscpp">trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp</a></li>
<li><a href="#trunkSourcecmakeOptionsEflcmake">trunk/Source/cmake/OptionsEfl.cmake</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (169171 => 169172)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2014-05-21 18:18:29 UTC (rev 169171)
+++ trunk/ChangeLog 2014-05-21 18:22:28 UTC (rev 169172)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-05-21 Michał Pakuła vel Rutka <m.pakula@samsung.com>
+
+ [EFL] Turn on ENABLE_CSS_FILTERS
+ https://bugs.webkit.org/show_bug.cgi?id=133153
+
+ Reviewed by Gyuyoung Kim.
+
+ * Source/cmake/OptionsEfl.cmake: Enable CSS_FILTERS as default option value.
+
</ins><span class="cx"> 2014-05-16 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CMake] Improve handling of LIB_INSTALL_DIR, EXEC_INSTALL_DIR, and LIBEXEC_INSTALL_DIR
</span></span></pre></div>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (169171 => 169172)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-21 18:18:29 UTC (rev 169171)
+++ trunk/LayoutTests/ChangeLog 2014-05-21 18:22:28 UTC (rev 169172)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-05-21 Michał Pakuła vel Rutka <m.pakula@samsung.com>
+
+ [EFL] Turn on ENABLE_CSS_FILTERS
+ https://bugs.webkit.org/show_bug.cgi?id=133153
+
+ Reviewed by Gyuyoung Kim.
+
+ Remove failure test expectations for tests passing after turning on CSS_FILTERS.
+
+ * platform/efl-wk2/TestExpectations:
+ * platform/efl/TestExpectations:
+
</ins><span class="cx"> 2014-05-21 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed Mac gardening after r169161.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (169171 => 169172)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations 2014-05-21 18:18:29 UTC (rev 169171)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2014-05-21 18:22:28 UTC (rev 169172)
</span><span class="lines">@@ -1456,18 +1456,8 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/124414 animations/cross-fade-background-image.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><del>-# ref test mismatch does not occur
-webkit.org/b/124417 fast/css/drop-shadow-viewport-height.html [ ImageOnlyFailure ]
-webkit.org/b/124417 fast/css/drop-shadow-viewport-vmax.html [ ImageOnlyFailure ]
-webkit.org/b/124417 fast/css/drop-shadow-viewport-vmin.html [ ImageOnlyFailure ]
-webkit.org/b/124417 fast/css/drop-shadow-viewport-width.html [ ImageOnlyFailure ]
-
</del><span class="cx"> # CSS filters layout tests are failing
</span><del>-webkit.org/b/124516 fast/filter-image/filter-image-animation.html [ Failure ]
-webkit.org/b/124517 fast/filter-image/filter-image-blur.html [ ImageOnlyFailure ]
</del><span class="cx"> webkit.org/b/124518 fast/filter-image/filter-image-svg.html [ ImageOnlyFailure ]
</span><del>-webkit.org/b/124519 fast/filter-image/filter-image.html [ ImageOnlyFailure ]
-webkit.org/b/124519 fast/filter-image/parse-filter-image.html [ Failure ]
</del><span class="cx">
</span><span class="cx"> webkit.org/b/124582 fast/flexbox/clear-overflow-before-scroll-update.html [ Failure ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (169171 => 169172)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-05-21 18:18:29 UTC (rev 169171)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-05-21 18:22:28 UTC (rev 169172)
</span><span class="lines">@@ -349,9 +349,6 @@
</span><span class="cx"> webkit.org/b/98741 plugins/npruntime/browser-object-identity.html [ Failure ]
</span><span class="cx"> webkit.org/b/98741 plugins/refcount-leaks.html [ Failure ]
</span><span class="cx">
</span><del>-# New compositing tests introduced in r137051 that fail on WK2 EFL.
-webkit.org/b/104476 compositing/background-color/background-color-padding-change.html [ ImageOnlyFailure ]
-
</del><span class="cx"> # These ref tests are failing because the text is blurry.
</span><span class="cx"> webkit.org/b/105766 compositing/text-on-scaled-layer.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/105766 compositing/text-on-scaled-surface.html [ ImageOnlyFailure ]
</span><span class="lines">@@ -524,8 +521,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/128737 fast/events/touch/basic-multi-touch-events.html [ Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/129731 css3/masking/clip-path-filter.html [ ImageOnlyFailure ]
-
</del><span class="cx"> webkit.org/b/129734 fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/129735 fast/regions/box-decorations-over-region-padding.html [ ImageOnlyFailure ]
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (169171 => 169172)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-05-21 18:18:29 UTC (rev 169171)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-21 18:22:28 UTC (rev 169172)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-05-21 Michał Pakuła vel Rutka <m.pakula@samsung.com>
+
+ [EFL] Turn on ENABLE_CSS_FILTERS
+ https://bugs.webkit.org/show_bug.cgi?id=133153
+
+ Reviewed by Gyuyoung Kim.
+
+ Make WebKit2 compile after r166741 when CSS_FILTERS are enabled.
+
+ * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
+ (IPC::ArgumentCoder<WebCore::FilterOperations>::decode):
+
</ins><span class="cx"> 2014-05-21 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Special handling of telephone number detection menu.
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedCoordinatedGraphicsCoordinatedGraphicsArgumentCoderscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp (169171 => 169172)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp 2014-05-21 18:18:29 UTC (rev 169171)
+++ trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp 2014-05-21 18:22:28 UTC (rev 169172)
</span><span class="lines">@@ -139,7 +139,7 @@
</span><span class="cx"> Length length;
</span><span class="cx"> if (!ArgumentCoder<Length>::decode(decoder, length))
</span><span class="cx"> return false;
</span><del>- filter = BlurFilterOperation::create(length, type);
</del><ins>+ filter = BlurFilterOperation::create(length);
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> case FilterOperation::DROP_SHADOW: {
</span><span class="lines">@@ -152,7 +152,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> if (!ArgumentCoder<Color>::decode(decoder, color))
</span><span class="cx"> return false;
</span><del>- filter = DropShadowFilterOperation::create(location, stdDeviation, color, type);
</del><ins>+ filter = DropShadowFilterOperation::create(location, stdDeviation, color);
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> default:
</span></span></pre></div>
<a id="trunkSourcecmakeOptionsEflcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmake/OptionsEfl.cmake (169171 => 169172)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/OptionsEfl.cmake 2014-05-21 18:18:29 UTC (rev 169171)
+++ trunk/Source/cmake/OptionsEfl.cmake 2014-05-21 18:22:28 UTC (rev 169172)
</span><span class="lines">@@ -54,6 +54,7 @@
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BLOB ON)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT ON)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_DEVICE_ADAPTATION ON)
</span><ins>+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_FILTERS ON)
</ins><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_GRID_LAYOUT OFF)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET ON)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS ON)
</span></span></pre>
</div>
</div>
</body>
</html>