<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169160] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169160">169160</a></dd>
<dt>Author</dt> <dd>stavila@adobe.com</dd>
<dt>Date</dt> <dd>2014-05-21 08:31:20 -0700 (Wed, 21 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/168046">r168046</a>): Invalid layout in WebCore::RenderBox::containingBlockLogicalWidthForPositioned
https://bugs.webkit.org/show_bug.cgi?id=132933
Reviewed by Darin Adler.
Source/WebCore:
Invalid layout is performed when calling containingBlockLogicalWidthForPositioned for a RenderTableSection object.
Test: fast/multicol/newmulticol/table-section-crash.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
LayoutTests:
Added test for crash caused by invalid layout for RenderTableSection.
* fast/multicol/newmulticol/table-section-crash-expected.txt: Added.
* fast/multicol/newmulticol/table-section-crash.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastmulticolnewmulticoltablesectioncrashexpectedtxt">trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmulticolnewmulticoltablesectioncrashhtml">trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (169159 => 169160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-21 14:56:52 UTC (rev 169159)
+++ trunk/LayoutTests/ChangeLog 2014-05-21 15:31:20 UTC (rev 169160)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-05-21 Radu Stavila <stavila@adobe.com>
+
+ REGRESSION (r168046): Invalid layout in WebCore::RenderBox::containingBlockLogicalWidthForPositioned
+ https://bugs.webkit.org/show_bug.cgi?id=132933
+
+ Reviewed by Darin Adler.
+
+ Added test for crash caused by invalid layout for RenderTableSection.
+
+ * fast/multicol/newmulticol/table-section-crash-expected.txt: Added.
+ * fast/multicol/newmulticol/table-section-crash.html: Added.
+
</ins><span class="cx"> 2014-05-21 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r169092 and r169102): Skip failing JSC tests on ARM64 properly
</span></span></pre></div>
<a id="trunkLayoutTestsfastmulticolnewmulticoltablesectioncrashexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash-expected.txt (0 => 169160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash-expected.txt 2014-05-21 15:31:20 UTC (rev 169160)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastmulticolnewmulticoltablesectioncrashhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html (0 => 169160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html (rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html 2014-05-21 15:31:20 UTC (rev 169160)
</span><span class="lines">@@ -0,0 +1,39 @@
</span><ins>+<!-- This test passes if it doesn't crash - https://bugs.webkit.org/show_bug.cgi?id=132933 -->
+
+<body style="width: 800px; height: 600px">
+ <table>
+ <td id="td">
+ <table>
+ <tr id="td">
+</body>
+
+<script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ var head = document.getElementsByTagName("head")[0];
+ var style = document.createElement("style");
+ var rule = document.createTextNode("* { visibility: hidden; } #td { position: absolute;");
+ style.appendChild(rule);
+ head.appendChild(style);
+ style = document.createElement("style");
+ style.innerHTML = "* { \n\
+ position: -webkit-sticky;\n\
+ -webkit-animation-direction: alternate-reverse;";
+
+ head.appendChild(style);
+ style = document.createElement("style");
+ style.innerHTML = "#td { \n\
+ -webkit-animation-name: name3; \n\
+ -webkit-animation-duration: 9s; \n\
+ } \n\
+ @-webkit-keyframes name3 { \n\
+ from { \n\
+ } \n\
+ to { \n\
+ -webkit-column-count: 4294967167;";
+
+ head.appendChild(style);
+
+ //head.removeChild(style);
+</script>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169159 => 169160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-21 14:56:52 UTC (rev 169159)
+++ trunk/Source/WebCore/ChangeLog 2014-05-21 15:31:20 UTC (rev 169160)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-05-21 Radu Stavila <stavila@adobe.com>
+
+ REGRESSION (r168046): Invalid layout in WebCore::RenderBox::containingBlockLogicalWidthForPositioned
+ https://bugs.webkit.org/show_bug.cgi?id=132933
+
+ Reviewed by Darin Adler.
+
+ Invalid layout is performed when calling containingBlockLogicalWidthForPositioned for a RenderTableSection object.
+
+ Test: fast/multicol/newmulticol/table-section-crash.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
+
</ins><span class="cx"> 2014-05-21 Simon Pena <simon.pena@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL] Ensure EGLOffScreenContext::initialize calls platformMakeCurrent on the surface
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (169159 => 169160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2014-05-21 14:56:52 UTC (rev 169159)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2014-05-21 15:31:20 UTC (rev 169160)
</span><span class="lines">@@ -3073,6 +3073,9 @@
</span><span class="cx"> if (isFixedPosition && containingBlock->isRenderNamedFlowThread())
</span><span class="cx"> return containingBlock->view().clientLogicalWidth();
</span><span class="cx">
</span><ins>+ if (!containingBlock->isRenderBlock())
+ return toRenderBox(*containingBlock).clientLogicalWidth();
+
</ins><span class="cx"> const RenderBlock* cb = toRenderBlock(containingBlock);
</span><span class="cx"> RenderBoxRegionInfo* boxInfo = 0;
</span><span class="cx"> if (!region) {
</span></span></pre>
</div>
</div>
</body>
</html>