<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169146] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169146">169146</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2014-05-20 21:08:33 -0700 (Tue, 20 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Mac] DataCues do not work properly when rewinding video
https://bugs.webkit.org/show_bug.cgi?id=133138
<rdar://problem/16979086>
Reviewed by Eric Carlson.
Make the TrackPrivateBase responsible for knowing if a type of track needs a non-zero
startTimeVariance value.
Also, correct a bug in the equality test for DataCue objects.
* html/track/DataCue.cpp:
(WebCore::DataCue::isEqual): Handle the JSValue data types consistently, so that we don't attempt
to compare a JSNull against a default JSValue object.
* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::startTimeVariance): Added.
* html/track/InbandTextTrack.h:
* html/track/TextTrack.cpp:
(WebCore::TextTrack::hasCue): Use new startTimeVariance method location.
* html/track/TextTrack.h:
(WebCore::TextTrack::startTimeVariance): Added.
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::hasEquivalentStartTime): Use new startTimeVariance location.
* html/track/TextTrackCue.h:
(WebCore::TextTrackCue::startTimeVariance): Deleted.
* html/track/TextTrackCueGeneric.h:
* platform/graphics/TrackPrivateBase.h:
(WebCore::TrackPrivateBase::startTimeVariance): Added.
* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmltrackDataCuecpp">trunk/Source/WebCore/html/track/DataCue.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackInbandTextTrackcpp">trunk/Source/WebCore/html/track/InbandTextTrack.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackInbandTextTrackh">trunk/Source/WebCore/html/track/InbandTextTrack.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackTextTrackcpp">trunk/Source/WebCore/html/track/TextTrack.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackTextTrackh">trunk/Source/WebCore/html/track/TextTrack.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackTextTrackCuecpp">trunk/Source/WebCore/html/track/TextTrackCue.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackTextTrackCueh">trunk/Source/WebCore/html/track/TextTrackCue.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackTextTrackCueGenerich">trunk/Source/WebCore/html/track/TextTrackCueGeneric.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsTrackPrivateBaseh">trunk/Source/WebCore/platform/graphics/TrackPrivateBase.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationInbandTextTrackPrivateAVFh">trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/ChangeLog 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -1,3 +1,35 @@
</span><ins>+2014-05-20 Brent Fulgham <bfulgham@apple.com>
+
+ [Mac] DataCues do not work properly when rewinding video
+ https://bugs.webkit.org/show_bug.cgi?id=133138
+ <rdar://problem/16979086>
+
+ Reviewed by Eric Carlson.
+
+ Make the TrackPrivateBase responsible for knowing if a type of track needs a non-zero
+ startTimeVariance value.
+
+ Also, correct a bug in the equality test for DataCue objects.
+
+ * html/track/DataCue.cpp:
+ (WebCore::DataCue::isEqual): Handle the JSValue data types consistently, so that we don't attempt
+ to compare a JSNull against a default JSValue object.
+ * html/track/InbandTextTrack.cpp:
+ (WebCore::InbandTextTrack::startTimeVariance): Added.
+ * html/track/InbandTextTrack.h:
+ * html/track/TextTrack.cpp:
+ (WebCore::TextTrack::hasCue): Use new startTimeVariance method location.
+ * html/track/TextTrack.h:
+ (WebCore::TextTrack::startTimeVariance): Added.
+ * html/track/TextTrackCue.cpp:
+ (WebCore::TextTrackCue::hasEquivalentStartTime): Use new startTimeVariance location.
+ * html/track/TextTrackCue.h:
+ (WebCore::TextTrackCue::startTimeVariance): Deleted.
+ * html/track/TextTrackCueGeneric.h:
+ * platform/graphics/TrackPrivateBase.h:
+ (WebCore::TrackPrivateBase::startTimeVariance): Added.
+ * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
+
</ins><span class="cx"> 2014-05-20 Mark Hahnenberg <mhahnenberg@apple.com>
</span><span class="cx">
</span><span class="cx"> Watchdog timer should be lazily allocated
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackDataCuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/DataCue.cpp (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/DataCue.cpp 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/html/track/DataCue.cpp 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -145,10 +145,11 @@
</span><span class="cx"> if (m_platformValue && !m_platformValue->isEqual(*otherPlatformValue.get()))
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+ JSC::JSValue thisValue = value(nullptr);
</ins><span class="cx"> JSC::JSValue otherValue = dataCue->value(nullptr);
</span><del>- if ((otherValue && !m_value) || (!otherValue && m_value))
</del><ins>+ if ((otherValue && !thisValue) || (!otherValue && thisValue))
</ins><span class="cx"> return false;
</span><del>- if (!JSC::JSValue::strictEqual(nullptr, m_value ? m_value : JSC::JSValue(), otherValue))
</del><ins>+ if (!JSC::JSValue::strictEqual(nullptr, thisValue, otherValue))
</ins><span class="cx"> return false;
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackInbandTextTrackcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/InbandTextTrack.cpp (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/InbandTextTrack.cpp 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/html/track/InbandTextTrack.cpp 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -213,6 +213,14 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+double InbandTextTrack::startTimeVariance() const
+{
+ if (!m_private)
+ return false;
+
+ return m_private->startTimeVariance();
+}
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackInbandTextTrackh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/InbandTextTrack.h (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/InbandTextTrack.h 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/html/track/InbandTextTrack.h 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -82,6 +82,7 @@
</span><span class="cx"> virtual void removeGenericCue(InbandTextTrackPrivate*, GenericCueData*) override { ASSERT_NOT_REACHED(); }
</span><span class="cx">
</span><span class="cx"> virtual void parseWebVTTCueData(InbandTextTrackPrivate*, const char*, unsigned) override { ASSERT_NOT_REACHED(); }
</span><ins>+ virtual double startTimeVariance() const;
</ins><span class="cx">
</span><span class="cx"> #if USE(PLATFORM_TEXT_TRACK_MENU)
</span><span class="cx"> virtual InbandTextTrackPrivate* privateTrack() override { return m_private.get(); }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackTextTrackcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/TextTrack.cpp (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/TextTrack.cpp 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/html/track/TextTrack.cpp 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -519,7 +519,7 @@
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> existingCue = m_cues->item(searchStart - 1);
</span><del>- if (!existingCue || cue->startTime() > (existingCue->startTime() + existingCue->startTimeVariance()))
</del><ins>+ if (!existingCue || cue->startTime() > (existingCue->startTime() + startTimeVariance()))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> if (!existingCue->isEqual(*cue, match))
</span><span class="lines">@@ -531,7 +531,7 @@
</span><span class="cx">
</span><span class="cx"> size_t index = (searchStart + searchEnd) / 2;
</span><span class="cx"> existingCue = m_cues->item(index);
</span><del>- if ((cue->startTime() + existingCue->startTimeVariance()) < existingCue->startTime() || (match != TextTrackCue::IgnoreDuration && cue->hasEquivalentStartTime(*existingCue) && cue->endTime() > existingCue->endTime()))
</del><ins>+ if ((cue->startTime() + startTimeVariance()) < existingCue->startTime() || (match != TextTrackCue::IgnoreDuration && cue->hasEquivalentStartTime(*existingCue) && cue->endTime() > existingCue->endTime()))
</ins><span class="cx"> searchEnd = index;
</span><span class="cx"> else
</span><span class="cx"> searchStart = index + 1;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackTextTrackh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/TextTrack.h (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/TextTrack.h 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/html/track/TextTrack.h 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> /*
</span><span class="cx"> * Copyright (C) 2011 Google Inc. All rights reserved.
</span><del>- * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2011, 2012, 2013, 2014 Apple Inc. All rights reserved.
</ins><span class="cx"> *
</span><span class="cx"> * Redistribution and use in source and binary forms, with or without
</span><span class="cx"> * modification, are permitted provided that the following conditions
</span><span class="lines">@@ -158,6 +158,8 @@
</span><span class="cx">
</span><span class="cx"> virtual bool isInband() const { return false; }
</span><span class="cx">
</span><ins>+ virtual double startTimeVariance() const { return 0; }
+
</ins><span class="cx"> using RefCounted<TrackBase>::ref;
</span><span class="cx"> using RefCounted<TrackBase>::deref;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackTextTrackCuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/TextTrackCue.cpp (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/TextTrackCue.cpp 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/html/track/TextTrackCue.cpp 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -219,7 +219,13 @@
</span><span class="cx">
</span><span class="cx"> bool TextTrackCue::hasEquivalentStartTime(const TextTrackCue& cue) const
</span><span class="cx"> {
</span><del>- return std::abs(std::abs(startTime()) - std::abs(cue.startTime())) < startTimeVariance();
</del><ins>+ double startTimeVariance = 0;
+ if (track())
+ startTimeVariance = track()->startTimeVariance();
+ else if (cue.track())
+ startTimeVariance = cue.track()->startTimeVariance();
+
+ return std::abs(std::abs(startTime()) - std::abs(cue.startTime())) <= startTimeVariance;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackTextTrackCueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/TextTrackCue.h (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/TextTrackCue.h 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/html/track/TextTrackCue.h 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -84,7 +84,6 @@
</span><span class="cx"> virtual bool isOrderedBefore(const TextTrackCue*) const;
</span><span class="cx">
</span><span class="cx"> bool hasEquivalentStartTime(const TextTrackCue&) const;
</span><del>- virtual double startTimeVariance() const { return 0; }
</del><span class="cx">
</span><span class="cx"> enum CueType {
</span><span class="cx"> Data,
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackTextTrackCueGenerich"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/TextTrackCueGeneric.h (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/TextTrackCueGeneric.h 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/html/track/TextTrackCueGeneric.h 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -78,7 +78,6 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> virtual bool isOrderedBefore(const TextTrackCue*) const override;
</span><del>- virtual double startTimeVariance() const override { return 0.25; }
</del><span class="cx">
</span><span class="cx"> TextTrackCueGeneric(ScriptExecutionContext&, double start, double end, const String&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsTrackPrivateBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/TrackPrivateBase.h (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/TrackPrivateBase.h 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/platform/graphics/TrackPrivateBase.h 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -61,6 +61,8 @@
</span><span class="cx">
</span><span class="cx"> virtual int trackIndex() const { return 0; }
</span><span class="cx">
</span><ins>+ virtual double startTimeVariance() const { return 0; }
+
</ins><span class="cx"> void willBeRemoved()
</span><span class="cx"> {
</span><span class="cx"> if (TrackPrivateBaseClient* client = this->client())
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationInbandTextTrackPrivateAVFh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h (169145 => 169146)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h 2014-05-21 03:49:16 UTC (rev 169145)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h 2014-05-21 04:08:33 UTC (rev 169146)
</span><span class="lines">@@ -69,6 +69,8 @@
</span><span class="cx"> };
</span><span class="cx"> virtual Category textTrackCategory() const = 0;
</span><span class="cx">
</span><ins>+ virtual double startTimeVariance() const override { return 0.25; }
+
</ins><span class="cx"> protected:
</span><span class="cx"> InbandTextTrackPrivateAVF(AVFInbandTrackParent*);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>