<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169047] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169047">169047</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2014-05-19 09:10:54 -0700 (Mon, 19 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: iOS: using AXAttributeCacheEnabler is too slow for every accessibilityElementAtIndex:
https://bugs.webkit.org/show_bug.cgi?id=133043
Reviewed by Mario Sanchez Prada.
iOS Accessibility code tries to improve performance by caching attributes when accessing
elements through the platform API. However, those API calls can be used very frequently when
iterating elements. Creating the AXAttributeCacheEnabler object and tearing it down is proving
to be the hottest code path in samples for accessibility access.
We need to move the logic for enabling/disabling the attribute cache to a level that can make
a more informed decision about when to enable/disable.
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper enableAttributeCaching]):
(-[WebAccessibilityObjectWrapper disableAttributeCaching]):
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm">trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169046 => 169047)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-19 15:53:37 UTC (rev 169046)
+++ trunk/Source/WebCore/ChangeLog 2014-05-19 16:10:54 UTC (rev 169047)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2014-05-18 Chris Fleizach <cfleizach@apple.com>
+
+ AX: iOS: using AXAttributeCacheEnabler is too slow for every accessibilityElementAtIndex:
+ https://bugs.webkit.org/show_bug.cgi?id=133043
+
+ Reviewed by Mario Sanchez Prada.
+
+ iOS Accessibility code tries to improve performance by caching attributes when accessing
+ elements through the platform API. However, those API calls can be used very frequently when
+ iterating elements. Creating the AXAttributeCacheEnabler object and tearing it down is proving
+ to be the hottest code path in samples for accessibility access.
+
+ We need to move the logic for enabling/disabling the attribute cache to a level that can make
+ a more informed decision about when to enable/disable.
+
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+ (-[WebAccessibilityObjectWrapper enableAttributeCaching]):
+ (-[WebAccessibilityObjectWrapper disableAttributeCaching]):
+ (-[WebAccessibilityObjectWrapper accessibilityElementCount]):
+ (-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
+ (-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
+
</ins><span class="cx"> 2014-05-18 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Use RenderStyle& in more places in RenderLayerBacking
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (169046 => 169047)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-05-19 15:53:37 UTC (rev 169046)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-05-19 16:10:54 UTC (rev 169047)
</span><span class="lines">@@ -341,12 +341,23 @@
</span><span class="cx"> return AccessibilityUnignoredAncestor(axObject->wrapper());
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (void)enableAttributeCaching
+{
+ if (AXObjectCache* cache = m_object->axObjectCache())
+ cache->startCachingComputedObjectAttributesUntilTreeMutates();
+}
+
+- (void)disableAttributeCaching
+{
+ if (AXObjectCache* cache = m_object->axObjectCache())
+ cache->stopCachingComputedObjectAttributes();
+}
+
</ins><span class="cx"> - (NSInteger)accessibilityElementCount
</span><span class="cx"> {
</span><span class="cx"> if (![self _prepareAccessibilityCall])
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- AXAttributeCacheEnabler enableCache(m_object->axObjectCache());
</del><span class="cx"> if ([self isAttachment])
</span><span class="cx"> return [[self attachmentView] accessibilityElementCount];
</span><span class="cx">
</span><span class="lines">@@ -358,7 +369,6 @@
</span><span class="cx"> if (![self _prepareAccessibilityCall])
</span><span class="cx"> return nil;
</span><span class="cx">
</span><del>- AXAttributeCacheEnabler enableCache(m_object->axObjectCache());
</del><span class="cx"> if ([self isAttachment])
</span><span class="cx"> return [[self attachmentView] accessibilityElementAtIndex:index];
</span><span class="cx">
</span><span class="lines">@@ -378,7 +388,6 @@
</span><span class="cx"> if (![self _prepareAccessibilityCall])
</span><span class="cx"> return NSNotFound;
</span><span class="cx">
</span><del>- AXAttributeCacheEnabler enableCache(m_object->axObjectCache());
</del><span class="cx"> if ([self isAttachment])
</span><span class="cx"> return [[self attachmentView] indexOfAccessibilityElement:element];
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>