<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169040] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169040">169040</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-19 02:00:56 -0700 (Mon, 19 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Removing some check-webkit-style warnings from ./dfg
https://bugs.webkit.org/show_bug.cgi?id=132854
Patch by Tanay C <tanay.c@samsung.com> on 2014-05-19
Reviewed by Darin Adler.
* dfg/DFGAbstractInterpreter.h:
* dfg/DFGAbstractValue.h:
* dfg/DFGBlockInsertionSet.h:
* dfg/DFGCommonData.h:
* dfg/DFGDominators.h:
* dfg/DFGGraph.h:
* dfg/DFGInPlaceAbstractState.h:
* dfg/DFGPredictionPropagationPhase.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGAbstractInterpreterh">trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGAbstractValueh">trunk/Source/JavaScriptCore/dfg/DFGAbstractValue.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGBlockInsertionSeth">trunk/Source/JavaScriptCore/dfg/DFGBlockInsertionSet.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGCommonDatah">trunk/Source/JavaScriptCore/dfg/DFGCommonData.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGDominatorsh">trunk/Source/JavaScriptCore/dfg/DFGDominators.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGGraphh">trunk/Source/JavaScriptCore/dfg/DFGGraph.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGInPlaceAbstractStateh">trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGPredictionPropagationPhaseh">trunk/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (169039 => 169040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-05-19 09:00:56 UTC (rev 169040)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-05-19 Tanay C <tanay.c@samsung.com>
+
+ Removing some check-webkit-style warnings from ./dfg
+ https://bugs.webkit.org/show_bug.cgi?id=132854
+
+ Reviewed by Darin Adler.
+
+ * dfg/DFGAbstractInterpreter.h:
+ * dfg/DFGAbstractValue.h:
+ * dfg/DFGBlockInsertionSet.h:
+ * dfg/DFGCommonData.h:
+ * dfg/DFGDominators.h:
+ * dfg/DFGGraph.h:
+ * dfg/DFGInPlaceAbstractState.h:
+ * dfg/DFGPredictionPropagationPhase.h:
+
</ins><span class="cx"> 2014-05-18 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, remove bogus comment. We already made the FTL use our calling convention.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGAbstractInterpreterh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h (169039 => 169040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h 2014-05-19 09:00:56 UTC (rev 169040)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx"> template<typename AbstractStateType>
</span><span class="cx"> class AbstractInterpreter {
</span><span class="cx"> public:
</span><del>- AbstractInterpreter(Graph&, AbstractStateType& state);
</del><ins>+ AbstractInterpreter(Graph&, AbstractStateType&);
</ins><span class="cx"> ~AbstractInterpreter();
</span><span class="cx">
</span><span class="cx"> AbstractValue& forNode(Node* node)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGAbstractValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGAbstractValue.h (169039 => 169040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGAbstractValue.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/JavaScriptCore/dfg/DFGAbstractValue.h 2014-05-19 09:00:56 UTC (rev 169040)
</span><span class="lines">@@ -200,11 +200,11 @@
</span><span class="cx">
</span><span class="cx"> FiltrationResult filter(Graph&, const StructureSet&);
</span><span class="cx">
</span><del>- FiltrationResult filterArrayModes(ArrayModes arrayModes);
</del><ins>+ FiltrationResult filterArrayModes(ArrayModes);
</ins><span class="cx">
</span><del>- FiltrationResult filter(SpeculatedType type);
</del><ins>+ FiltrationResult filter(SpeculatedType);
</ins><span class="cx">
</span><del>- FiltrationResult filterByValue(JSValue value);
</del><ins>+ FiltrationResult filterByValue(JSValue);
</ins><span class="cx">
</span><span class="cx"> bool validate(JSValue value) const
</span><span class="cx"> {
</span><span class="lines">@@ -397,7 +397,7 @@
</span><span class="cx"> checkConsistency();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- void setFuturePossibleStructure(Graph&, Structure* structure);
</del><ins>+ void setFuturePossibleStructure(Graph&, Structure*);
</ins><span class="cx">
</span><span class="cx"> void filterValueByType();
</span><span class="cx"> void filterArrayModesByType();
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGBlockInsertionSeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGBlockInsertionSet.h (169039 => 169040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGBlockInsertionSet.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/JavaScriptCore/dfg/DFGBlockInsertionSet.h 2014-05-19 09:00:56 UTC (rev 169040)
</span><span class="lines">@@ -38,11 +38,11 @@
</span><span class="cx">
</span><span class="cx"> class BlockInsertionSet {
</span><span class="cx"> public:
</span><del>- BlockInsertionSet(Graph& graph);
</del><ins>+ BlockInsertionSet(Graph&);
</ins><span class="cx"> ~BlockInsertionSet();
</span><span class="cx">
</span><del>- void insert(const BlockInsertion& insertion);
- void insert(size_t index, PassRefPtr<BasicBlock> block);
</del><ins>+ void insert(const BlockInsertion&);
+ void insert(size_t index, PassRefPtr<BasicBlock>);
</ins><span class="cx"> BasicBlock* insert(size_t index, float executionCount);
</span><span class="cx"> BasicBlock* insertBefore(BasicBlock* before, float executionCount);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGCommonDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGCommonData.h (169039 => 169040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGCommonData.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/JavaScriptCore/dfg/DFGCommonData.h 2014-05-19 09:00:56 UTC (rev 169040)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> { }
</span><span class="cx">
</span><span class="cx"> void notifyCompilingStructureTransition(Plan&, CodeBlock*, Node*);
</span><del>- unsigned addCodeOrigin(CodeOrigin codeOrigin);
</del><ins>+ unsigned addCodeOrigin(CodeOrigin);
</ins><span class="cx">
</span><span class="cx"> void shrinkToFit();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGDominatorsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGDominators.h (169039 => 169040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGDominators.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/JavaScriptCore/dfg/DFGDominators.h 2014-05-19 09:00:56 UTC (rev 169040)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> Dominators();
</span><span class="cx"> ~Dominators();
</span><span class="cx">
</span><del>- void compute(Graph& graph);
</del><ins>+ void compute(Graph&);
</ins><span class="cx">
</span><span class="cx"> bool dominates(BlockIndex from, BlockIndex to) const
</span><span class="cx"> {
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> return dominates(from->index, to->index);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- void dump(Graph& graph, PrintStream&) const;
</del><ins>+ void dump(Graph&, PrintStream&) const;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> bool pruneDominators(Graph&, BlockIndex);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGGraphh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGGraph.h (169039 => 169040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGGraph.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/JavaScriptCore/dfg/DFGGraph.h 2014-05-19 09:00:56 UTC (rev 169040)
</span><span class="lines">@@ -180,7 +180,7 @@
</span><span class="cx"> // CodeBlock is optional, but may allow additional information to be dumped (e.g. Identifier names).
</span><span class="cx"> void dump(PrintStream& = WTF::dataFile(), DumpContext* = 0);
</span><span class="cx"> enum PhiNodeDumpMode { DumpLivePhisOnly, DumpAllPhis };
</span><del>- void dumpBlockHeader(PrintStream&, const char* prefix, BasicBlock*, PhiNodeDumpMode, DumpContext* context);
</del><ins>+ void dumpBlockHeader(PrintStream&, const char* prefix, BasicBlock*, PhiNodeDumpMode, DumpContext*);
</ins><span class="cx"> void dump(PrintStream&, Edge);
</span><span class="cx"> void dump(PrintStream&, const char* prefix, Node*, DumpContext* = 0);
</span><span class="cx"> static int amountOfNodeWhiteSpace(Node*);
</span><span class="lines">@@ -188,7 +188,7 @@
</span><span class="cx">
</span><span class="cx"> // Dump the code origin of the given node as a diff from the code origin of the
</span><span class="cx"> // preceding node. Returns true if anything was printed.
</span><del>- bool dumpCodeOrigin(PrintStream&, const char* prefix, Node* previousNode, Node* currentNode, DumpContext* context);
</del><ins>+ bool dumpCodeOrigin(PrintStream&, const char* prefix, Node* previousNode, Node* currentNode, DumpContext*);
</ins><span class="cx">
</span><span class="cx"> SpeculatedType getJSConstantSpeculation(Node* node)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGInPlaceAbstractStateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h (169039 => 169040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h 2014-05-19 09:00:56 UTC (rev 169040)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx">
</span><span class="cx"> class InPlaceAbstractState {
</span><span class="cx"> public:
</span><del>- InPlaceAbstractState(Graph& graph);
</del><ins>+ InPlaceAbstractState(Graph&);
</ins><span class="cx">
</span><span class="cx"> ~InPlaceAbstractState();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGPredictionPropagationPhaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.h (169039 => 169040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.h 2014-05-19 08:44:52 UTC (rev 169039)
+++ trunk/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.h 2014-05-19 09:00:56 UTC (rev 169040)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> bool performPredictionPropagation(Graph&);
</span><span class="cx">
</span><span class="cx"> // Helper used for FixupPhase for computing the predicted type of a ToPrimitive.
</span><del>-SpeculatedType resultOfToPrimitive(SpeculatedType type);
</del><ins>+SpeculatedType resultOfToPrimitive(SpeculatedType);
</ins><span class="cx">
</span><span class="cx"> } } // namespace JSC::DFG::Phase
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>