<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168972] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168972">168972</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-05-16 11:47:07 -0700 (Fri, 16 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: Push named flows in region to device pixel when painting.
https://bugs.webkit.org/show_bug.cgi?id=132986
Reviewed by Simon Fraser.
Remove integral rounding when named flow sets the painting offset on the graphics context.
Use device pixel snapping instead to ensure that we can paint on odd device pixel positions on retina displays.
Source/WebCore:
Test: fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
LayoutTests:
* fast/regions/hidpi-region-with-auto-margin-on-subpixel-position-expected.html: Added.
* fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastregionshidpiregionwithautomarginonsubpixelpositionexpectedhtml">trunk/LayoutTests/fast/regions/hidpi-region-with-auto-margin-on-subpixel-position-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionshidpiregionwithautomarginonsubpixelpositionhtml">trunk/LayoutTests/fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (168971 => 168972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-16 18:26:24 UTC (rev 168971)
+++ trunk/LayoutTests/ChangeLog 2014-05-16 18:47:07 UTC (rev 168972)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-05-16 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Push named flows in region to device pixel when painting.
+ https://bugs.webkit.org/show_bug.cgi?id=132986
+
+ Reviewed by Simon Fraser.
+
+ Remove integral rounding when named flow sets the painting offset on the graphics context.
+ Use device pixel snapping instead to ensure that we can paint on odd device pixel positions on retina displays.
+
+ * fast/regions/hidpi-region-with-auto-margin-on-subpixel-position-expected.html: Added.
+ * fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html: Added.
+
</ins><span class="cx"> 2014-05-16 Kiran <kiran.guduru@samsung.com>
</span><span class="cx">
</span><span class="cx"> RTCDtmfSender default values need to be updated.
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionshidpiregionwithautomarginonsubpixelpositionexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/hidpi-region-with-auto-margin-on-subpixel-position-expected.html (0 => 168972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/hidpi-region-with-auto-margin-on-subpixel-position-expected.html (rev 0)
+++ trunk/LayoutTests/fast/regions/hidpi-region-with-auto-margin-on-subpixel-position-expected.html 2014-05-16 18:47:07 UTC (rev 168972)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that named flows can be painted on subpixel positions.</title>
+<style>
+ .inner {
+ border: 1px solid blue;
+ }
+ .content {
+ margin: auto;
+ width:97%;
+ }
+ .outer {
+ width: 200px;
+ }
+</style>
+<body>
+ <div class="outer">
+ <div class="inner">
+ <div class="content">This text should to painted on the same position.</div>
+ </div>
+ </div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionshidpiregionwithautomarginonsubpixelpositionhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html (0 => 168972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html (rev 0)
+++ trunk/LayoutTests/fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html 2014-05-16 18:47:07 UTC (rev 168972)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that named flows can be painted on subpixel positions.</title>
+<style>
+ #outer {
+ border: 1px solid blue;
+ -webkit-flow-into: flow1;
+ }
+
+ #inner {
+ margin: auto;
+ width: 97%;
+ }
+
+ #region1 {
+ width: 200px;
+ -webkit-flow-from: flow1;
+ }
+</style>
+</head>
+<body>
+ <div id="outer">
+ <div id="inner">This text should to painted on the same position.</div>
+ </div>
+ <div id="region1"></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (168971 => 168972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-16 18:26:24 UTC (rev 168971)
+++ trunk/Source/WebCore/ChangeLog 2014-05-16 18:47:07 UTC (rev 168972)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-05-16 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Push named flows in region to device pixel when painting.
+ https://bugs.webkit.org/show_bug.cgi?id=132986
+
+ Reviewed by Simon Fraser.
+
+ Remove integral rounding when named flow sets the painting offset on the graphics context.
+ Use device pixel snapping instead to ensure that we can paint on odd device pixel positions on retina displays.
+
+ Test: fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::calculateClipRects):
+
</ins><span class="cx"> 2014-05-16 Radu Stavila <stavila@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSS Regions] Add ASSERT to make sure using the flowThread cache does not return incorrect results
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (168971 => 168972)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-05-16 18:26:24 UTC (rev 168971)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-05-16 18:47:07 UTC (rev 168972)
</span><span class="lines">@@ -6682,7 +6682,7 @@
</span><span class="cx"> LayoutRect regionContentBox = toRenderBox(region->layerOwner()).contentBoxRect();
</span><span class="cx"> LayoutSize moveOffset = region->flowThreadPortionLocation() - (paintOffset + regionContentBox.location()) + region->fragmentContainer().scrolledContentOffset();
</span><span class="cx">
</span><del>- IntPoint adjustedPaintOffset = roundedIntPoint(-moveOffset);
</del><ins>+ FloatPoint adjustedPaintOffset = roundedForPainting(LayoutPoint(-moveOffset.width(), -moveOffset.height()), renderer().document().deviceScaleFactor());
</ins><span class="cx"> paintDirtyRect.move(moveOffset);
</span><span class="cx">
</span><span class="cx"> context->save();
</span></span></pre>
</div>
</div>
</body>
</html>