<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168973] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168973">168973</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-16 12:01:57 -0700 (Fri, 16 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Gtk] media/media-blocked-by-beforeload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=89811
Patch by Piotr Grad <p.grad@samsung.com> on 2014-05-16
Reviewed by Eric Carlson.
Problem is that we cannot predict when 'error' event would be called,
because is called async on 'source' element. Solution is to not log
'loadedmetadata' and 'loadstart' events.
* media/media-blocked-by-beforeload-expected.txt:
* media/media-blocked-by-beforeload.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediamediablockedbybeforeloadexpectedtxt">trunk/LayoutTests/media/media-blocked-by-beforeload-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediamediablockedbybeforeloadhtml">trunk/LayoutTests/media/media-blocked-by-beforeload.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (168972 => 168973)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-16 18:47:07 UTC (rev 168972)
+++ trunk/LayoutTests/ChangeLog 2014-05-16 19:01:57 UTC (rev 168973)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-05-16 Piotr Grad <p.grad@samsung.com>
+
+ [Gtk] media/media-blocked-by-beforeload.html is flaky.
+ https://bugs.webkit.org/show_bug.cgi?id=89811
+
+ Reviewed by Eric Carlson.
+
+ Problem is that we cannot predict when 'error' event would be called,
+ because is called async on 'source' element. Solution is to not log
+ 'loadedmetadata' and 'loadstart' events.
+
+ * media/media-blocked-by-beforeload-expected.txt:
+ * media/media-blocked-by-beforeload.html:
+
</ins><span class="cx"> 2014-05-16 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Subpixel rendering: Push named flows in region to device pixel when painting.
</span></span></pre></div>
<a id="trunkLayoutTestsmediamediablockedbybeforeloadexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/media-blocked-by-beforeload-expected.txt (168972 => 168973)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/media-blocked-by-beforeload-expected.txt 2014-05-16 18:47:07 UTC (rev 168972)
+++ trunk/LayoutTests/media/media-blocked-by-beforeload-expected.txt 2014-05-16 19:01:57 UTC (rev 168973)
</span><span class="lines">@@ -11,8 +11,6 @@
</span><span class="cx"> EXPECTED (event.target.tagName == 'VIDEO') OK
</span><span class="cx"> blocking load of 'src'
</span><span class="cx">
</span><del>-EVENT('loadstart')
-
</del><span class="cx"> EVENT('error')
</span><span class="cx"> EXPECTED (event.target.tagName == 'VIDEO') OK
</span><span class="cx"> EXPECTED (video.error != 'null') OK
</span><span class="lines">@@ -29,13 +27,8 @@
</span><span class="cx"> EXPECTED (event.target.tagName == 'VIDEO') OK
</span><span class="cx"> allowing load of second <source> element
</span><span class="cx">
</span><del>-EVENT('loadstart')
-
</del><span class="cx"> EVENT('error')
</span><span class="cx"> EXPECTED (event.target.tagName == 'SOURCE') OK
</span><span class="cx"> EXPECTED (video.error == 'null') OK
</span><del>-
-EVENT('loadedmetadata')
-
</del><span class="cx"> END OF TEST
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsmediamediablockedbybeforeloadhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/media-blocked-by-beforeload.html (168972 => 168973)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/media-blocked-by-beforeload.html 2014-05-16 18:47:07 UTC (rev 168972)
+++ trunk/LayoutTests/media/media-blocked-by-beforeload.html 2014-05-16 19:01:57 UTC (rev 168973)
</span><span class="lines">@@ -21,6 +21,7 @@
</span><span class="cx"> var test;
</span><span class="cx"> var loadedmetadataFired = false;
</span><span class="cx"> var loadedFired = false;
</span><ins>+ var lastErrorFired = false;
</ins><span class="cx">
</span><span class="cx"> function logEvent(evt)
</span><span class="cx"> {
</span><span class="lines">@@ -29,8 +30,6 @@
</span><span class="cx">
</span><span class="cx"> function loadedmetadata(evt)
</span><span class="cx"> {
</span><del>- logEvent(evt);
- consoleWrite("");
</del><span class="cx"> loadedmetadataFired = true;
</span><span class="cx"> checkEndTest();
</span><span class="cx"> }
</span><span class="lines">@@ -76,6 +75,8 @@
</span><span class="cx"> // not be in an error state.
</span><span class="cx"> testExpected("event.target.tagName", "SOURCE");
</span><span class="cx"> testExpected("video.error", null);
</span><ins>+ lastErrorFired = true;
+ checkEndTest();
</ins><span class="cx"> break;
</span><span class="cx"> case 3:
</span><span class="cx"> failTest("Unexpected 'error' event fired!");
</span><span class="lines">@@ -113,13 +114,12 @@
</span><span class="cx">
</span><span class="cx"> function checkEndTest()
</span><span class="cx"> {
</span><del>- if (loadedmetadataFired && loadedFired)
</del><ins>+ if (loadedmetadataFired && loadedFired && lastErrorFired)
</ins><span class="cx"> endTest();
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> findMediaElement();
</span><span class="cx">
</span><del>- video.addEventListener('loadstart', logEvent, true);
</del><span class="cx"> video.addEventListener('loadedmetadata', loadedmetadata, true);
</span><span class="cx"> video.addEventListener('beforeload', beforeload, true);
</span><span class="cx"> video.addEventListener('error', error, true);
</span></span></pre>
</div>
</div>
</body>
</html>