<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168679] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168679">168679</a></dd>
<dt>Author</dt> <dd>berto@igalia.com</dd>
<dt>Date</dt> <dd>2014-05-13 06:56:15 -0700 (Tue, 13 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[MediaStream] MediaStream.addTrack Should not check for active state.
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=132558
Patch by Kiran <kiran.guduru@samsung.com> on 2014-05-13
Reviewed by Eric Carlson.
MediaStream.addTrack method is checking for active state of a
MediaStream, but it should not check for active state while adding a Track.
Test: fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html
* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrack):
LayoutTests:
Nhttps://bugs.webkit.org/show_bug.cgi?id=132558.
Patch by Kiran <kiran.guduru@samsung.com> on 2014-05-13
Reviewed by Eric Carlson.
MediaStream.addTrack method is checking for active state of a
MediaStream, but it should not check for active state while adding a Track
Removed check not to add tracks to ended stream:relative which forced tests to avoid this bug.
* fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
* fast/mediastream/MediaStream-add-remove-tracks.html:
New tests:
* fast/mediastream/MediaStream-add-tracks-to-inactive-stream-expected.txt: Added.
* fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamMediaStreamaddremovetracksexpectedtxt">trunk/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamMediaStreamaddremovetrackshtml">trunk/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamcpp">trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastmediastreamMediaStreamaddtrackstoinactivestreamexpectedtxt">trunk/LayoutTests/fast/mediastream/MediaStream-add-tracks-to-inactive-stream-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamMediaStreamaddtrackstoinactivestreamhtml">trunk/LayoutTests/fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (168678 => 168679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-13 13:11:25 UTC (rev 168678)
+++ trunk/LayoutTests/ChangeLog 2014-05-13 13:56:15 UTC (rev 168679)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-05-13 Kiran <kiran.guduru@samsung.com>
+
+ [MediaStream] MediaStream.addTrack Should not check for active state.
+ Nhttps://bugs.webkit.org/show_bug.cgi?id=132558.
+
+ Reviewed by Eric Carlson.
+
+ MediaStream.addTrack method is checking for active state of a
+ MediaStream, but it should not check for active state while adding a Track
+
+ Removed check not to add tracks to ended stream:relative which forced tests to avoid this bug.
+ * fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
+ * fast/mediastream/MediaStream-add-remove-tracks.html:
+
+ New tests:
+ * fast/mediastream/MediaStream-add-tracks-to-inactive-stream-expected.txt: Added.
+ * fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html: Added.
+
</ins><span class="cx"> 2014-05-13 Lorenzo Tilve <ltilve@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Unreviewed GTK gardening
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamMediaStreamaddremovetracksexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks-expected.txt (168678 => 168679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks-expected.txt 2014-05-13 13:11:25 UTC (rev 168678)
+++ trunk/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks-expected.txt 2014-05-13 13:56:15 UTC (rev 168679)
</span><span class="lines">@@ -48,8 +48,7 @@
</span><span class="cx"> PASS stream2.getAudioTracks().length is 0
</span><span class="cx"> PASS stream2.getVideoTracks().length is 0
</span><span class="cx">
</span><del>-*** it should be impossible to add a track after the stream has ended
-PASS stream2.addTrack(audioTrack) threw exception Error: InvalidStateError: DOM Exception 11.
</del><ins>+*** it should be impossible to remove a track after the stream has ended
</ins><span class="cx"> PASS stream2.removeTrack(audioTrack) threw exception Error: InvalidStateError: DOM Exception 11.
</span><span class="cx"> Stream2 is inactive.
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamMediaStreamaddremovetrackshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks.html (168678 => 168679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks.html 2014-05-13 13:11:25 UTC (rev 168678)
+++ trunk/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks.html 2014-05-13 13:56:15 UTC (rev 168679)
</span><span class="lines">@@ -130,8 +130,7 @@
</span><span class="cx"> shouldBe('stream2.getAudioTracks().length', '0');
</span><span class="cx"> shouldBe('stream2.getVideoTracks().length', '0');
</span><span class="cx">
</span><del>- debug("<br>*** it should be impossible to add a track after the stream has ended");
- shouldThrow('stream2.addTrack(audioTrack)', '"Error: InvalidStateError: DOM Exception 11"');
</del><ins>+ debug("<br>*** it should be impossible to remove a track after the stream has ended");
</ins><span class="cx"> shouldThrow('stream2.removeTrack(audioTrack)', '"Error: InvalidStateError: DOM Exception 11"');
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamMediaStreamaddtrackstoinactivestreamexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/mediastream/MediaStream-add-tracks-to-inactive-stream-expected.txt (0 => 168679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/MediaStream-add-tracks-to-inactive-stream-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/mediastream/MediaStream-add-tracks-to-inactive-stream-expected.txt 2014-05-13 13:56:15 UTC (rev 168679)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+Test adding tracks to inactive MediaStream.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+MediaStream without tracks created.
+PASS stream2.getAudioTracks().length is 0
+Adding tracks to inactive stream
+PASS stream2.getAudioTracks().length is 1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamMediaStreamaddtrackstoinactivestreamhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html (0 => 168679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html (rev 0)
+++ trunk/LayoutTests/fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html 2014-05-13 13:56:15 UTC (rev 168679)
</span><span class="lines">@@ -0,0 +1,69 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+ <head>
+ <script src="../../resources/js-test-pre.js"></script>
+ <script>
+
+
+ var stream1;
+ var audioTrack;
+
+ function error()
+ {
+ testFailed('Stream generation failed.');
+ finishJSTest();
+ }
+
+ function getUserMedia(dictionary, callback)
+ {
+ try {
+ navigator.webkitGetUserMedia(dictionary, callback, error);
+ } catch (e) {
+ testFailed('webkitGetUserMedia threw exception :' + e);
+ finishJSTest();
+ }
+ }
+
+ function tryAddTrack(stream, track)
+ {
+ try {
+ stream.addTrack(track);
+ } catch (exception) {
+ testFailed("addTrack threw an exception.");
+ finishJSTest();
+ }
+ }
+
+ function createStreamAndAddTracks()
+ {
+ stream2 = new webkitMediaStream();
+ debug("MediaStream without tracks created.");
+ shouldBe('stream2.getAudioTracks().length', '0');
+ audioTrack = stream1.getAudioTracks()[0];
+ debug("Adding tracks to inactive stream");
+ tryAddTrack(stream2, audioTrack);
+ shouldBe('stream2.getAudioTracks().length', '1');
+ finishJSTest();
+ }
+
+ function gotStream1(s)
+ {
+ stream1 = s;
+ createStreamAndAddTracks();
+ }
+
+ function startMedia()
+ {
+ description("Test adding tracks to inactive MediaStream.");
+ getUserMedia({audio:true, video:true}, gotStream1);
+ }
+ window.jsTestIsAsync = true;
+ window.successfullyParsed = true;
+ </script>
+ <script src="../../resources/js-test-post.js"></script>
+ </head>
+ <body onload="startMedia()">
+ <p id="description"></p>
+ <div id="console"></div>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (168678 => 168679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-13 13:11:25 UTC (rev 168678)
+++ trunk/Source/WebCore/ChangeLog 2014-05-13 13:56:15 UTC (rev 168679)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-05-13 Kiran <kiran.guduru@samsung.com>
+
+ [MediaStream] MediaStream.addTrack Should not check for active state.
+ https://bugs.webkit.org/show_bug.cgi?id=132558
+
+ Reviewed by Eric Carlson.
+
+ MediaStream.addTrack method is checking for active state of a
+ MediaStream, but it should not check for active state while adding a Track.
+
+ Test: fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html
+
+ * Modules/mediastream/MediaStream.cpp:
+ (WebCore::MediaStream::addTrack):
+
</ins><span class="cx"> 2014-05-12 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> WebKit2 on iOS needs to capture the main thread's floating point environment.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp (168678 => 168679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp 2014-05-13 13:11:25 UTC (rev 168678)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp 2014-05-13 13:56:15 UTC (rev 168679)
</span><span class="lines">@@ -143,11 +143,6 @@
</span><span class="cx">
</span><span class="cx"> void MediaStream::addTrack(PassRefPtr<MediaStreamTrack> prpTrack, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- if (!active()) {
- ec = INVALID_STATE_ERR;
- return;
- }
-
</del><span class="cx"> if (!prpTrack) {
</span><span class="cx"> ec = TYPE_MISMATCH_ERR;
</span><span class="cx"> return;
</span></span></pre>
</div>
</div>
</body>
</html>