<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168465] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168465">168465</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-08 01:16:31 -0700 (Thu, 08 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Blending] Changing isolation CSS property should not trigger repaint in RenderStyle::changeRequiresLayerRepaint
https://bugs.webkit.org/show_bug.cgi?id=131436
Patch by Ion Rosca <rosca@adobe.com> on 2014-05-08
Reviewed by Dirk Schulze.
Source/WebCore:
The isolation:isolate property will create a stacking context. This is done in
StyleResolver::adjustRenderStyle where z-index is forced to 0.
If the element is already a stacking context for any other reason,
changing the isolation flag should not have any effect.
Tests: css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html
css3/blending/repaint/blend-mode-turn-off-isolation.html
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayerRepaint):
do not request repaint if isolation has changed.
LayoutTests:
* css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt: Added.
* css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt: Added.
* css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html: Added.
* css3/blending/repaint/blend-mode-turn-off-isolation.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStylecpp">trunk/Source/WebCore/rendering/style/RenderStyle.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscss3blendingrepaintblendmodeturnoffisolationexpectedtxt">trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt</a></li>
<li><a href="#trunkLayoutTestscss3blendingrepaintblendmodeturnoffisolationnoeffectexpectedtxt">trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt</a></li>
<li><a href="#trunkLayoutTestscss3blendingrepaintblendmodeturnoffisolationnoeffecthtml">trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html</a></li>
<li><a href="#trunkLayoutTestscss3blendingrepaintblendmodeturnoffisolationhtml">trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (168464 => 168465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-08 08:05:58 UTC (rev 168464)
+++ trunk/LayoutTests/ChangeLog 2014-05-08 08:16:31 UTC (rev 168465)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-05-08 Ion Rosca <rosca@adobe.com>
+
+ [CSS Blending] Changing isolation CSS property should not trigger repaint in RenderStyle::changeRequiresLayerRepaint
+ https://bugs.webkit.org/show_bug.cgi?id=131436
+
+ Reviewed by Dirk Schulze.
+
+ * css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt: Added.
+ * css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt: Added.
+ * css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html: Added.
+ * css3/blending/repaint/blend-mode-turn-off-isolation.html: Added.
+
</ins><span class="cx"> 2014-05-08 Manuel Rego Casasnovas <rego@igalia.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r167652): SelectionState is not set properly for non leaf objects in pages with regions
</span></span></pre></div>
<a id="trunkLayoutTestscss3blendingrepaintblendmodeturnoffisolationexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt (0 => 168465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt 2014-05-08 08:16:31 UTC (rev 168465)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+This test checks that removing isolation from an element not being stacking context for other reasons will repaint the blending div.
+
+(repaint rects
+ (rect 58 68 100 100)
+)
+
</ins></span></pre></div>
<a id="trunkLayoutTestscss3blendingrepaintblendmodeturnoffisolationnoeffectexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt (0 => 168465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt 2014-05-08 08:16:31 UTC (rev 168465)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+This test checks that removing isolation from an element being stacking context for other reasons will not trigger any repaint.
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestscss3blendingrepaintblendmodeturnoffisolationnoeffecthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html (0 => 168465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html (rev 0)
+++ trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html 2014-05-08 08:16:31 UTC (rev 168465)
</span><span class="lines">@@ -0,0 +1,43 @@
</span><ins>+<!DOCTYPE HTML>
+<html>
+ <head>
+ <style>
+ div {
+ width: 100px;
+ height: 100px;
+ }
+
+ .stacking-context {
+ position: relative;
+ z-index: 1;
+ }
+ .isolating {
+ -webkit-isolation: isolate;
+ isolation: isolate;
+ }
+ .blending {
+ -webkit-mix-blend-mode: difference;
+ mix-blend-mode: difference;
+ }
+
+ </style>
+ <script src="../../../fast/repaint/resources/text-based-repaint.js" type="text/javascript"></script>
+ </head>
+ <body>
+ <p>This test checks that removing isolation from an element being stacking context for other reasons will not trigger any repaint.</p>
+ <div id="target" class="stacking-context isolating" style="background-color: #00ff00;">
+ <div class="blending" style="background-color: #ff00ff; margin-left: 50px;"></div>
+ </div>
+ <script type="text/javascript">
+ function repaintTest() {
+ var target = document.getElementById("target");
+ target.className = "stacking-context";
+ }
+ window.onload = function() {
+ if (window.testRunner)
+ window.testRunner.dumpAsText(true);
+ runRepaintTest();
+ }
+ </script>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestscss3blendingrepaintblendmodeturnoffisolationhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation.html (0 => 168465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation.html (rev 0)
+++ trunk/LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation.html 2014-05-08 08:16:31 UTC (rev 168465)
</span><span class="lines">@@ -0,0 +1,40 @@
</span><ins>+<!DOCTYPE HTML>
+<html>
+ <head>
+ <style>
+ div {
+ width: 100px;
+ height: 100px;
+ }
+
+ .isolating {
+ -webkit-isolation: isolate;
+ isolation: isolate;
+ }
+
+ .blending {
+ -webkit-mix-blend-mode: difference;
+ mix-blend-mode: difference;
+ }
+
+ </style>
+ <script src="../../../fast/repaint/resources/text-based-repaint.js" type="text/javascript"></script>
+ </head>
+ <body>
+ <p>This test checks that removing isolation from an element not being stacking context for other reasons will repaint the blending div.</p>
+ <div id="target" class="isolating" style="background-color: #00ff00;">
+ <div class="blending" style="background-color: #ff00ff; margin-left: 50px;"></div>
+ </div>
+ <script type="text/javascript">
+ function repaintTest() {
+ var target = document.getElementById("target");
+ target.className = "";
+ }
+ window.onload = function() {
+ if (window.testRunner)
+ window.testRunner.dumpAsText(true);
+ runRepaintTest();
+ }
+ </script>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (168464 => 168465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-08 08:05:58 UTC (rev 168464)
+++ trunk/Source/WebCore/ChangeLog 2014-05-08 08:16:31 UTC (rev 168465)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-05-08 Ion Rosca <rosca@adobe.com>
+
+ [CSS Blending] Changing isolation CSS property should not trigger repaint in RenderStyle::changeRequiresLayerRepaint
+ https://bugs.webkit.org/show_bug.cgi?id=131436
+
+ Reviewed by Dirk Schulze.
+
+ The isolation:isolate property will create a stacking context. This is done in
+ StyleResolver::adjustRenderStyle where z-index is forced to 0.
+ If the element is already a stacking context for any other reason,
+ changing the isolation flag should not have any effect.
+
+ Tests: css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html
+ css3/blending/repaint/blend-mode-turn-off-isolation.html
+
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::changeRequiresLayerRepaint):
+ do not request repaint if isolation has changed.
+
</ins><span class="cx"> 2014-05-08 Manuel Rego Casasnovas <rego@igalia.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r167652): SelectionState is not set properly for non leaf objects in pages with regions
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (168464 => 168465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2014-05-08 08:05:58 UTC (rev 168464)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2014-05-08 08:16:31 UTC (rev 168465)
</span><span class="lines">@@ -663,9 +663,6 @@
</span><span class="cx"> #if ENABLE(CSS_COMPOSITING)
</span><span class="cx"> if (rareNonInheritedData->m_effectiveBlendMode != other->rareNonInheritedData->m_effectiveBlendMode)
</span><span class="cx"> return true;
</span><del>-
- if (rareNonInheritedData->m_isolation != other->rareNonInheritedData->m_isolation)
- return true;
</del><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> if (rareNonInheritedData->opacity != other->rareNonInheritedData->opacity) {
</span></span></pre>
</div>
</div>
</body>
</html>