<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168425] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168425">168425</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-07 07:07:02 -0700 (Wed, 07 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>DocumentLoader::dataReceived assertion failed
https://bugs.webkit.org/show_bug.cgi?id=132017
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-05-07
Reviewed by Brent Fulgham.
We need to call didReceiveResponse client method before the didReceiveData client method, otherwise we get a lot of asserts.
This patch also fixes frequent crashes in downloadTimerCallback method on page loading.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::calculateWebTimingInformations): Initialize local variables.
(WebCore::headerCallback): Call didReceiveResponse client method here instead of in downloadTimerCallback.
(WebCore::ResourceHandleManager::downloadTimerCallback): Remove call to didReceiveResponse method.
(WebCore::ResourceHandleManager::dispatchSynchronousJob): Removed empty line.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkcurlResourceHandleManagercpp">trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (168424 => 168425)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-07 13:11:00 UTC (rev 168424)
+++ trunk/Source/WebCore/ChangeLog 2014-05-07 14:07:02 UTC (rev 168425)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-05-07 peavo@outlook.com <peavo@outlook.com>
+
+ DocumentLoader::dataReceived assertion failed
+ https://bugs.webkit.org/show_bug.cgi?id=132017
+
+ Reviewed by Brent Fulgham.
+
+ We need to call didReceiveResponse client method before the didReceiveData client method, otherwise we get a lot of asserts.
+ This patch also fixes frequent crashes in downloadTimerCallback method on page loading.
+
+ * platform/network/curl/ResourceHandleManager.cpp:
+ (WebCore::calculateWebTimingInformations): Initialize local variables.
+ (WebCore::headerCallback): Call didReceiveResponse client method here instead of in downloadTimerCallback.
+ (WebCore::ResourceHandleManager::downloadTimerCallback): Remove call to didReceiveResponse method.
+ (WebCore::ResourceHandleManager::dispatchSynchronousJob): Removed empty line.
+
</ins><span class="cx"> 2014-05-06 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION: Animated GIF inside compositing layer never resumes animation when scrolled back into view
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkcurlResourceHandleManagercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp (168424 => 168425)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp 2014-05-07 13:11:00 UTC (rev 168424)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp 2014-05-07 14:07:02 UTC (rev 168425)
</span><span class="lines">@@ -158,11 +158,11 @@
</span><span class="cx">
</span><span class="cx"> static void calculateWebTimingInformations(ResourceHandleInternal* d)
</span><span class="cx"> {
</span><del>- double startTransfertTime;
- double preTransferTime;
- double dnslookupTime;
- double connectTime;
- double appConnectTime;
</del><ins>+ double startTransfertTime = 0;
+ double preTransferTime = 0;
+ double dnslookupTime = 0;
+ double connectTime = 0;
+ double appConnectTime = 0;
</ins><span class="cx">
</span><span class="cx"> curl_easy_getinfo(d->m_handle, CURLINFO_NAMELOOKUP_TIME, &dnslookupTime);
</span><span class="cx"> curl_easy_getinfo(d->m_handle, CURLINFO_CONNECT_TIME, &connectTime);
</span><span class="lines">@@ -531,9 +531,10 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (client)
</del><ins>+ if (client) {
+ client->didReceiveResponse(job, d->m_response);
</ins><span class="cx"> CurlCacheManager::getInstance().didReceiveResponse(job, d->m_response);
</span><del>-
</del><ins>+ }
</ins><span class="cx"> d->m_response.setResponseFired(true);
</span><span class="cx">
</span><span class="cx"> } else {
</span><span class="lines">@@ -668,7 +669,6 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> if (CURLE_OK == msg->data.result) {
</span><del>-
</del><span class="cx"> #if ENABLE(WEB_TIMING)
</span><span class="cx"> calculateWebTimingInformations(d);
</span><span class="cx"> #endif
</span><span class="lines">@@ -684,7 +684,6 @@
</span><span class="cx"> d->m_multipartHandle->contentEnded();
</span><span class="cx">
</span><span class="cx"> if (d->client()) {
</span><del>- d->client()->didReceiveResponse(job, d->m_response);
</del><span class="cx"> d->client()->didFinishLoading(job, 0);
</span><span class="cx"> CurlCacheManager::getInstance().didFinishLoading(job->firstRequest().url().string());
</span><span class="cx"> }
</span><span class="lines">@@ -919,7 +918,6 @@
</span><span class="cx"> handle->client()->didReceiveResponse(job, handle->m_response);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-
</del><span class="cx"> #if ENABLE(WEB_TIMING)
</span><span class="cx"> calculateWebTimingInformations(handle);
</span><span class="cx"> #endif
</span></span></pre>
</div>
</div>
</body>
</html>