<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168424] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168424">168424</a></dd>
<dt>Author</dt> <dd>antti@apple.com</dd>
<dt>Date</dt> <dd>2014-05-07 06:11:00 -0700 (Wed, 07 May 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION: Animated GIF inside compositing layer never resumes animation when scrolled back into view
https://bugs.webkit.org/show_bug.cgi?id=132608

Reviewed by Simon Fraser.


Source/WebCore: 
Test: fast/repaint/animation-after-layer-scroll.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
        
    Check if any animations need to be restarted after layer scroll.

LayoutTests: 
* fast/repaint/animation-after-layer-scroll-expected.txt: Added.
* fast/repaint/animation-after-layer-scroll.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastrepaintanimationafterlayerscrollexpectedtxt">trunk/LayoutTests/fast/repaint/animation-after-layer-scroll-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepaintanimationafterlayerscrollhtml">trunk/LayoutTests/fast/repaint/animation-after-layer-scroll.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (168423 => 168424)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-05-07 11:44:00 UTC (rev 168423)
+++ trunk/LayoutTests/ChangeLog        2014-05-07 13:11:00 UTC (rev 168424)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-05-06  Antti Koivisto  &lt;antti@apple.com&gt;
+
+        REGRESSION: Animated GIF inside compositing layer never resumes animation when scrolled back into view
+        https://bugs.webkit.org/show_bug.cgi?id=132608
+
+        Reviewed by Simon Fraser.
+
+        * fast/repaint/animation-after-layer-scroll-expected.txt: Added.
+        * fast/repaint/animation-after-layer-scroll.html: Added.
+
</ins><span class="cx"> 2014-05-07  Manuel Rego Casasnovas  &lt;rego@igalia.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [CSS Grid Layout] Remove runtime feature
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepaintanimationafterlayerscrollexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/animation-after-layer-scroll-expected.txt (0 => 168424)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/animation-after-layer-scroll-expected.txt                                (rev 0)
+++ trunk/LayoutTests/fast/repaint/animation-after-layer-scroll-expected.txt        2014-05-07 13:11:00 UTC (rev 168424)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+Test that animated gif on layer that is scrolled to view starts animating.
+
+On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.
+
+
+PASS layerTreeAsText.indexOf('repaint rect') &gt; -1 is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepaintanimationafterlayerscrollhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/animation-after-layer-scroll.html (0 => 168424)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/animation-after-layer-scroll.html                                (rev 0)
+++ trunk/LayoutTests/fast/repaint/animation-after-layer-scroll.html        2014-05-07 13:11:00 UTC (rev 168424)
</span><span class="lines">@@ -0,0 +1,51 @@
</span><ins>+&lt;html&gt;
+&lt;head&gt;
+&lt;script&gt;jsTestIsAsync = true;&lt;/script&gt;
+&lt;script src=&quot;../../resources/js-test-pre.js&quot;&gt;&lt;/script&gt;
+&lt;script&gt;
+    description(&quot;Test that animated gif on layer that is scrolled to view starts animating.&quot;);
+    function startTrackingRepaints()
+    {
+        window.internals.startTrackingRepaints();
+        document.getElementById('scroller').scrollTop = 800;
+        testRunner.display();
+
+        setTimeout(logRepaints, 200);
+    }
+
+    function logRepaints()
+    {
+        layerTreeAsText =  window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_REPAINT_RECTS);
+        window.internals.stopTrackingRepaints();
+
+        shouldBeTrue(&quot;layerTreeAsText.indexOf('repaint rect') &gt; -1&quot;);
+
+        finishJSTest();
+    }
+
+    function test()
+    {
+        testRunner.display();
+        setTimeout(startTrackingRepaints, 200);
+    }
+
+    function start() {
+        if (!window.testRunner || !window.internals)
+            return;
+
+        var img = new Image();
+        img.onload = test;
+        img.src = &quot;resources/animated.gif&quot;;
+    }
+&lt;/script&gt;
+&lt;/head&gt;
+&lt;body onload=&quot;start()&quot;&gt;
+&lt;div style=&quot;overflow:scroll; height:200px; width:200px; border: 2px solid blue&quot; id=scroller&gt;
+&lt;div style=&quot;-webkit-transform: translateZ(0);&quot;&gt;
+&lt;div style=&quot;height:800px&quot;&gt;&lt;/div&gt;
+&lt;img src=&quot;resources/animated.gif&quot; id=anim&gt;
+&lt;div style=&quot;height:800px&quot;&gt;&lt;/div&gt;
+&lt;/div&gt;
+&lt;/div&gt;
+&lt;script src=&quot;../../resources/js-test-post.js&quot;&gt;&lt;/script&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (168423 => 168424)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-05-07 11:44:00 UTC (rev 168423)
+++ trunk/Source/WebCore/ChangeLog        2014-05-07 13:11:00 UTC (rev 168424)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-05-06  Antti Koivisto  &lt;antti@apple.com&gt;
+
+        REGRESSION: Animated GIF inside compositing layer never resumes animation when scrolled back into view
+        https://bugs.webkit.org/show_bug.cgi?id=132608
+
+        Reviewed by Simon Fraser.
+
+        Test: fast/repaint/animation-after-layer-scroll.html
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::scrollTo):
+        
+            Check if any animations need to be restarted after layer scroll.
+
</ins><span class="cx"> 2014-05-07  Hyowon Kim  &lt;hw1008.kim@samsung.com&gt;
</span><span class="cx"> 
</span><span class="cx">         GraphicsLayer::client() should return a reference.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (168423 => 168424)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp        2014-05-07 11:44:00 UTC (rev 168423)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp        2014-05-07 13:11:00 UTC (rev 168424)
</span><span class="lines">@@ -2321,6 +2321,8 @@
</span><span class="cx">     InspectorInstrumentation::didScrollLayer(&amp;frame);
</span><span class="cx">     if (scrollsOverflow())
</span><span class="cx">         frame.loader().client().didChangeScrollOffset();
</span><ins>+
+    renderer().view().resumePausedImageAnimationsIfNeeded();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> static inline bool frameElementAndViewPermitScroll(HTMLFrameElementBase* frameElementBase, FrameView* frameView) 
</span></span></pre>
</div>
</div>

</body>
</html>