<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168426] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168426">168426</a></dd>
<dt>Author</dt> <dd>g.czajkowski@samsung.com</dd>
<dt>Date</dt> <dd>2014-05-07 07:54:56 -0700 (Wed, 07 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Share mac/editing/spelling/editing-multiple-words-with-markers.html with other platforms
https://bugs.webkit.org/show_bug.cgi?id=132649
Reviewed by Ryosuke Niwa.
This test does not verify autocorrection feature which is only implemented
by Mac. Other WebKit ports might be interested in running it due to
verification of spelling markers after merging two misspelled words.
Additionally, add the test case confirming spelling markers
before any selection change.
Due to bug 125689, this test starts using asynchronous spellchecking.
* editing/spelling/editing-multiple-words-with-markers-expected.txt:
Renamed from platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt
* editing/spelling/editing-multiple-words-with-markers.html:
Renamed from platform/mac/editing/spelling/editing-multiple-words-with-markers.html
* platform/gtk/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
Mark editing-multiple-words-with-markers.html as failing since those
platforms didn't turn on asynchronous spellchecking.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2TestExpectations">trunk/LayoutTests/platform/mac-wk2/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestseditingspellingeditingmultiplewordswithmarkersexpectedtxt">trunk/LayoutTests/editing/spelling/editing-multiple-words-with-markers-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingspellingeditingmultiplewordswithmarkershtml">trunk/LayoutTests/editing/spelling/editing-multiple-words-with-markers.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmaceditingspellingeditingmultiplewordswithmarkersexpectedtxt">trunk/LayoutTests/platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmaceditingspellingeditingmultiplewordswithmarkershtml">trunk/LayoutTests/platform/mac/editing/spelling/editing-multiple-words-with-markers.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (168425 => 168426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-07 14:07:02 UTC (rev 168425)
+++ trunk/LayoutTests/ChangeLog 2014-05-07 14:54:56 UTC (rev 168426)
</span><span class="lines">@@ -1,3 +1,30 @@
</span><ins>+2014-05-07 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ Share mac/editing/spelling/editing-multiple-words-with-markers.html with other platforms
+ https://bugs.webkit.org/show_bug.cgi?id=132649
+
+ Reviewed by Ryosuke Niwa.
+
+ This test does not verify autocorrection feature which is only implemented
+ by Mac. Other WebKit ports might be interested in running it due to
+ verification of spelling markers after merging two misspelled words.
+
+ Additionally, add the test case confirming spelling markers
+ before any selection change.
+
+ Due to bug 125689, this test starts using asynchronous spellchecking.
+
+ * editing/spelling/editing-multiple-words-with-markers-expected.txt:
+ Renamed from platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt
+ * editing/spelling/editing-multiple-words-with-markers.html:
+ Renamed from platform/mac/editing/spelling/editing-multiple-words-with-markers.html
+
+ * platform/gtk/TestExpectations:
+ * platform/mac-wk2/TestExpectations:
+ * platform/win/TestExpectations:
+ Mark editing-multiple-words-with-markers.html as failing since those
+ platforms didn't turn on asynchronous spellchecking.
+
</ins><span class="cx"> 2014-05-06 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION: Animated GIF inside compositing layer never resumes animation when scrolled back into view
</span></span></pre></div>
<a id="trunkLayoutTestseditingspellingeditingmultiplewordswithmarkersexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/editing/spelling/editing-multiple-words-with-markers-expected.txt (0 => 168426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/spelling/editing-multiple-words-with-markers-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/spelling/editing-multiple-words-with-markers-expected.txt 2014-05-07 14:54:56 UTC (rev 168426)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+The test verifies if the spelling markers disappear when the multiple misspelled words are concatenated by delete command. To test manually, type "it's a meagesga meagesga", then select and delete "esga meag". The test succeeds if the remaining text does not have any underline.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS internals.hasSpellingMarker(spellingPositions[0], spellingLengths[0]) became false
+PASS internals.hasSpellingMarker(spellingPositions[1], spellingLengths[1]) became true
+
+PASS internals.hasSpellingMarker(spellingPositions[0], spellingLengths[0]) became false
+PASS internals.hasSpellingMarker(spellingPositions[1], spellingLengths[1]) became false
+
+PASS internals.hasSpellingMarker(spellingPositions[0], spellingLengths[0]) became false
+PASS internals.hasSpellingMarker(spellingPositions[1], spellingLengths[1]) became false
+
+PASS internals.hasSpellingMarker(spellingPositions[0], spellingLengths[0]) became false
+PASS internals.hasSpellingMarker(spellingPositions[1], spellingLengths[1]) became false
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestseditingspellingeditingmultiplewordswithmarkershtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/editing/spelling/editing-multiple-words-with-markers.html (0 => 168426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/spelling/editing-multiple-words-with-markers.html (rev 0)
+++ trunk/LayoutTests/editing/spelling/editing-multiple-words-with-markers.html 2014-05-07 14:54:56 UTC (rev 168426)
</span><span class="lines">@@ -0,0 +1,106 @@
</span><ins>+<html>
+<head>
+<script src="../editing.js"></script>
+<title>Editing multiple words with markers test</title>
+</head>
+<body>
+<textarea id="testElement"></textarea>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description('The test verifies if the spelling markers disappear when '
+ + 'the multiple misspelled words are concatenated by delete command. '
+ + 'To test manually, type "it\'s a meagesga meagesga", then '
+ + 'select and delete "esga meag". The test succeeds '
+ + 'if the remaining text does not have any underline.');
+
+jsTestIsAsync = true;
+
+if (window.internals) {
+ internals.settings.setUnifiedTextCheckerEnabled(true);
+ internals.settings.setAsynchronousSpellCheckingEnabled(true);
+}
+
+function resetText() {
+ var textArea = document.getElementById('testElement');
+ textArea.value = "";
+ textArea.focus();
+ typeCharacterCommand('i');
+ typeCharacterCommand('t');
+ typeCharacterCommand('\'');
+ typeCharacterCommand('s');
+ typeCharacterCommand(' ');
+ typeCharacterCommand('a');
+ typeCharacterCommand(' ');
+ typeCharacterCommand('m');
+ typeCharacterCommand('e');
+ typeCharacterCommand('a');
+ typeCharacterCommand('g');
+ typeCharacterCommand('e');
+ typeCharacterCommand('s');
+ typeCharacterCommand('g');
+ typeCharacterCommand('a');
+ typeCharacterCommand(' ');
+ typeCharacterCommand('m');
+ typeCharacterCommand('e');
+ typeCharacterCommand('a');
+ typeCharacterCommand('g');
+ typeCharacterCommand('e');
+ typeCharacterCommand('s');
+ typeCharacterCommand('g');
+ typeCharacterCommand('a');
+ typeCharacterCommand(' ');
+}
+
+var testCases = [
+ { selectionRange: null, spellingMarkerPositions: [ 0, 7 ], spellingMarkerLengths: [ 4, 8 ], shouldBeMarked: [ false, true ] },
+ { selectionRange: [ 11, 20 ], spellingMarkerPositions: [ 7, 11 ], spellingMarkerLengths: [ 4, 4 ], shouldBeMarked: [ false, false] },
+ { selectionRange: [ 11, 16 ], spellingMarkerPositions: [ 7, 11 ], spellingMarkerLengths: [ 4, 8 ], shouldBeMarked: [ false, false] },
+ { selectionRange: [ 15, 20 ], spellingMarkerPositions: [ 7, 15 ], spellingMarkerLengths: [ 8, 4 ], shouldBeMarked: [ false, false] }
+];
+
+var spellingPositions;
+var spellingLengths;
+var markersExpectation;
+
+function checkSpellingMarkerAfterDeleteingSelection(selectionRange, spellingMarkerPositions, spellingMarkerLengths, shouldBeMarked)
+{
+ resetText();
+ if (selectionRange) {
+ document.getElementById('testElement').setSelectionRange(selectionRange[0], selectionRange[1]);
+ execDeleteCommand();
+ }
+
+ spellingPositions = spellingMarkerPositions;
+ spellingLengths = spellingMarkerLengths;
+ markersExpectation = shouldBeMarked;
+
+ if (window.internals) {
+ shouldBecomeEqual('internals.hasSpellingMarker(spellingPositions[0], spellingLengths[0])',
+ markersExpectation[0] ? 'true' : 'false', function() {
+ shouldBecomeEqual('internals.hasSpellingMarker(spellingPositions[1], spellingLengths[1])',
+ markersExpectation[1] ? 'true' : 'false', function() {
+ debug("");
+ done();
+ });
+ });
+ }
+}
+
+function done()
+{
+ var nextTestCase = testCases.shift();
+ if (nextTestCase)
+ return setTimeout(checkSpellingMarkerAfterDeleteingSelection(
+ nextTestCase.selectionRange,
+ nextTestCase.spellingMarkerPositions,
+ nextTestCase.spellingMarkerLengths,
+ nextTestCase.shouldBeMarked,
+ 0));
+
+ finishJSTest();
+}
+done();
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (168425 => 168426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-05-07 14:07:02 UTC (rev 168425)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-05-07 14:54:56 UTC (rev 168426)
</span><span class="lines">@@ -1138,6 +1138,7 @@
</span><span class="cx">
</span><span class="cx"> # Missing TextChecker::requestCheckingOfString() implementation for Gtk.
</span><span class="cx"> webkit.org/b/73003 editing/spelling/delete-into-misspelled-word.html [ Skip ]
</span><ins>+webkit.org/b/73003 editing/spelling/editing-multiple-words-with-markers.html [ Skip ]
</ins><span class="cx"> webkit.org/b/73003 editing/spelling/spellcheck-async-mutation.html [ Skip ]
</span><span class="cx"> webkit.org/b/73003 editing/spelling/spellcheck-async-remove-frame.html [ Skip ]
</span><span class="cx"> webkit.org/b/73003 editing/spelling/spellcheck-async.html [ Skip ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmaceditingspellingeditingmultiplewordswithmarkersexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt (168425 => 168426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt 2014-05-07 14:07:02 UTC (rev 168425)
+++ trunk/LayoutTests/platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt 2014-05-07 14:54:56 UTC (rev 168426)
</span><span class="lines">@@ -1,7 +0,0 @@
</span><del>-The test verified that when multiple words are modified by one editing command, their Spelling and Autocorrection markers are removed. When manully testing, type "it's a meagesga meagesga", then select and delete "esga meag", you should see the remaing text without any underline.
-
-
-SUCCESS
-SUCCESS
-SUCCESS
-
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmaceditingspellingeditingmultiplewordswithmarkershtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/mac/editing/spelling/editing-multiple-words-with-markers.html (168425 => 168426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/editing/spelling/editing-multiple-words-with-markers.html 2014-05-07 14:07:02 UTC (rev 168425)
+++ trunk/LayoutTests/platform/mac/editing/spelling/editing-multiple-words-with-markers.html 2014-05-07 14:54:56 UTC (rev 168426)
</span><span class="lines">@@ -1,85 +0,0 @@
</span><del>-<html>
-<head>
-<script src=../../../../editing/editing.js language="javascript" type="text/javascript"></script>
-<title>Editing multiple words with markers test</title>
-</head>
-<body>
-<p>The test verified that when multiple words are modified by one editing command, their Spelling and
-Autocorrection markers are removed. When manully testing, type "it's a meagesga meagesga", then
-select and delete "esga meag", you should see the remaing text without any underline.</p>
-<textarea id="test" cols="80" rows="10"></textarea>
-<div id="console"></div>
-<script language="javascript" type="text/javascript">
-function resetText() {
- document.getElementById('test').focus();
- execSelectAllCommand();
- execDeleteCommand();
- typeCharacterCommand('i');
- typeCharacterCommand('t');
- typeCharacterCommand('\'');
- typeCharacterCommand('s');
- typeCharacterCommand(' ');
- typeCharacterCommand('a');
- typeCharacterCommand(' ');
- typeCharacterCommand('m');
- typeCharacterCommand('e');
- typeCharacterCommand('a');
- typeCharacterCommand('g');
- typeCharacterCommand('e');
- typeCharacterCommand('s');
- typeCharacterCommand('g');
- typeCharacterCommand('a');
- typeCharacterCommand(' ');
- typeCharacterCommand('m');
- typeCharacterCommand('e');
- typeCharacterCommand('a');
- typeCharacterCommand('g');
- typeCharacterCommand('e');
- typeCharacterCommand('s');
- typeCharacterCommand('g');
- typeCharacterCommand('a');
- typeCharacterCommand(' ');
-}
-
-if (window.testRunner) {
- testRunner.dumpAsText();
-}
-
-textarea = document.getElementById('test');
-
-resetText();
-textarea.setSelectionRange(11, 20);
-execDeleteCommand();
-if (window.internals && window.internals.hasSpellingMarker) {
- if (window.internals.hasSpellingMarker(7,4) == 0 && window.internals.hasSpellingMarker(11,4) == 0) {
- document.getElementById('console').innerHTML = 'SUCCESS<br>';
- } else {
- document.getElementById('console').innerHTML = "FAILURE. The word 'meagesga' has underline.<br>";
- }
-}
-
-resetText();
-textarea.setSelectionRange(11, 16);
-execDeleteCommand();
-if (window.internals && window.internals.hasSpellingMarker) {
- if (window.internals.hasSpellingMarker(7,4) == 0 && window.internals.hasSpellingMarker(11,8) == 0) {
- document.getElementById('console').innerHTML = document.getElementById('console').innerHTML + 'SUCCESS<br>';
- } else {
- document.getElementById('console').innerHTML = document.getElementById('console').innerHTML + "FAILURE. The word 'meagmeagesga' has underline.<br>";
- }
-}
-
-resetText();
-textarea.setSelectionRange(15, 20);
-execDeleteCommand();
-if (window.internals && window.internals.hasSpellingMarker) {
- if (window.internals.hasSpellingMarker(7,8) == 0 && window.internals.hasSpellingMarker(15,4) == 0) {
- document.getElementById('console').innerHTML = document.getElementById('console').innerHTML + 'SUCCESS<br>';
- } else {
- document.getElementById('console').innerHTML = document.getElementById('console').innerHTML + "FAILURE. The word 'meagesgaesga' has underline.<br>";
- }
-}
-
-</script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (168425 => 168426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-05-07 14:07:02 UTC (rev 168425)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-05-07 14:54:56 UTC (rev 168426)
</span><span class="lines">@@ -119,6 +119,7 @@
</span><span class="cx"> webkit.org/b/105616 editing/spelling/context-menu-suggestions-multiword-selection.html
</span><span class="cx"> webkit.org/b/105616 editing/spelling/context-menu-suggestions-subword-selection.html
</span><span class="cx"> webkit.org/b/105616 editing/spelling/delete-into-misspelled-word.html
</span><ins>+webkit.org/b/105616 editing/spelling/editing-multiple-words-with-markers.html
</ins><span class="cx"> webkit.org/b/105616 editing/inserting/inserting-slash-inside-url-with-smart-link.html
</span><span class="cx"> webkit.org/b/105616 editing/spelling/spelling-changed-text.html
</span><span class="cx"> webkit.org/b/105616 editing/spelling/spelling-backspace-between-lines.html
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (168425 => 168426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations 2014-05-07 14:07:02 UTC (rev 168425)
+++ trunk/LayoutTests/platform/win/TestExpectations 2014-05-07 14:54:56 UTC (rev 168426)
</span><span class="lines">@@ -1933,6 +1933,7 @@
</span><span class="cx">
</span><span class="cx"> # Spellchecker behavior tests.
</span><span class="cx"> webkit.org/b/108370 editing/spelling/delete-into-misspelled-word.html [ Failure ]
</span><ins>+webkit.org/b/108370 editing/spelling/editing-multiple-words-with-markers.html [ Failure ]
</ins><span class="cx"> webkit.org/b/108370 editing/spelling/design-mode-spellcheck-off.html [ Failure ]
</span><span class="cx"> webkit.org/b/108370 editing/spelling/context-menu-suggestions-multiword-selection.html [ Failure ]
</span><span class="cx"> webkit.org/b/108370 editing/spelling/context-menu-suggestions-subword-selection.html [ Failure ]
</span></span></pre>
</div>
</div>
</body>
</html>