<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168432] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168432">168432</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2014-05-07 11:32:06 -0700 (Wed, 07 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: aria-expanded changes are not communicated to clients
https://bugs.webkit.org/show_bug.cgi?id=132642
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When aria-expanded changes on non list/tree items, send out a generic
AXExpandedChange notification.
Test: platform/mac/accessibility/expanded-notification.html
* accessibility/AXObjectCache.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
* platform/mac/accessibility/expanded-notification-expected.txt: Added.
* platform/mac/accessibility/expanded-notification.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAXObjectCacheh">trunk/Source/WebCore/accessibility/AXObjectCache.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacAXObjectCacheMacmm">trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityexpandednotificationexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/expanded-notification-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityexpandednotificationhtml">trunk/LayoutTests/platform/mac/accessibility/expanded-notification.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (168431 => 168432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-07 18:24:21 UTC (rev 168431)
+++ trunk/LayoutTests/ChangeLog 2014-05-07 18:32:06 UTC (rev 168432)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-05-07 Chris Fleizach <cfleizach@apple.com>
+
+ AX: aria-expanded changes are not communicated to clients
+ https://bugs.webkit.org/show_bug.cgi?id=132642
+
+ Reviewed by Mario Sanchez Prada.
+
+ * platform/mac/accessibility/expanded-notification-expected.txt: Added.
+ * platform/mac/accessibility/expanded-notification.html: Added.
+
</ins><span class="cx"> 2014-05-07 Christophe Dumez <ch.dumez@samsung.com>
</span><span class="cx">
</span><span class="cx"> [HTML] Default argument to HTMLTableElement.insertRow() should be -1
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityexpandednotificationexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/expanded-notification-expected.txt (0 => 168432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/expanded-notification-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/expanded-notification-expected.txt 2014-05-07 18:32:06 UTC (rev 168432)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+
+This tests that aria-expanded changes will send notifications.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Initial expanded status: false
+Received notification: AXExpandedChanged
+Expanded status: true
+Received notification: AXExpandedChanged
+Expanded status: false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityexpandednotificationhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/expanded-notification.html (0 => 168432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/expanded-notification.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/expanded-notification.html 2014-05-07 18:32:06 UTC (rev 168432)
</span><span class="lines">@@ -0,0 +1,55 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../../../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<div id="content">
+
+<button id="button" aria-expanded="false">
+
+</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that aria-expanded changes will send notifications.");
+
+ var element = 0;
+ var notification = 0;
+ var notificationCount = 0;
+ function ariaCallback(element, notification) {
+ if (notification == "AXExpandedChanged") {
+ notificationCount++;
+
+ debug("Received notification: " + notification);
+ debug("Expanded status: " + element.isExpanded);
+ if (notificationCount == 2) {
+ accessibilityController.removeNotificationListener();
+ finishJSTest();
+ }
+ }
+ }
+
+ if (window.accessibilityController) {
+ window.jsTestIsAsync = true;
+
+ var addedNotification = accessibilityController.addNotificationListener(ariaCallback);
+ debug("Initial expanded status: " + accessibilityController.accessibleElementById("button").isExpanded);
+
+ setTimeout(function() {
+ document.getElementById("button").setAttribute("aria-expanded", "true");
+ setTimeout(function() {
+ document.getElementById("button").setAttribute("aria-expanded", "false");
+ }, 10);
+ }, 10);
+ }
+
+</script>
+
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (168431 => 168432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-07 18:24:21 UTC (rev 168431)
+++ trunk/Source/WebCore/ChangeLog 2014-05-07 18:32:06 UTC (rev 168432)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-05-07 Chris Fleizach <cfleizach@apple.com>
+
+ AX: aria-expanded changes are not communicated to clients
+ https://bugs.webkit.org/show_bug.cgi?id=132642
+
+ Reviewed by Mario Sanchez Prada.
+
+ When aria-expanded changes on non list/tree items, send out a generic
+ AXExpandedChange notification.
+
+ Test: platform/mac/accessibility/expanded-notification.html
+
+ * accessibility/AXObjectCache.h:
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
+ * accessibility/mac/AXObjectCacheMac.mm:
+ (WebCore::AXObjectCache::postPlatformNotification):
+
</ins><span class="cx"> 2014-05-07 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Release build fix.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAXObjectCacheh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (168431 => 168432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AXObjectCache.h 2014-05-07 18:24:21 UTC (rev 168431)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h 2014-05-07 18:32:06 UTC (rev 168432)
</span><span class="lines">@@ -178,6 +178,7 @@
</span><span class="cx"> AXRowCountChanged,
</span><span class="cx"> AXRowCollapsed,
</span><span class="cx"> AXRowExpanded,
</span><ins>+ AXExpandedChanged,
</ins><span class="cx"> AXInvalidStatusChanged,
</span><span class="cx"> AXTextChanged,
</span><span class="cx"> AXAriaAttributeChanged,
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (168431 => 168432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-05-07 18:24:21 UTC (rev 168431)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-05-07 18:32:06 UTC (rev 168432)
</span><span class="lines">@@ -2329,6 +2329,8 @@
</span><span class="cx"> // Post that the specific row either collapsed or expanded.
</span><span class="cx"> if (roleValue() == RowRole || roleValue() == TreeItemRole)
</span><span class="cx"> cache->postNotification(this, document(), isExpanded() ? AXObjectCache::AXRowExpanded : AXObjectCache::AXRowCollapsed);
</span><ins>+ else
+ cache->postNotification(this, document(), AXObjectCache::AXExpandedChanged);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void AccessibilityRenderObject::handleActiveDescendantChanged()
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacAXObjectCacheMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm (168431 => 168432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2014-05-07 18:24:21 UTC (rev 168431)
+++ trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2014-05-07 18:32:06 UTC (rev 168432)
</span><span class="lines">@@ -125,6 +125,9 @@
</span><span class="cx"> case AXElementBusyChanged:
</span><span class="cx"> macNotification = @"AXElementBusyChanged";
</span><span class="cx"> break;
</span><ins>+ case AXExpandedChanged:
+ macNotification = @"AXExpandedChanged";
+ break;
</ins><span class="cx"> case AXMenuClosed:
</span><span class="cx"> macNotification = (id)kAXMenuClosedNotification;
</span><span class="cx"> break;
</span></span></pre>
</div>
</div>
</body>
</html>