<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168383] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168383">168383</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-05-06 15:13:45 -0700 (Tue, 06 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>ChildNodesLazySnapshot::m_childNodes needs two heap allocations.
<https://webkit.org/b/132616>
This seems a bit silly, since ChildNodesLazySnapshot is always
allocated on the stack.
Change it to be a bool + a Vector instead of using the nullity
as a presence indicator. This way we also don't end up with an
out-of-line ~OwnPtr for the Vector.
Reviewed by Geoff Garen.
* dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::ChildNodesLazySnapshot):
(WebCore::ChildNodesLazySnapshot::nextNode):
(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(WebCore::ChildNodesLazySnapshot::hasSnapshot):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomContainerNodeh">trunk/Source/WebCore/dom/ContainerNode.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (168382 => 168383)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-06 22:11:07 UTC (rev 168382)
+++ trunk/Source/WebCore/ChangeLog 2014-05-06 22:13:45 UTC (rev 168383)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2014-05-06 Andreas Kling <akling@apple.com>
+
+ ChildNodesLazySnapshot::m_childNodes needs two heap allocations.
+ <https://webkit.org/b/132616>
+
+ This seems a bit silly, since ChildNodesLazySnapshot is always
+ allocated on the stack.
+
+ Change it to be a bool + a Vector instead of using the nullity
+ as a presence indicator. This way we also don't end up with an
+ out-of-line ~OwnPtr for the Vector.
+
+ Reviewed by Geoff Garen.
+
+ * dom/ContainerNode.h:
+ (WebCore::ChildNodesLazySnapshot::ChildNodesLazySnapshot):
+ (WebCore::ChildNodesLazySnapshot::nextNode):
+ (WebCore::ChildNodesLazySnapshot::takeSnapshot):
+ (WebCore::ChildNodesLazySnapshot::hasSnapshot):
+
</ins><span class="cx"> 2014-05-06 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Eliminate BlobStorageData
</span></span></pre></div>
<a id="trunkSourceWebCoredomContainerNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ContainerNode.h (168382 => 168383)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ContainerNode.h 2014-05-06 22:11:07 UTC (rev 168382)
+++ trunk/Source/WebCore/dom/ContainerNode.h 2014-05-06 22:13:45 UTC (rev 168383)
</span><span class="lines">@@ -252,6 +252,7 @@
</span><span class="cx"> explicit ChildNodesLazySnapshot(Node& parentNode)
</span><span class="cx"> : m_currentNode(parentNode.firstChild())
</span><span class="cx"> , m_currentIndex(0)
</span><ins>+ , m_hasSnapshot(false)
</ins><span class="cx"> {
</span><span class="cx"> m_nextSnapshot = latestSnapshot;
</span><span class="cx"> latestSnapshot = this;
</span><span class="lines">@@ -271,26 +272,25 @@
</span><span class="cx"> m_currentNode = node->nextSibling();
</span><span class="cx"> return node.release();
</span><span class="cx"> }
</span><del>- Vector<RefPtr<Node>>& nodeVector = *m_childNodes;
- if (m_currentIndex >= nodeVector.size())
</del><ins>+ if (m_currentIndex >= m_snapshot.size())
</ins><span class="cx"> return 0;
</span><del>- return nodeVector[m_currentIndex++];
</del><ins>+ return m_snapshot[m_currentIndex++];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void takeSnapshot()
</span><span class="cx"> {
</span><span class="cx"> if (hasSnapshot())
</span><span class="cx"> return;
</span><del>- m_childNodes = adoptPtr(new Vector<RefPtr<Node>>());
</del><ins>+ m_hasSnapshot = true;
</ins><span class="cx"> Node* node = m_currentNode.get();
</span><span class="cx"> while (node) {
</span><del>- m_childNodes->append(node);
</del><ins>+ m_snapshot.append(node);
</ins><span class="cx"> node = node->nextSibling();
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ChildNodesLazySnapshot* nextSnapshot() { return m_nextSnapshot; }
</span><del>- bool hasSnapshot() { return !!m_childNodes.get(); }
</del><ins>+ bool hasSnapshot() { return m_hasSnapshot; }
</ins><span class="cx">
</span><span class="cx"> static void takeChildNodesLazySnapshot()
</span><span class="cx"> {
</span><span class="lines">@@ -306,7 +306,8 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<Node> m_currentNode;
</span><span class="cx"> unsigned m_currentIndex;
</span><del>- OwnPtr<Vector<RefPtr<Node>>> m_childNodes; // Lazily instantiated.
</del><ins>+ bool m_hasSnapshot;
+ Vector<RefPtr<Node>> m_snapshot; // Lazily instantiated.
</ins><span class="cx"> ChildNodesLazySnapshot* m_nextSnapshot;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>