<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168405] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168405">168405</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2014-05-06 20:47:06 -0700 (Tue, 06 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>-[WKWebView isLoading] is NO immediately after -loadRequest: until the provisional load starts
https://bugs.webkit.org/show_bug.cgi?id=132639
Reviewed by Darin Adler.
* UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::commitChanges): Updated for change from isLoadingState to isLoading.
(WebKit::PageLoadState::isLoading): Renamed from isLoadingState, changed to take Data and
check whether there is a non-null pending API request URL. If so, return true.
* UIProcess/PageLoadState.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPageLoadStatecpp">trunk/Source/WebKit2/UIProcess/PageLoadState.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPageLoadStateh">trunk/Source/WebKit2/UIProcess/PageLoadState.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (168404 => 168405)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-05-07 02:58:39 UTC (rev 168404)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-07 03:47:06 UTC (rev 168405)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-05-06 Dan Bernstein <mitz@apple.com>
+
+ -[WKWebView isLoading] is NO immediately after -loadRequest: until the provisional load starts
+ https://bugs.webkit.org/show_bug.cgi?id=132639
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/PageLoadState.cpp:
+ (WebKit::PageLoadState::commitChanges): Updated for change from isLoadingState to isLoading.
+ (WebKit::PageLoadState::isLoading): Renamed from isLoadingState, changed to take Data and
+ check whether there is a non-null pending API request URL. If so, return true.
+ * UIProcess/PageLoadState.h:
+
</ins><span class="cx"> 2014-05-06 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] Allow focus rings to redraw themselves if necessary
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPageLoadStatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/PageLoadState.cpp (168404 => 168405)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/PageLoadState.cpp 2014-05-07 02:58:39 UTC (rev 168404)
+++ trunk/Source/WebKit2/UIProcess/PageLoadState.cpp 2014-05-07 03:47:06 UTC (rev 168405)
</span><span class="lines">@@ -96,7 +96,7 @@
</span><span class="cx"> m_mayHaveUncommittedChanges = false;
</span><span class="cx">
</span><span class="cx"> bool titleChanged = m_committedState.title != m_uncommittedState.title;
</span><del>- bool isLoadingChanged = isLoadingState(m_committedState.state) != isLoadingState(m_uncommittedState.state);
</del><ins>+ bool isLoadingChanged = isLoading(m_committedState) != isLoading(m_uncommittedState);
</ins><span class="cx"> bool activeURLChanged = activeURL(m_committedState) != activeURL(m_uncommittedState);
</span><span class="cx"> bool hasOnlySecureContentChanged = hasOnlySecureContent(m_committedState) != hasOnlySecureContent(m_uncommittedState);
</span><span class="cx"> bool estimatedProgressChanged = estimatedProgress(m_committedState) != estimatedProgress(m_uncommittedState);
</span><span class="lines">@@ -148,7 +148,7 @@
</span><span class="cx">
</span><span class="cx"> bool PageLoadState::isLoading() const
</span><span class="cx"> {
</span><del>- return isLoadingState(m_committedState.state);
</del><ins>+ return isLoading(m_committedState);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String PageLoadState::activeURL(const Data& data)
</span><span class="lines">@@ -336,9 +336,12 @@
</span><span class="cx"> m_uncommittedState.estimatedProgress = 1;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool PageLoadState::isLoadingState(State state)
</del><ins>+bool PageLoadState::isLoading(const Data& data)
</ins><span class="cx"> {
</span><del>- switch (state) {
</del><ins>+ if (!data.pendingAPIRequestURL.isNull())
+ return true;
+
+ switch (data.state) {
</ins><span class="cx"> case State::Provisional:
</span><span class="cx"> case State::Committed:
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPageLoadStateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/PageLoadState.h (168404 => 168405)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/PageLoadState.h 2014-05-07 02:58:39 UTC (rev 168404)
+++ trunk/Source/WebKit2/UIProcess/PageLoadState.h 2014-05-07 03:47:06 UTC (rev 168405)
</span><span class="lines">@@ -139,8 +139,6 @@
</span><span class="cx"> void didFinishProgress(const Transaction::Token&);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- static bool isLoadingState(State);
-
</del><span class="cx"> void beginTransaction() { ++m_outstandingTransactionCount; }
</span><span class="cx"> void endTransaction();
</span><span class="cx">
</span><span class="lines">@@ -171,6 +169,7 @@
</span><span class="cx"> double estimatedProgress;
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+ static bool isLoading(const Data&);
</ins><span class="cx"> static String activeURL(const Data&);
</span><span class="cx"> static bool hasOnlySecureContent(const Data&);
</span><span class="cx"> static double estimatedProgress(const Data&);
</span></span></pre>
</div>
</div>
</body>
</html>