<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168310] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168310">168310</a></dd>
<dt>Author</dt> <dd>bdakin@apple.com</dd>
<dt>Date</dt> <dd>2014-05-05 12:46:30 -0700 (Mon, 05 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/168244">r168244</a>): compositing/visibility/visibility-image-layers-dynamic.html
failing.
https://bugs.webkit.org/show_bug.cgi?id=132551
Reviewed by Tim Horton.
This just needed a re-baseline after all. The bounds have increased in size
because the size of the layer tree dump effects the bounds! So now that we are
printing out anchor points, the bound increase by 15 pixels for every new anchor
point print-out.
Should not longer be marked failing.
* TestExpectations:
Added comment to the test.
* compositing/visibility/visibility-image-layers-dynamic.html:
Re-baseline.
* platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestscompositingvisibilityvisibilityimagelayersdynamichtml">trunk/LayoutTests/compositing/visibility/visibility-image-layers-dynamic.html</a></li>
<li><a href="#trunkLayoutTestsplatformmaccompositingvisibilityvisibilityimagelayersdynamicexpectedtxt">trunk/LayoutTests/platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (168309 => 168310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-05 19:43:12 UTC (rev 168309)
+++ trunk/LayoutTests/ChangeLog 2014-05-05 19:46:30 UTC (rev 168310)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2014-05-05 Beth Dakin <bdakin@apple.com>
+
+ REGRESSION (r168244): compositing/visibility/visibility-image-layers-dynamic.html
+ failing.
+ https://bugs.webkit.org/show_bug.cgi?id=132551
+
+ Reviewed by Tim Horton.
+
+ This just needed a re-baseline after all. The bounds have increased in size
+ because the size of the layer tree dump effects the bounds! So now that we are
+ printing out anchor points, the bound increase by 15 pixels for every new anchor
+ point print-out.
+
+ Should not longer be marked failing.
+ * TestExpectations:
+
+ Added comment to the test.
+ * compositing/visibility/visibility-image-layers-dynamic.html:
+
+ Re-baseline.
+ * platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
+
</ins><span class="cx"> 2014-05-05 Ion Rosca <rosca@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSS Blending] Move fast/repaint tests to css3/compositing/repaint
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (168309 => 168310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2014-05-05 19:43:12 UTC (rev 168309)
+++ trunk/LayoutTests/TestExpectations 2014-05-05 19:46:30 UTC (rev 168310)
</span><span class="lines">@@ -110,7 +110,3 @@
</span><span class="cx"> # Reference expectation doesn't end up in compositing code path, leading to antialiasing differences.
</span><span class="cx"> webkit.org/b/132421 fast/multicol/fixed-stack.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><del>-# Regression from r168244:
-# Top content inset: Margin tiles should not display in the inset area when pinned
-# to the top of the page.
-webkit.org/b/132551 compositing/visibility/visibility-image-layers-dynamic.html [ Failure ]
</del></span></pre></div>
<a id="trunkLayoutTestscompositingvisibilityvisibilityimagelayersdynamichtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/compositing/visibility/visibility-image-layers-dynamic.html (168309 => 168310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/visibility/visibility-image-layers-dynamic.html 2014-05-05 19:43:12 UTC (rev 168309)
+++ trunk/LayoutTests/compositing/visibility/visibility-image-layers-dynamic.html 2014-05-05 19:46:30 UTC (rev 168310)
</span><span class="lines">@@ -79,6 +79,8 @@
</span><span class="cx"> </head>
</span><span class="cx"> <body>
</span><span class="cx"> <!-- Tests dynamic changes of visibility, using directly composited images. -->
</span><ins>+ <!-- FIXME: The size of the layer tree dumps effect the size of the layer bounds in this test. So if more
+ or less information is added to or removed from the dump, the bounds will also change. -->
</ins><span class="cx"> <div class="composited container"><img src="../resources/thiswayup.png" class="hidden composited box"></div>
</span><span class="cx"> <div class="composited hidden container"><img src="../resources/thiswayup.png" class="composited box"></div>
</span><span class="cx"> <div class="composited hidden container"><img src="../resources/thiswayup.png" class="visible composited box"></div>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmaccompositingvisibilityvisibilityimagelayersdynamicexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt (168309 => 168310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt 2014-05-05 19:43:12 UTC (rev 168309)
+++ trunk/LayoutTests/platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt 2014-05-05 19:46:30 UTC (rev 168310)
</span><span class="lines">@@ -4,6 +4,7 @@
</span><span class="cx"> Initial
</span><span class="cx">
</span><span class="cx"> (GraphicsLayer
</span><ins>+ (anchor 0.00 0.00)
</ins><span class="cx"> (bounds 785.00 626.00)
</span><span class="cx"> (children 1
</span><span class="cx"> (GraphicsLayer
</span><span class="lines">@@ -54,10 +55,11 @@
</span><span class="cx"> After step 1
</span><span class="cx">
</span><span class="cx"> (GraphicsLayer
</span><del>- (bounds 785.00 1366.00)
</del><ins>+ (anchor 0.00 0.00)
+ (bounds 785.00 1381.00)
</ins><span class="cx"> (children 1
</span><span class="cx"> (GraphicsLayer
</span><del>- (bounds 785.00 1366.00)
</del><ins>+ (bounds 785.00 1381.00)
</ins><span class="cx"> (contentsOpaque 1)
</span><span class="cx"> (children 3
</span><span class="cx"> (GraphicsLayer
</span><span class="lines">@@ -103,10 +105,11 @@
</span><span class="cx"> After step 2
</span><span class="cx">
</span><span class="cx"> (GraphicsLayer
</span><del>- (bounds 785.00 2090.00)
</del><ins>+ (anchor 0.00 0.00)
+ (bounds 785.00 2120.00)
</ins><span class="cx"> (children 1
</span><span class="cx"> (GraphicsLayer
</span><del>- (bounds 785.00 2090.00)
</del><ins>+ (bounds 785.00 2120.00)
</ins><span class="cx"> (contentsOpaque 1)
</span><span class="cx"> (children 3
</span><span class="cx"> (GraphicsLayer
</span></span></pre>
</div>
</div>
</body>
</html>