<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168305] releases/WebKitGTK/webkit-2.4</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168305">168305</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-05 11:44:59 -0700 (Mon, 05 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/167569">r167569</a> - Crashes in HTMLFormElement::submit.
https://bugs.webkit.org/show_bug.cgi?id=131910
<rdar://problem/15661790>
Source/WebCore:
Based on a patch by Kent Tamura.
Reviewed by Anders Carlsson.
Tests: fast/forms/form-submission-crash-2.html
fast/forms/form-submission-crash.html
Code that executes arbitrary JS needs to protect objects that it uses afterwards.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::prepareForSubmission):
(WebCore::HTMLFormElement::submit):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
LayoutTests:
Reviewed by Anders Carlsson.
* fast/forms/form-submission-crash-2-expected.txt: Added.
* fast/forms/form-submission-crash-2.html: Added.
* fast/forms/form-submission-crash-expected.txt: Added.
* fast/forms/form-submission-crash.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCorehtmlHTMLFormElementcpp">releases/WebKitGTK/webkit-2.4/Source/WebCore/html/HTMLFormElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCoreloaderFrameLoadercpp">releases/WebKitGTK/webkit-2.4/Source/WebCore/loader/FrameLoader.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrash2expectedtxt">releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-2-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrash2html">releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-2.html</a></li>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrashexpectedtxt">releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrashhtml">releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit24LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog (168304 => 168305)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-05-05 18:38:05 UTC (rev 168304)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-05-05 18:44:59 UTC (rev 168305)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-04-19 Alexey Proskuryakov <ap@apple.com>
+
+ Crashes in HTMLFormElement::submit.
+ https://bugs.webkit.org/show_bug.cgi?id=131910
+ <rdar://problem/15661790>
+
+ Reviewed by Anders Carlsson.
+
+ * fast/forms/form-submission-crash-2-expected.txt: Added.
+ * fast/forms/form-submission-crash-2.html: Added.
+ * fast/forms/form-submission-crash-expected.txt: Added.
+ * fast/forms/form-submission-crash.html: Added.
+
</ins><span class="cx"> 2014-04-17 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> hostname extraction from a URL should not decode percent-escape sequences
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrash2expectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-2-expected.txt (0 => 168305)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-2-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-2-expected.txt 2014-05-05 18:44:59 UTC (rev 168305)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+PASS if not crashed.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrash2html"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-2.html (0 => 168305)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-2.html (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-2.html 2014-05-05 18:44:59 UTC (rev 168305)
</span><span class="lines">@@ -0,0 +1,30 @@
</span><ins>+<!DOCTYPE html>
+<body>
+<script src="../../resources/js-test.js"></script>
+<script>
+jsTestIsAsync = true;
+var form1;
+var submit1;
+
+function start() {
+ form1 = document.createElement('form');
+ submit1 = document.createElement('input');
+ submit1.type = 'submit';
+ form1.action = 'javascript:crash()';
+ form1.appendChild(submit1);
+ setTimeout(function() {
+ submit1.click();
+ testPassed('if not crashed.');
+ finishJSTest();
+ }, 0);
+}
+
+function crash() {
+ form1.removeChild(submit1);
+ form1 = null;
+ gc();
+}
+window.onload = start;
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrashexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-expected.txt (0 => 168305)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-expected.txt 2014-05-05 18:44:59 UTC (rev 168305)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+PASS if not crashed.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrashhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash.html (0 => 168305)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash.html (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash.html 2014-05-05 18:44:59 UTC (rev 168305)
</span><span class="lines">@@ -0,0 +1,30 @@
</span><ins>+<!DOCTYPE html>
+<body>
+<script src="../../resources/js-test.js"></script>
+<script>
+jsTestIsAsync = true;
+var form1;
+var submit1;
+
+function start() {
+ form1 = document.createElement('form');
+ submit1 = document.createElement('input');
+ submit1.type = 'submit';
+ form1.addEventListener('submit', handleSubmit, false);
+ form1.action = 'javascript:gc()';
+ form1.appendChild(submit1);
+ setTimeout(function() {
+ submit1.click();
+ testPassed('if not crashed.');
+ finishJSTest();
+ }, 0);
+}
+
+function handleSubmit() {
+ form1.removeChild(submit1);
+ form1 = null;
+}
+window.onload = start;
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog (168304 => 168305)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-05-05 18:38:05 UTC (rev 168304)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-05-05 18:44:59 UTC (rev 168305)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-04-19 Alexey Proskuryakov <ap@apple.com>
+
+ Crashes in HTMLFormElement::submit.
+ https://bugs.webkit.org/show_bug.cgi?id=131910
+ <rdar://problem/15661790>
+
+ Based on a patch by Kent Tamura.
+
+ Reviewed by Anders Carlsson.
+
+ Tests: fast/forms/form-submission-crash-2.html
+ fast/forms/form-submission-crash.html
+
+ Code that executes arbitrary JS needs to protect objects that it uses afterwards.
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::prepareForSubmission):
+ (WebCore::HTMLFormElement::submit):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::submitForm):
+
</ins><span class="cx"> 2014-04-18 Jon Honeycutt <jhoneycutt@apple.com>
</span><span class="cx">
</span><span class="cx"> Harden RenderInline::inlineElementContinuation()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCorehtmlHTMLFormElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/html/HTMLFormElement.cpp (168304 => 168305)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/html/HTMLFormElement.cpp 2014-05-05 18:38:05 UTC (rev 168304)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/html/HTMLFormElement.cpp 2014-05-05 18:44:59 UTC (rev 168305)
</span><span class="lines">@@ -280,6 +280,7 @@
</span><span class="cx"> RefPtr<FormState> formState = FormState::create(this, controlNamesAndValues, &document(), NotSubmittedByJavaScript);
</span><span class="cx"> frame->loader().client().dispatchWillSendSubmitEvent(formState.release());
</span><span class="cx">
</span><ins>+ Ref<HTMLFormElement> protect(*this);
</ins><span class="cx"> if (dispatchEvent(Event::create(eventNames().submitEvent, true, true)))
</span><span class="cx"> m_shouldSubmit = true;
</span><span class="cx">
</span><span class="lines">@@ -353,6 +354,7 @@
</span><span class="cx"> firstSuccessfulSubmitButton->setActivatedSubmit(true);
</span><span class="cx">
</span><span class="cx"> bool lockHistory = !processingUserGesture;
</span><ins>+ Ref<HTMLFormElement> protect(*this); // Form submission can execute arbitary JavaScript.
</ins><span class="cx"> frame->loader().submitForm(FormSubmission::create(this, m_attributes, event, lockHistory, formSubmissionTrigger));
</span><span class="cx">
</span><span class="cx"> if (needButtonActivation && firstSuccessfulSubmitButton)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCoreloaderFrameLoadercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/loader/FrameLoader.cpp (168304 => 168305)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/loader/FrameLoader.cpp 2014-05-05 18:38:05 UTC (rev 168304)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/loader/FrameLoader.cpp 2014-05-05 18:44:59 UTC (rev 168305)
</span><span class="lines">@@ -384,6 +384,7 @@
</span><span class="cx"> if (!m_frame.document()->contentSecurityPolicy()->allowFormAction(URL(submission->action())))
</span><span class="cx"> return;
</span><span class="cx"> m_isExecutingJavaScriptFormAction = true;
</span><ins>+ Ref<Frame> protect(m_frame);
</ins><span class="cx"> m_frame.script().executeIfJavaScriptURL(submission->action(), DoNotReplaceDocumentIfJavaScriptURL);
</span><span class="cx"> m_isExecutingJavaScriptFormAction = false;
</span><span class="cx"> return;
</span></span></pre>
</div>
</div>
</body>
</html>