<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168272] releases/WebKitGTK/webkit-2.4</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168272">168272</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-05 03:09:29 -0700 (Mon, 05 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/166457">r166457</a> - Preserve selection end positions in directionOfSelection
<http://webkit.org/b/104813>
<rdar://problem/13666417>
Reviewed by Brent Fulgham.
Merged from Blink (patch by kenrb@chromium.org):
https://src.chromium.org/viewvc/blink?revision=150621&view=revision
http://crbug.com/164263
VisibleSelection::visibleStart() and VisibleSelection::visibleEnd()
can both cause layouts, which has the potential to invalidate any
rendertree-based objects. This was causing a problem in
FrameSelection::directionOfSelection(), where a reference to a
lineBox was being held across a call to visibleEnd().
This patch ensures that the any layout is completed before linebox
references are retrieved.
Source/WebCore:
Test: editing/selection/layout-during-move-selection-crash.html
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::directionOfSelection):
LayoutTests:
* editing/selection/layout-during-move-selection-crash-expected.txt: Added.
* editing/selection/layout-during-move-selection-crash.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCoreeditingFrameSelectioncpp">releases/WebKitGTK/webkit-2.4/Source/WebCore/editing/FrameSelection.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestseditingselectionlayoutduringmoveselectioncrashexpectedtxt">releases/WebKitGTK/webkit-2.4/LayoutTests/editing/selection/layout-during-move-selection-crash-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestseditingselectionlayoutduringmoveselectioncrashhtml">releases/WebKitGTK/webkit-2.4/LayoutTests/editing/selection/layout-during-move-selection-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit24LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog (168271 => 168272)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-05-05 10:05:16 UTC (rev 168271)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-05-05 10:09:29 UTC (rev 168272)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2014-03-29 David Kilzer <ddkilzer@apple.com>
+
+ Preserve selection end positions in directionOfSelection
+ <http://webkit.org/b/104813>
+ <rdar://problem/13666417>
+
+ Reviewed by Brent Fulgham.
+
+ Merged from Blink (patch by kenrb@chromium.org):
+ https://src.chromium.org/viewvc/blink?revision=150621&view=revision
+ http://crbug.com/164263
+
+ VisibleSelection::visibleStart() and VisibleSelection::visibleEnd()
+ can both cause layouts, which has the potential to invalidate any
+ rendertree-based objects. This was causing a problem in
+ FrameSelection::directionOfSelection(), where a reference to a
+ lineBox was being held across a call to visibleEnd().
+
+ This patch ensures that the any layout is completed before linebox
+ references are retrieved.
+
+ * editing/selection/layout-during-move-selection-crash-expected.txt: Added.
+ * editing/selection/layout-during-move-selection-crash.html: Added.
+
</ins><span class="cx"> 2014-03-28 Radu Stavila <stavila@adobe.com>
</span><span class="cx">
</span><span class="cx"> In some situations, partial layouts of floating elements produce incorrect results.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestseditingselectionlayoutduringmoveselectioncrashexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/editing/selection/layout-during-move-selection-crash-expected.txt (0 => 168272)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/editing/selection/layout-during-move-selection-crash-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/editing/selection/layout-during-move-selection-crash-expected.txt 2014-05-05 10:09:29 UTC (rev 168272)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+
+button PASS, if no crash or assert in debug
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestseditingselectionlayoutduringmoveselectioncrashhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/editing/selection/layout-during-move-selection-crash.html (0 => 168272)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/editing/selection/layout-during-move-selection-crash.html (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/editing/selection/layout-during-move-selection-crash.html 2014-05-05 10:09:29 UTC (rev 168272)
</span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<span id=span1></span><button id=button1>button</button>
+<style>
+ .embedStyle { min-height: 13pc; -webkit-transition: 10s; }
+</style>
+<script>
+ function runTest() {
+ div1 = document.createElement("div");
+ document.body.appendChild(div1);
+ embed1 = document.createElementNS("http://www.w3.org/1999/xhtml", "embed");
+ document.body.offsetTop;
+ embed1.setAttribute("class", "embedStyle");
+ span1.appendChild(embed1);
+ embed1.setAttribute("type", "block");
+ document.body.offsetTop;
+ r = document.createRange();
+ r.setStart(button1, 0);
+ r.setEnd(div1, div1.childNodes.length);
+ window.getSelection().addRange(r);
+ o = r.extractContents();
+ document.body.appendChild(o);
+ window.getSelection().modify("move", "Right", "character");
+
+ if (window.testRunner) testRunner.dumpAsText();
+ }
+ document.addEventListener("DOMContentLoaded", runTest, false);
+</script>PASS, if no crash or assert in debug
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog (168271 => 168272)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-05-05 10:05:16 UTC (rev 168271)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-05-05 10:09:29 UTC (rev 168272)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2014-03-29 David Kilzer <ddkilzer@apple.com>
+
+ Preserve selection end positions in directionOfSelection
+ <http://webkit.org/b/104813>
+ <rdar://problem/13666417>
+
+ Reviewed by Brent Fulgham.
+
+ Merged from Blink (patch by kenrb@chromium.org):
+ https://src.chromium.org/viewvc/blink?revision=150621&view=revision
+ http://crbug.com/164263
+
+ VisibleSelection::visibleStart() and VisibleSelection::visibleEnd()
+ can both cause layouts, which has the potential to invalidate any
+ rendertree-based objects. This was causing a problem in
+ FrameSelection::directionOfSelection(), where a reference to a
+ lineBox was being held across a call to visibleEnd().
+
+ This patch ensures that the any layout is completed before linebox
+ references are retrieved.
+
+ Test: editing/selection/layout-during-move-selection-crash.html
+
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::directionOfSelection):
+
</ins><span class="cx"> 2014-03-28 Radu Stavila <stavila@adobe.com>
</span><span class="cx">
</span><span class="cx"> In some situations, partial layouts of floating elements produce incorrect results.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCoreeditingFrameSelectioncpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/editing/FrameSelection.cpp (168271 => 168272)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/editing/FrameSelection.cpp 2014-05-05 10:05:16 UTC (rev 168271)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/editing/FrameSelection.cpp 2014-05-05 10:09:29 UTC (rev 168272)
</span><span class="lines">@@ -493,10 +493,14 @@
</span><span class="cx"> InlineBox* startBox = 0;
</span><span class="cx"> InlineBox* endBox = 0;
</span><span class="cx"> int unusedOffset;
</span><del>- if (m_selection.start().isNotNull())
- m_selection.visibleStart().getInlineBoxAndOffset(startBox, unusedOffset);
- if (m_selection.end().isNotNull())
- m_selection.visibleEnd().getInlineBoxAndOffset(endBox, unusedOffset);
</del><ins>+ // Cache the VisiblePositions because visibleStart() and visibleEnd()
+ // can cause layout, which has the potential to invalidate lineboxes.
+ VisiblePosition startPosition = m_selection.visibleStart();
+ VisiblePosition endPosition = m_selection.visibleEnd();
+ if (startPosition.isNotNull())
+ startPosition.getInlineBoxAndOffset(startBox, unusedOffset);
+ if (endPosition.isNotNull())
+ endPosition.getInlineBoxAndOffset(endBox, unusedOffset);
</ins><span class="cx"> if (startBox && endBox && startBox->direction() == endBox->direction())
</span><span class="cx"> return startBox->direction();
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>