<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168274] releases/WebKitGTK/webkit-2.4</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168274">168274</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-05 03:30:44 -0700 (Mon, 05 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/166601">r166601</a> - RenderQuote must destroy remaining text renderer before first letter renderer
https://bugs.webkit.org/show_bug.cgi?id=78023
<rdar://problem/10830009>
Reviewed by Brent Fulgham.
Merged from Blink (patch by Abhishek Arya):
https://src.chromium.org/viewvc/blink?view=rev&revision=151270
Source/WebCore:
Following the fix for <https://bugs.webkit.org/show_bug.cgi?id=114586>, a
RenderQuote may have child render objects for the first letter of its text
and everything following the first letter so as to support the CSS first-
letter property. The latter renderer is responsible for destroying the former
on destruction. It's sufficient to reverse the destruction of the children of
RenderQuote to ensure that we destroy the remaining text renderer before we
destroy the first letter renderer.
Test: fast/css-generated-content/quote-first-letter-crash.html
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::updateText):
LayoutTests:
* fast/css-generated-content/quote-first-letter-crash-expected.txt: Added.
* fast/css-generated-content/quote-first-letter-crash.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCorerenderingRenderQuotecpp">releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderQuote.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsfastcssgeneratedcontentquotefirstlettercrashexpectedtxt">releases/WebKitGTK/webkit-2.4/LayoutTests/fast/css-generated-content/quote-first-letter-crash-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsfastcssgeneratedcontentquotefirstlettercrashhtml">releases/WebKitGTK/webkit-2.4/LayoutTests/fast/css-generated-content/quote-first-letter-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit24LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog (168273 => 168274)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-05-05 10:27:19 UTC (rev 168273)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-05-05 10:30:44 UTC (rev 168274)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-04-01 Daniel Bates <dabates@apple.com>
+
+ RenderQuote must destroy remaining text renderer before first letter renderer
+ https://bugs.webkit.org/show_bug.cgi?id=78023
+ <rdar://problem/10830009>
+
+ Reviewed by Brent Fulgham.
+
+ Merged from Blink (patch by Abhishek Arya):
+ https://src.chromium.org/viewvc/blink?view=rev&revision=151270
+
+ * fast/css-generated-content/quote-first-letter-crash-expected.txt: Added.
+ * fast/css-generated-content/quote-first-letter-crash.html: Added.
+
</ins><span class="cx"> 2014-04-01 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> Do not allow HTTP refresh headers to refresh to javascript: URLs
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestsfastcssgeneratedcontentquotefirstlettercrashexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/fast/css-generated-content/quote-first-letter-crash-expected.txt (0 => 168274)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/fast/css-generated-content/quote-first-letter-crash-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/fast/css-generated-content/quote-first-letter-crash-expected.txt 2014-05-05 10:30:44 UTC (rev 168274)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+PASS. Test didn't crash.
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestsfastcssgeneratedcontentquotefirstlettercrashhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/fast/css-generated-content/quote-first-letter-crash.html (0 => 168274)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/fast/css-generated-content/quote-first-letter-crash.html (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/fast/css-generated-content/quote-first-letter-crash.html 2014-05-05 10:30:44 UTC (rev 168274)
</span><span class="lines">@@ -0,0 +1,25 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<style>
+.class1::first-letter { position: inherit; }
+.class1:after { visibility: inherit; content: open-quote; }
+</style>
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+function crash() {
+ element1 = document.createElement('hr');
+ element1.setAttribute('class', 'class1');
+ document.documentElement.appendChild(element1);
+ element2 = document.createElement('td');
+ element2.setAttribute('class', 'class1');
+ document.documentElement.appendChild(element2);
+ document.documentElement.offsetTop;
+ document.open();
+ document.write("PASS. Test didn't crash.");
+ document.close();
+}
+window.onload = crash;
+</script>
+</html>
</ins><span class="cx">Property changes on: releases/WebKitGTK/webkit-2.4/LayoutTests/fast/css-generated-content/quote-first-letter-crash.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="releasesWebKitGTKwebkit24SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog (168273 => 168274)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-05-05 10:27:19 UTC (rev 168273)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-05-05 10:30:44 UTC (rev 168274)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2014-04-01 Daniel Bates <dabates@apple.com>
+
+ RenderQuote must destroy remaining text renderer before first letter renderer
+ https://bugs.webkit.org/show_bug.cgi?id=78023
+ <rdar://problem/10830009>
+
+ Reviewed by Brent Fulgham.
+
+ Merged from Blink (patch by Abhishek Arya):
+ https://src.chromium.org/viewvc/blink?view=rev&revision=151270
+
+ Following the fix for <https://bugs.webkit.org/show_bug.cgi?id=114586>, a
+ RenderQuote may have child render objects for the first letter of its text
+ and everything following the first letter so as to support the CSS first-
+ letter property. The latter renderer is responsible for destroying the former
+ on destruction. It's sufficient to reverse the destruction of the children of
+ RenderQuote to ensure that we destroy the remaining text renderer before we
+ destroy the first letter renderer.
+
+ Test: fast/css-generated-content/quote-first-letter-crash.html
+
+ * rendering/RenderQuote.cpp:
+ (WebCore::RenderQuote::updateText):
+
</ins><span class="cx"> 2014-04-01 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> Do not allow HTTP refresh headers to refresh to javascript: URLs
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCorerenderingRenderQuotecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderQuote.cpp (168273 => 168274)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderQuote.cpp 2014-05-05 10:27:19 UTC (rev 168273)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/RenderQuote.cpp 2014-05-05 10:30:44 UTC (rev 168274)
</span><span class="lines">@@ -343,7 +343,7 @@
</span><span class="cx"> if (m_text == text)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- while (RenderObject* child = firstChild())
</del><ins>+ while (RenderObject* child = lastChild())
</ins><span class="cx"> child->destroy();
</span><span class="cx">
</span><span class="cx"> if (text == emptyString() || text == String()) {
</span></span></pre>
</div>
</div>
</body>
</html>