<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168317] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168317">168317</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-05 14:23:37 -0700 (Mon, 05 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Cocoa WebKit2] Add SPI to clear all visited links in a VisitedLinkProvider
https://bugs.webkit.org/show_bug.cgi?id=132573
Patch by Sam Weinig <sam@webkit.org> on 2014-05-05
Reviewed by Dan Bernstein.
* Shared/VisitedLinkTable.cpp:
(WebKit::VisitedLinkTable::VisitedLinkTable):
(WebKit::VisitedLinkTable::clear):
* Shared/VisitedLinkTable.h:
Add functions to clear the visited link table.
* UIProcess/API/Cocoa/_WKVisitedLinkProvider.h:
* UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm:
(-[_WKVisitedLinkProvider removeAll]):
Add SPI.
* UIProcess/VisitedLinkProvider.cpp:
(WebKit::VisitedLinkProvider::removeAll):
* UIProcess/VisitedLinkProvider.h:
A remove all resets the provider and notifies all the attached processes.
* WebProcess/WebPage/VisitedLinkTableController.cpp:
(WebKit::VisitedLinkTableController::removeAllVisitedLinks):
* WebProcess/WebPage/VisitedLinkTableController.h:
* WebProcess/WebPage/VisitedLinkTableController.messages.in:
Add message to clear the visited links for a process.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedVisitedLinkTablecpp">trunk/Source/WebKit2/Shared/VisitedLinkTable.cpp</a></li>
<li><a href="#trunkSourceWebKit2SharedVisitedLinkTableh">trunk/Source/WebKit2/Shared/VisitedLinkTable.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoa_WKVisitedLinkProviderh">trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkProvider.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoa_WKVisitedLinkProvidermm">trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessVisitedLinkProvidercpp">trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessVisitedLinkProviderh">trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageVisitedLinkTableControllercpp">trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageVisitedLinkTableControllerh">trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageVisitedLinkTableControllermessagesin">trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.messages.in</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (168316 => 168317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-05-05 21:13:22 UTC (rev 168316)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-05 21:23:37 UTC (rev 168317)
</span><span class="lines">@@ -1,3 +1,32 @@
</span><ins>+2014-05-05 Sam Weinig <sam@webkit.org>
+
+ [Cocoa WebKit2] Add SPI to clear all visited links in a VisitedLinkProvider
+ https://bugs.webkit.org/show_bug.cgi?id=132573
+
+ Reviewed by Dan Bernstein.
+
+ * Shared/VisitedLinkTable.cpp:
+ (WebKit::VisitedLinkTable::VisitedLinkTable):
+ (WebKit::VisitedLinkTable::clear):
+ * Shared/VisitedLinkTable.h:
+ Add functions to clear the visited link table.
+
+ * UIProcess/API/Cocoa/_WKVisitedLinkProvider.h:
+ * UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm:
+ (-[_WKVisitedLinkProvider removeAll]):
+ Add SPI.
+
+ * UIProcess/VisitedLinkProvider.cpp:
+ (WebKit::VisitedLinkProvider::removeAll):
+ * UIProcess/VisitedLinkProvider.h:
+ A remove all resets the provider and notifies all the attached processes.
+
+ * WebProcess/WebPage/VisitedLinkTableController.cpp:
+ (WebKit::VisitedLinkTableController::removeAllVisitedLinks):
+ * WebProcess/WebPage/VisitedLinkTableController.h:
+ * WebProcess/WebPage/VisitedLinkTableController.messages.in:
+ Add message to clear the visited links for a process.
+
</ins><span class="cx"> 2014-05-05 Benjamin Poulain <benjamin@webkit.org>
</span><span class="cx">
</span><span class="cx"> [iOS][WK2] Special case ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture() for image documents
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedVisitedLinkTablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/VisitedLinkTable.cpp (168316 => 168317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/VisitedLinkTable.cpp 2014-05-05 21:13:22 UTC (rev 168316)
+++ trunk/Source/WebKit2/Shared/VisitedLinkTable.cpp 2014-05-05 21:23:37 UTC (rev 168317)
</span><span class="lines">@@ -34,7 +34,8 @@
</span><span class="cx">
</span><span class="cx"> VisitedLinkTable::VisitedLinkTable()
</span><span class="cx"> : m_tableSize(0)
</span><del>- , m_table(0)
</del><ins>+ , m_tableSizeMask(0)
+ , m_table(nullptr)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -136,4 +137,11 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void VisitedLinkTable::clear()
+{
+ m_tableSize = 0;
+ m_tableSizeMask = 0;
+ m_sharedMemory = nullptr;
+}
+
</ins><span class="cx"> } // namespace WebKit
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedVisitedLinkTableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/VisitedLinkTable.h (168316 => 168317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/VisitedLinkTable.h 2014-05-05 21:13:22 UTC (rev 168316)
+++ trunk/Source/WebKit2/Shared/VisitedLinkTable.h 2014-05-05 21:23:37 UTC (rev 168317)
</span><span class="lines">@@ -47,6 +47,7 @@
</span><span class="cx"> bool isLinkVisited(WebCore::LinkHash) const;
</span><span class="cx">
</span><span class="cx"> SharedMemory* sharedMemory() const { return m_sharedMemory.get(); }
</span><ins>+ void clear();
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> RefPtr<SharedMemory> m_sharedMemory;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoa_WKVisitedLinkProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkProvider.h (168316 => 168317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkProvider.h 2014-05-05 21:13:22 UTC (rev 168316)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkProvider.h 2014-05-05 21:23:37 UTC (rev 168317)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> @interface _WKVisitedLinkProvider : NSObject
</span><span class="cx">
</span><span class="cx"> - (void)addVisitedLinkWithURL:(NSURL *)URL;
</span><ins>+- (void)removeAll;
</ins><span class="cx">
</span><span class="cx"> @end
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoa_WKVisitedLinkProvidermm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm (168316 => 168317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm 2014-05-05 21:13:22 UTC (rev 168316)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm 2014-05-05 21:23:37 UTC (rev 168317)
</span><span class="lines">@@ -50,6 +50,11 @@
</span><span class="cx"> _visitedLinkProvider->addVisitedLinkHash(linkHash);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (void)removeAll
+{
+ _visitedLinkProvider->removeAll();
+}
+
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessVisitedLinkProvidercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.cpp (168316 => 168317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.cpp 2014-05-05 21:13:22 UTC (rev 168316)
+++ trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.cpp 2014-05-05 21:23:37 UTC (rev 168317)
</span><span class="lines">@@ -89,6 +89,18 @@
</span><span class="cx"> process.removeMessageReceiver(Messages::VisitedLinkProvider::messageReceiverName(), m_identifier);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void VisitedLinkProvider::removeAll()
+{
+ m_pendingVisitedLinksTimer.stop();
+ m_pendingVisitedLinks.clear();
+ m_keyCount = 0;
+ m_tableSize = 0;
+ m_table.clear();
+
+ for (auto& processAndCount : m_processes)
+ processAndCount.key->connection()->send(Messages::VisitedLinkTableController::RemoveAllVisitedLinks(), m_identifier);
+}
+
</ins><span class="cx"> void VisitedLinkProvider::addVisitedLinkHash(LinkHash linkHash)
</span><span class="cx"> {
</span><span class="cx"> m_pendingVisitedLinks.add(linkHash);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessVisitedLinkProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.h (168316 => 168317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.h 2014-05-05 21:13:22 UTC (rev 168316)
+++ trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.h 2014-05-05 21:23:37 UTC (rev 168317)
</span><span class="lines">@@ -52,6 +52,7 @@
</span><span class="cx"> void removeProcess(WebProcessProxy&);
</span><span class="cx">
</span><span class="cx"> void addVisitedLinkHash(WebCore::LinkHash);
</span><ins>+ void removeAll();
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> VisitedLinkProvider();
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageVisitedLinkTableControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp (168316 => 168317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp 2014-05-05 21:13:22 UTC (rev 168316)
+++ trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp 2014-05-05 21:23:37 UTC (rev 168317)
</span><span class="lines">@@ -113,4 +113,12 @@
</span><span class="cx"> pageCache()->markPagesForVistedLinkStyleRecalc();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void VisitedLinkTableController::removeAllVisitedLinks()
+{
+ m_visitedLinkTable.clear();
+
+ invalidateStylesForAllLinks();
+ pageCache()->markPagesForVistedLinkStyleRecalc();
+}
+
</ins><span class="cx"> } // namespace WebKit
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageVisitedLinkTableControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.h (168316 => 168317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.h 2014-05-05 21:13:22 UTC (rev 168316)
+++ trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.h 2014-05-05 21:23:37 UTC (rev 168317)
</span><span class="lines">@@ -51,6 +51,7 @@
</span><span class="cx"> void setVisitedLinkTable(const SharedMemory::Handle&);
</span><span class="cx"> void visitedLinkStateChanged(const Vector<WebCore::LinkHash>&);
</span><span class="cx"> void allVisitedLinkStateChanged();
</span><ins>+ void removeAllVisitedLinks();
</ins><span class="cx">
</span><span class="cx"> uint64_t m_identifier;
</span><span class="cx"> VisitedLinkTable m_visitedLinkTable;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageVisitedLinkTableControllermessagesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.messages.in (168316 => 168317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.messages.in 2014-05-05 21:13:22 UTC (rev 168316)
+++ trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.messages.in 2014-05-05 21:23:37 UTC (rev 168317)
</span><span class="lines">@@ -24,4 +24,5 @@
</span><span class="cx"> SetVisitedLinkTable(WebKit::SharedMemory::Handle handle)
</span><span class="cx"> VisitedLinkStateChanged(Vector<WebCore::LinkHash> linkHashes)
</span><span class="cx"> AllVisitedLinkStateChanged()
</span><ins>+ RemoveAllVisitedLinks()
</ins><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>