<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168264] releases/WebKitGTK/webkit-2.4</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168264">168264</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-05-05 01:01:21 -0700 (Mon, 05 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/166236">r166236</a> - Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
<http://webkit.org/b/130713>
<rdar://problem/15661876>
Reviewed by Darin Adler.
Merged from Blink (patch by Ian Beer):
http://crbug.com/303657
https://src.chromium.org/viewvc/blink?view=rev&revision=158938
Source/WebCore:
Test: fast/forms/form-submission-crash-successful-submit-button.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
LayoutTests:
* fast/forms/form-submission-crash-successful-submit-button-expected.txt: Added.
* fast/forms/form-submission-crash-successful-submit-button.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCorehtmlHTMLFormElementcpp">releases/WebKitGTK/webkit-2.4/Source/WebCore/html/HTMLFormElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrashsuccessfulsubmitbuttonexpectedtxt">releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-successful-submit-button-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrashsuccessfulsubmitbuttonhtml">releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-successful-submit-button.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit24LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog (168263 => 168264)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-05-05 08:01:13 UTC (rev 168263)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-05-05 08:01:21 UTC (rev 168264)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-03-25 David Kilzer <ddkilzer@apple.com>
+
+ Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
+ <http://webkit.org/b/130713>
+ <rdar://problem/15661876>
+
+ Reviewed by Darin Adler.
+
+ Merged from Blink (patch by Ian Beer):
+ http://crbug.com/303657
+ https://src.chromium.org/viewvc/blink?view=rev&revision=158938
+
+ * fast/forms/form-submission-crash-successful-submit-button-expected.txt: Added.
+ * fast/forms/form-submission-crash-successful-submit-button.html: Added.
+
</ins><span class="cx"> 2014-03-21 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> HTMLFrameOwnerElement should obey the SubframeLoadingDisabler when creating subframes
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrashsuccessfulsubmitbuttonexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-successful-submit-button-expected.txt (0 => 168264)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-successful-submit-button-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-successful-submit-button-expected.txt 2014-05-05 08:01:21 UTC (rev 168264)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+PASS if not crashed.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestsfastformsformsubmissioncrashsuccessfulsubmitbuttonhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-successful-submit-button.html (0 => 168264)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-successful-submit-button.html (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/fast/forms/form-submission-crash-successful-submit-button.html 2014-05-05 08:01:21 UTC (rev 168264)
</span><span class="lines">@@ -0,0 +1,37 @@
</span><ins>+<!DOCTYPE html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+jsTestIsAsync = true;
+var form1;
+var submit1;
+
+function start() {
+ form1 = document.createElement('form');
+ submit1 = document.createElement('input');
+ submit2 = document.createElement('input');
+ submit1.type = 'submit';
+ submit2.type = 'image';
+ form1.addEventListener('submit', handleSubmit, false);
+ form1.action = 'javascript:removeImage()';
+ form1.appendChild(submit1);
+ form1.appendChild(submit2);
+ submit1.click();
+ testPassed('if not crashed.');
+ finishJSTest();
+}
+
+function handleSubmit() {
+ form1.removeChild(submit1);
+}
+
+function removeImage() {
+ form1.removeChild(submit2);
+ submit2 = null;
+ gc();
+}
+
+window.onload = start;
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog (168263 => 168264)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-05-05 08:01:13 UTC (rev 168263)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-05-05 08:01:21 UTC (rev 168264)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-03-25 David Kilzer <ddkilzer@apple.com>
+
+ Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
+ <http://webkit.org/b/130713>
+ <rdar://problem/15661876>
+
+ Reviewed by Darin Adler.
+
+ Merged from Blink (patch by Ian Beer):
+ http://crbug.com/303657
+ https://src.chromium.org/viewvc/blink?view=rev&revision=158938
+
+ Test: fast/forms/form-submission-crash-successful-submit-button.html
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::submit):
+
</ins><span class="cx"> 2014-03-21 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> HTMLFrameOwnerElement should obey the SubframeLoadingDisabler when creating subframes
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCorehtmlHTMLFormElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/html/HTMLFormElement.cpp (168263 => 168264)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/html/HTMLFormElement.cpp 2014-05-05 08:01:13 UTC (rev 168263)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/html/HTMLFormElement.cpp 2014-05-05 08:01:21 UTC (rev 168264)
</span><span class="lines">@@ -333,7 +333,7 @@
</span><span class="cx"> m_isSubmittingOrPreparingForSubmission = true;
</span><span class="cx"> m_wasUserSubmitted = processingUserGesture;
</span><span class="cx">
</span><del>- HTMLFormControlElement* firstSuccessfulSubmitButton = 0;
</del><ins>+ RefPtr<HTMLFormControlElement> firstSuccessfulSubmitButton;
</ins><span class="cx"> bool needButtonActivation = activateSubmitButton; // do we need to activate a submit button?
</span><span class="cx">
</span><span class="cx"> for (unsigned i = 0; i < m_associatedElements.size(); ++i) {
</span></span></pre>
</div>
</div>
</body>
</html>