<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168306] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168306">168306</a></dd>
<dt>Author</dt> <dd>stavila@adobe.com</dd>
<dt>Date</dt> <dd>2014-05-05 11:49:54 -0700 (Mon, 05 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Regions] Remove regionLayoutUpdate event
https://bugs.webkit.org/show_bug.cgi?id=132564
Reviewed by Simon Fraser.
Source/WebCore:
The regionLayoutUpdate event was removed from the regions spec and was replaced by two other events:
regionOversetChange and regionFragmentChange.
No new tests needed, this patch removes a feature.
* dom/EventNames.h:
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent): Deleted.
* dom/WebKitNamedFlow.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::resetNonPersistentData):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask): Deleted.
(WebCore::UpdateRegionLayoutTask::scheduleFor): Deleted.
(WebCore::UpdateRegionLayoutTask::unschedule): Deleted.
(WebCore::UpdateRegionLayoutTask::reset): Deleted.
(WebCore::UpdateRegionLayoutTask::timerFired): Deleted.
(WebCore::InspectorCSSAgent::didUpdateRegionLayout): Deleted.
(WebCore::InspectorCSSAgent::regionLayoutUpdated): Deleted.
* inspector/InspectorCSSAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl): Deleted.
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didUpdateRegionLayout): Deleted.
* inspector/protocol/CSS.json:
* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::updateOversetState):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::layout):
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEventIfNeeded): Deleted.
(WebCore::RenderNamedFlowThread::regionLayoutUpdateEventTimerFired): Deleted.
* rendering/RenderNamedFlowThread.h:
Source/WebInspectorUI:
The regionLayoutUpdate event was removed from the regions spec and was replaced by two other events:
regionOversetChange and regionFragmentChange.
* UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype.get regionLayoutUpdated): Deleted.
* UserInterface/Models/ScriptTimelineRecord.js:
* UserInterface/Protocol/CSSObserver.js:
(WebInspector.CSSObserver.prototype.regionLayoutUpdated): Deleted.
* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-7.0.json:
LayoutTests:
Removed test for regionLayoutUpdate event.
* fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt: Removed.
* fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomEventNamesh">trunk/Source/WebCore/dom/EventNames.h</a></li>
<li><a href="#trunkSourceWebCoredomWebKitNamedFlowcpp">trunk/Source/WebCore/dom/WebKitNamedFlow.cpp</a></li>
<li><a href="#trunkSourceWebCoredomWebKitNamedFlowh">trunk/Source/WebCore/dom/WebKitNamedFlow.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorCSSAgentcpp">trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorCSSAgenth">trunk/Source/WebCore/inspector/InspectorCSSAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInstrumentationcpp">trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInstrumentationh">trunk/Source/WebCore/inspector/InspectorInstrumentation.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorprotocolCSSjson">trunk/Source/WebCore/inspector/protocol/CSS.json</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderNamedFlowFragmentcpp">trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderNamedFlowThreadcpp">trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderNamedFlowThreadh">trunk/Source/WebCore/rendering/RenderNamedFlowThread.h</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersDOMTreeManagerjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsScriptTimelineRecordjs">trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolCSSObserverjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolLegacy70InspectorWebBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS70json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastregionsautosizeautoheightregionlayoutupdatemultipletimesexpectedtxt">trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastregionsautosizeautoheightregionlayoutupdatemultipletimeshtml">trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/LayoutTests/ChangeLog 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-05-05 Radu Stavila <stavila@adobe.com>
+
+ [CSS Regions] Remove regionLayoutUpdate event
+ https://bugs.webkit.org/show_bug.cgi?id=132564
+
+ Reviewed by Simon Fraser.
+
+ Removed test for regionLayoutUpdate event.
+
+ * fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt: Removed.
+ * fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html: Removed.
+
</ins><span class="cx"> 2014-05-05 Rik Cabanier <cabanier@adobe.com>
</span><span class="cx">
</span><span class="cx"> Enhance IDL compiler so it supports unrestricted float and double
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsautosizeautoheightregionlayoutupdatemultipletimesexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -1,10 +0,0 @@
</span><del>-Test for WebKitBug 102101 [CSS Regions] regionlayoutupdate event fires continuously
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS The regionlayoutupdate fired only once.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastregionsautosizeautoheightregionlayoutupdatemultipletimeshtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/LayoutTests/fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -1,65 +0,0 @@
</span><del>-<!doctype html>
-<html>
- <head>
- <script src="../../../resources/js-test-pre.js"></script>
- <script src="../resources/helper.js"></script>
- <style>
- .notVisible { visibility: hidden; }
- .flow { -webkit-flow-into: flow; }
- #article { width: 50px; height: 50px; background-color: green; }
- #region { -webkit-flow-from: flow; }
- </style>
- </head>
- <body>
- <div id="eventCount"></div>
- <div id="article"></div>
- <div id="region"></div>
- <script>
- description("Test for WebKitBug 102101 [CSS Regions] regionlayoutupdate event fires continuously");
-
- if (window.testRunner) {
- window.testRunner.dumpAsText();
- window.testRunner.waitUntilDone();
- }
-
- window.jsTestIsAsync = true;
-
- var eventDispatchCount = 0;
- var timeoutID;
-
- function flowThreadUpdated(event) {
- if (++eventDispatchCount > 1) {
- endTest();
- return;
- }
-
- // Updating the content of eventCount element should not trigger a layout
- // on the auto-height region.
- document.getElementById("eventCount").textContent = eventDispatchCount;
- }
-
- function startTest() {
- getFlowByName("flow").addEventListener("webkitregionlayoutupdate", flowThreadUpdated);
- document.getElementById("article").className = "flow";
- timeoutID = window.setTimeout(endTest, 500);
- }
-
- function endTest() {
- window.clearTimeout(timeoutID);
- getFlowByName("flow").removeEventListener("webkitregionlayoutupdate", flowThreadUpdated);
-
- document.getElementById("eventCount").className = "notVisible";
- document.getElementById("region").className = "notVisible";
-
- if (eventDispatchCount > 1)
- debug("FAIL The regionlayoutupdate event fired twice instead of once.")
- else
- debug("PASS The regionlayoutupdate fired only once.");
- finishJSTest();
- }
-
- window.addEventListener("load", startTest);
-</script>
-<script src="../../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/ChangeLog 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -1,3 +1,45 @@
</span><ins>+2014-05-05 Radu Stavila <stavila@adobe.com>
+
+ [CSS Regions] Remove regionLayoutUpdate event
+ https://bugs.webkit.org/show_bug.cgi?id=132564
+
+ Reviewed by Simon Fraser.
+
+ The regionLayoutUpdate event was removed from the regions spec and was replaced by two other events:
+ regionOversetChange and regionFragmentChange.
+
+ No new tests needed, this patch removes a feature.
+
+ * dom/EventNames.h:
+ * dom/WebKitNamedFlow.cpp:
+ (WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent): Deleted.
+ * dom/WebKitNamedFlow.h:
+ * inspector/InspectorCSSAgent.cpp:
+ (WebCore::InspectorCSSAgent::resetNonPersistentData):
+ (WebCore::InspectorCSSAgent::willRemoveNamedFlow):
+ (WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask): Deleted.
+ (WebCore::UpdateRegionLayoutTask::scheduleFor): Deleted.
+ (WebCore::UpdateRegionLayoutTask::unschedule): Deleted.
+ (WebCore::UpdateRegionLayoutTask::reset): Deleted.
+ (WebCore::UpdateRegionLayoutTask::timerFired): Deleted.
+ (WebCore::InspectorCSSAgent::didUpdateRegionLayout): Deleted.
+ (WebCore::InspectorCSSAgent::regionLayoutUpdated): Deleted.
+ * inspector/InspectorCSSAgent.h:
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl): Deleted.
+ * inspector/InspectorInstrumentation.h:
+ (WebCore::InspectorInstrumentation::didUpdateRegionLayout): Deleted.
+ * inspector/protocol/CSS.json:
+ * rendering/RenderNamedFlowFragment.cpp:
+ (WebCore::RenderNamedFlowFragment::updateOversetState):
+ * rendering/RenderNamedFlowThread.cpp:
+ (WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
+ (WebCore::RenderNamedFlowThread::removeRegionFromThread):
+ (WebCore::RenderNamedFlowThread::layout):
+ (WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEventIfNeeded): Deleted.
+ (WebCore::RenderNamedFlowThread::regionLayoutUpdateEventTimerFired): Deleted.
+ * rendering/RenderNamedFlowThread.h:
+
</ins><span class="cx"> 2014-05-05 Rik Cabanier <cabanier@adobe.com>
</span><span class="cx">
</span><span class="cx"> Enhance IDL compiler so it supports unrestricted float and double
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventNamesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventNames.h (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventNames.h 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/dom/EventNames.h 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -261,8 +261,6 @@
</span><span class="cx"> macro(webkitpointerlockchange) \
</span><span class="cx"> macro(webkitpointerlockerror) \
</span><span class="cx"> \
</span><del>- macro(webkitregionlayoutupdate) \
- \
</del><span class="cx"> macro(webkitregionoversetchange) \
</span><span class="cx"> \
</span><span class="cx"> macro(webkitnetworkinfochange) \
</span></span></pre></div>
<a id="trunkSourceWebCoredomWebKitNamedFlowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/WebKitNamedFlow.cpp (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/WebKitNamedFlow.cpp 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/dom/WebKitNamedFlow.cpp 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -208,17 +208,6 @@
</span><span class="cx"> m_parentFlowThread = parentFlowThread;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebKitNamedFlow::dispatchRegionLayoutUpdateEvent()
-{
- ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden());
-
- // If the flow is in the "NULL" state the event should not be dispatched any more.
- if (flowState() == FlowStateNull)
- return;
-
- dispatchEvent(UIEvent::create(eventNames().webkitregionlayoutupdateEvent, false, false, m_flowManager->document()->defaultView(), 0));
-}
-
</del><span class="cx"> void WebKitNamedFlow::dispatchRegionOversetChangeEvent()
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden());
</span></span></pre></div>
<a id="trunkSourceWebCoredomWebKitNamedFlowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/WebKitNamedFlow.h (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/WebKitNamedFlow.h 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/dom/WebKitNamedFlow.h 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -78,7 +78,6 @@
</span><span class="cx">
</span><span class="cx"> FlowState flowState() const { return m_parentFlowThread ? FlowStateCreated : FlowStateNull; }
</span><span class="cx">
</span><del>- void dispatchRegionLayoutUpdateEvent();
</del><span class="cx"> void dispatchRegionOversetChangeEvent();
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorCSSAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -105,67 +105,6 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-class UpdateRegionLayoutTask {
-public:
- UpdateRegionLayoutTask(InspectorCSSAgent*);
- void scheduleFor(WebKitNamedFlow*, int documentNodeId);
- void unschedule(WebKitNamedFlow*);
- void reset();
- void timerFired(Timer<UpdateRegionLayoutTask>&);
-
-private:
- InspectorCSSAgent* m_cssAgent;
- Timer<UpdateRegionLayoutTask> m_timer;
- HashMap<WebKitNamedFlow*, int> m_namedFlows;
-};
-
-UpdateRegionLayoutTask::UpdateRegionLayoutTask(InspectorCSSAgent* cssAgent)
- : m_cssAgent(cssAgent)
- , m_timer(this, &UpdateRegionLayoutTask::timerFired)
-{
-}
-
-void UpdateRegionLayoutTask::scheduleFor(WebKitNamedFlow* namedFlow, int documentNodeId)
-{
- m_namedFlows.add(namedFlow, documentNodeId);
-
- if (!m_timer.isActive())
- m_timer.startOneShot(0);
-}
-
-void UpdateRegionLayoutTask::unschedule(WebKitNamedFlow* namedFlow)
-{
- m_namedFlows.remove(namedFlow);
-}
-
-void UpdateRegionLayoutTask::reset()
-{
- m_timer.stop();
- m_namedFlows.clear();
-}
-
-void UpdateRegionLayoutTask::timerFired(Timer<UpdateRegionLayoutTask>&)
-{
- // The timer is stopped on m_cssAgent destruction, so this method will never be called after m_cssAgent has been destroyed.
- Vector<std::pair<WebKitNamedFlow*, int>> namedFlows;
-
- for (HashMap<WebKitNamedFlow*, int>::iterator it = m_namedFlows.begin(), end = m_namedFlows.end(); it != end; ++it)
- namedFlows.append(std::make_pair(it->key, it->value));
-
- for (unsigned i = 0, size = namedFlows.size(); i < size; ++i) {
- WebKitNamedFlow* namedFlow = namedFlows.at(i).first;
- int documentNodeId = namedFlows.at(i).second;
-
- if (m_namedFlows.contains(namedFlow)) {
- m_cssAgent->regionLayoutUpdated(namedFlow, documentNodeId);
- m_namedFlows.remove(namedFlow);
- }
- }
-
- if (!m_namedFlows.isEmpty() && !m_timer.isActive())
- m_timer.startOneShot(0);
-}
-
</del><span class="cx"> class ChangeRegionOversetTask {
</span><span class="cx"> public:
</span><span class="cx"> ChangeRegionOversetTask(InspectorCSSAgent*);
</span><span class="lines">@@ -541,8 +480,6 @@
</span><span class="cx"> void InspectorCSSAgent::resetNonPersistentData()
</span><span class="cx"> {
</span><span class="cx"> m_namedFlowCollectionsRequested.clear();
</span><del>- if (m_updateRegionLayoutTask)
- m_updateRegionLayoutTask->reset();
</del><span class="cx"> if (m_changeRegionOversetTask)
</span><span class="cx"> m_changeRegionOversetTask->reset();
</span><span class="cx"> resetPseudoStates();
</span><span class="lines">@@ -580,37 +517,12 @@
</span><span class="cx"> if (!documentNodeId)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (m_updateRegionLayoutTask)
- m_updateRegionLayoutTask->unschedule(namedFlow);
-
</del><span class="cx"> if (m_changeRegionOversetTask)
</span><span class="cx"> m_changeRegionOversetTask->unschedule(namedFlow);
</span><span class="cx">
</span><span class="cx"> m_frontendDispatcher->namedFlowRemoved(documentNodeId, namedFlow->name().string());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorCSSAgent::didUpdateRegionLayout(Document* document, WebKitNamedFlow* namedFlow)
-{
- int documentNodeId = documentNodeWithRequestedFlowsId(document);
- if (!documentNodeId)
- return;
-
- if (!m_updateRegionLayoutTask)
- m_updateRegionLayoutTask = std::make_unique<UpdateRegionLayoutTask>(this);
- m_updateRegionLayoutTask->scheduleFor(namedFlow, documentNodeId);
-}
-
-void InspectorCSSAgent::regionLayoutUpdated(WebKitNamedFlow* namedFlow, int documentNodeId)
-{
- if (namedFlow->flowState() == WebKitNamedFlow::FlowStateNull)
- return;
-
- ErrorString errorString;
- Ref<WebKitNamedFlow> protect(*namedFlow);
-
- m_frontendDispatcher->regionLayoutUpdated(buildObjectForNamedFlow(&errorString, namedFlow, documentNodeId));
-}
-
</del><span class="cx"> void InspectorCSSAgent::didChangeRegionOverset(Document* document, WebKitNamedFlow* namedFlow)
</span><span class="cx"> {
</span><span class="cx"> int documentNodeId = documentNodeWithRequestedFlowsId(document);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorCSSAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorCSSAgent.h (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorCSSAgent.h 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/inspector/InspectorCSSAgent.h 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -60,7 +60,6 @@
</span><span class="cx"> class NodeList;
</span><span class="cx"> class StyleResolver;
</span><span class="cx"> class StyleRule;
</span><del>-class UpdateRegionLayoutTask;
</del><span class="cx"> class ChangeRegionOversetTask;
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INSPECTOR)
</span><span class="lines">@@ -105,8 +104,6 @@
</span><span class="cx"> void mediaQueryResultChanged();
</span><span class="cx"> void didCreateNamedFlow(Document*, WebKitNamedFlow*);
</span><span class="cx"> void willRemoveNamedFlow(Document*, WebKitNamedFlow*);
</span><del>- void didUpdateRegionLayout(Document*, WebKitNamedFlow*);
- void regionLayoutUpdated(WebKitNamedFlow*, int documentNodeId);
</del><span class="cx"> void didChangeRegionOverset(Document*, WebKitNamedFlow*);
</span><span class="cx"> void regionOversetChanged(WebKitNamedFlow*, int documentNodeId);
</span><span class="cx"> void didRegisterNamedFlowContentElement(Document*, WebKitNamedFlow*, Node* contentElement, Node* nextContentElement = nullptr);
</span><span class="lines">@@ -182,7 +179,6 @@
</span><span class="cx"> DocumentToViaInspectorStyleSheet m_documentToInspectorStyleSheet;
</span><span class="cx"> NodeIdToForcedPseudoState m_nodeIdToForcedPseudoState;
</span><span class="cx"> HashSet<int> m_namedFlowCollectionsRequested;
</span><del>- std::unique_ptr<UpdateRegionLayoutTask> m_updateRegionLayoutTask;
</del><span class="cx"> std::unique_ptr<ChangeRegionOversetTask> m_changeRegionOversetTask;
</span><span class="cx">
</span><span class="cx"> int m_lastStyleSheetId;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInstrumentationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -220,12 +220,6 @@
</span><span class="cx"> cssAgent->willRemoveNamedFlow(document, namedFlow);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorInstrumentation::didUpdateRegionLayoutImpl(InstrumentingAgents* instrumentingAgents, Document* document, WebKitNamedFlow* namedFlow)
-{
- if (InspectorCSSAgent* cssAgent = instrumentingAgents->inspectorCSSAgent())
- cssAgent->didUpdateRegionLayout(document, namedFlow);
-}
-
</del><span class="cx"> void InspectorInstrumentation::didChangeRegionOversetImpl(InstrumentingAgents* instrumentingAgents, Document* document, WebKitNamedFlow* namedFlow)
</span><span class="cx"> {
</span><span class="cx"> if (InspectorCSSAgent* cssAgent = instrumentingAgents->inspectorCSSAgent())
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInstrumentationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -127,7 +127,6 @@
</span><span class="cx"> static void willPopShadowRoot(Element* host, ShadowRoot*);
</span><span class="cx"> static void didCreateNamedFlow(Document*, WebKitNamedFlow*);
</span><span class="cx"> static void willRemoveNamedFlow(Document*, WebKitNamedFlow*);
</span><del>- static void didUpdateRegionLayout(Document*, WebKitNamedFlow*);
</del><span class="cx"> static void didChangeRegionOverset(Document*, WebKitNamedFlow*);
</span><span class="cx"> static void didRegisterNamedFlowContentElement(Document*, WebKitNamedFlow*, Node* contentElement, Node* nextContentElement = nullptr);
</span><span class="cx"> static void didUnregisterNamedFlowContentElement(Document*, WebKitNamedFlow*, Node* contentElement);
</span><span class="lines">@@ -326,7 +325,6 @@
</span><span class="cx"> static void willPopShadowRootImpl(InstrumentingAgents*, Element* host, ShadowRoot*);
</span><span class="cx"> static void didCreateNamedFlowImpl(InstrumentingAgents*, Document*, WebKitNamedFlow*);
</span><span class="cx"> static void willRemoveNamedFlowImpl(InstrumentingAgents*, Document*, WebKitNamedFlow*);
</span><del>- static void didUpdateRegionLayoutImpl(InstrumentingAgents*, Document*, WebKitNamedFlow*);
</del><span class="cx"> static void didChangeRegionOversetImpl(InstrumentingAgents*, Document*, WebKitNamedFlow*);
</span><span class="cx"> static void didRegisterNamedFlowContentElementImpl(InstrumentingAgents*, Document*, WebKitNamedFlow*, Node* contentElement, Node* nextContentElement = nullptr);
</span><span class="cx"> static void didUnregisterNamedFlowContentElementImpl(InstrumentingAgents*, Document*, WebKitNamedFlow*, Node* contentElement);
</span><span class="lines">@@ -690,18 +688,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline void InspectorInstrumentation::didUpdateRegionLayout(Document* document, WebKitNamedFlow* namedFlow)
-{
-#if ENABLE(INSPECTOR)
- FAST_RETURN_IF_NO_FRONTENDS(void());
- if (InstrumentingAgents* instrumentingAgents = instrumentingAgentsForDocument(document))
- didUpdateRegionLayoutImpl(instrumentingAgents, document, namedFlow);
-#else
- UNUSED_PARAM(document);
- UNUSED_PARAM(namedFlow);
-#endif
-}
-
</del><span class="cx"> inline void InspectorInstrumentation::didChangeRegionOverset(Document* document, WebKitNamedFlow* namedFlow)
</span><span class="cx"> {
</span><span class="cx"> #if ENABLE(INSPECTOR)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorprotocolCSSjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/protocol/CSS.json (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/protocol/CSS.json 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/inspector/protocol/CSS.json 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -401,13 +401,6 @@
</span><span class="cx"> "description": "Fires when a Named Flow is removed: has no associated content nodes and regions."
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "regionLayoutUpdated",
- "parameters": [
- { "name": "namedFlow", "$ref": "NamedFlow", "description": "The Named Flow whose layout may have changed." }
- ],
- "description": "Fires when a Named Flow's layout may have changed."
- },
- {
</del><span class="cx"> "name": "regionOversetChanged",
</span><span class="cx"> "parameters": [
</span><span class="cx"> { "name": "namedFlow", "$ref": "NamedFlow", "description": "The Named Flow containing the regions whose regionOverset values changed." }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderNamedFlowFragmentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowFragment.cpp 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -323,12 +323,7 @@
</span><span class="cx">
</span><span class="cx"> setRegionOversetState(state);
</span><span class="cx">
</span><del>- // Determine whether the NamedFlow object should dispatch a regionLayoutUpdate event
- if (previousState != state
- || state == RegionFit
- || state == RegionOverset)
- flowThread->setDispatchRegionLayoutUpdateEvent(true);
-
</del><ins>+ // Determine whether the NamedFlow object should dispatch a regionOversetChange event
</ins><span class="cx"> if (previousState != state)
</span><span class="cx"> flowThread->setDispatchRegionOversetChangeEvent(true);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderNamedFlowThreadcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -48,10 +48,8 @@
</span><span class="cx"> RenderNamedFlowThread::RenderNamedFlowThread(Document& document, PassRef<RenderStyle> style, PassRef<WebKitNamedFlow> namedFlow)
</span><span class="cx"> : RenderFlowThread(document, std::move(style))
</span><span class="cx"> , m_hasRegionsWithStyling(false)
</span><del>- , m_dispatchRegionLayoutUpdateEvent(false)
</del><span class="cx"> , m_dispatchRegionOversetChangeEvent(false)
</span><span class="cx"> , m_namedFlow(std::move(namedFlow))
</span><del>- , m_regionLayoutUpdateEventTimer(this, &RenderNamedFlowThread::regionLayoutUpdateEventTimerFired)
</del><span class="cx"> , m_regionOversetChangeEventTimer(this, &RenderNamedFlowThread::regionOversetChangeEventTimerFired)
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="lines">@@ -271,10 +269,7 @@
</span><span class="cx"> if (canBeDestroyed())
</span><span class="cx"> setMarkForDestruction();
</span><span class="cx">
</span><del>- // After removing all the regions in the flow the following layout needs to dispatch the regionLayoutUpdate event
- if (m_regionList.isEmpty())
- setDispatchRegionLayoutUpdateEvent(true);
- else if (wasFirst)
</del><ins>+ if (!m_regionList.isEmpty() && wasFirst)
</ins><span class="cx"> updateWritingMode();
</span><span class="cx">
</span><span class="cx"> invalidateRegions();
</span><span class="lines">@@ -416,8 +411,6 @@
</span><span class="cx"> setDispatchRegionOversetChangeEvent(true);
</span><span class="cx"> updatePreviousRegionCount();
</span><span class="cx"> }
</span><del>-
- dispatchRegionLayoutUpdateEventIfNeeded();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderNamedFlowThread::dispatchNamedFlowEvents()
</span><span class="lines">@@ -555,18 +548,6 @@
</span><span class="cx"> return toElement(originalParent)->renderer()->isChildAllowed(child, style);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderNamedFlowThread::dispatchRegionLayoutUpdateEventIfNeeded()
-{
- if (!m_dispatchRegionLayoutUpdateEvent)
- return;
-
- m_dispatchRegionLayoutUpdateEvent = false;
- InspectorInstrumentation::didUpdateRegionLayout(&document(), &namedFlow());
-
- if (!m_regionLayoutUpdateEventTimer.isActive() && namedFlow().hasEventListeners())
- m_regionLayoutUpdateEventTimer.startOneShot(0);
-}
-
</del><span class="cx"> void RenderNamedFlowThread::dispatchRegionOversetChangeEventIfNeeded()
</span><span class="cx"> {
</span><span class="cx"> if (!m_dispatchRegionOversetChangeEvent)
</span><span class="lines">@@ -579,11 +560,6 @@
</span><span class="cx"> m_regionOversetChangeEventTimer.startOneShot(0);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderNamedFlowThread::regionLayoutUpdateEventTimerFired(Timer<RenderNamedFlowThread>&)
-{
- namedFlow().dispatchRegionLayoutUpdateEvent();
-}
-
</del><span class="cx"> void RenderNamedFlowThread::regionOversetChangeEventTimerFired(Timer<RenderNamedFlowThread>&)
</span><span class="cx"> {
</span><span class="cx"> namedFlow().dispatchRegionOversetChangeEvent();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderNamedFlowThreadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderNamedFlowThread.h (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderNamedFlowThread.h 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowThread.h 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -96,7 +96,6 @@
</span><span class="cx"> LayoutUnit flowContentBottom() const { return m_flowContentBottom; }
</span><span class="cx"> void dispatchNamedFlowEvents();
</span><span class="cx">
</span><del>- void setDispatchRegionLayoutUpdateEvent(bool value) { m_dispatchRegionLayoutUpdateEvent = value; }
</del><span class="cx"> void setDispatchRegionOversetChangeEvent(bool value) { m_dispatchRegionOversetChangeEvent = value; }
</span><span class="cx">
</span><span class="cx"> virtual bool absoluteQuadsForBox(Vector<FloatQuad>&, bool*, const RenderBox*, float, float) const override;
</span><span class="lines">@@ -112,7 +111,6 @@
</span><span class="cx"> virtual void computeOverflow(LayoutUnit, bool = false) override;
</span><span class="cx"> virtual void layout() override final;
</span><span class="cx">
</span><del>- void dispatchRegionLayoutUpdateEventIfNeeded();
</del><span class="cx"> void dispatchRegionOversetChangeEventIfNeeded();
</span><span class="cx">
</span><span class="cx"> bool dependsOn(RenderNamedFlowThread* otherRenderFlowThread) const;
</span><span class="lines">@@ -124,7 +122,6 @@
</span><span class="cx"> void checkInvalidRegions();
</span><span class="cx">
</span><span class="cx"> bool canBeDestroyed() const { return m_invalidRegionList.isEmpty() && m_regionList.isEmpty() && m_contentElements.isEmpty(); }
</span><del>- void regionLayoutUpdateEventTimerFired(Timer<RenderNamedFlowThread>&);
</del><span class="cx"> void regionOversetChangeEventTimerFired(Timer<RenderNamedFlowThread>&);
</span><span class="cx"> void clearContentElements();
</span><span class="cx"> void updateWritingMode();
</span><span class="lines">@@ -150,13 +147,11 @@
</span><span class="cx"> RenderRegionList m_invalidRegionList;
</span><span class="cx">
</span><span class="cx"> bool m_hasRegionsWithStyling : 1;
</span><del>- bool m_dispatchRegionLayoutUpdateEvent : 1;
</del><span class="cx"> bool m_dispatchRegionOversetChangeEvent : 1;
</span><span class="cx">
</span><span class="cx"> // The DOM Object that represents a named flow.
</span><span class="cx"> Ref<WebKitNamedFlow> m_namedFlow;
</span><span class="cx">
</span><del>- Timer<RenderNamedFlowThread> m_regionLayoutUpdateEventTimer;
</del><span class="cx"> Timer<RenderNamedFlowThread> m_regionOversetChangeEventTimer;
</span><span class="cx">
</span><span class="cx"> LayoutUnit m_flowContentBottom;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-05-05 Radu Stavila <stavila@adobe.com>
+
+ [CSS Regions] Remove regionLayoutUpdate event
+ https://bugs.webkit.org/show_bug.cgi?id=132564
+
+ Reviewed by Simon Fraser.
+
+ The regionLayoutUpdate event was removed from the regions spec and was replaced by two other events:
+ regionOversetChange and regionFragmentChange.
+
+ * UserInterface/Controllers/DOMTreeManager.js:
+ (WebInspector.DOMTreeManager.prototype.get regionLayoutUpdated): Deleted.
+ * UserInterface/Models/ScriptTimelineRecord.js:
+ * UserInterface/Protocol/CSSObserver.js:
+ (WebInspector.CSSObserver.prototype.regionLayoutUpdated): Deleted.
+ * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
+ * Versions/Inspector-iOS-7.0.json:
+
</ins><span class="cx"> 2014-05-02 Jono Wells <jonowells@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: CodeMirror 4 CSS mode new state data structure breaks helpers.
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersDOMTreeManagerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -58,7 +58,6 @@
</span><span class="cx"> ContentFlowListWasUpdated: "dom-tree-manager-content-flow-list-was-updated",
</span><span class="cx"> ContentFlowWasAdded: "dom-tree-manager-content-flow-was-added",
</span><span class="cx"> ContentFlowWasRemoved: "dom-tree-manager-content-flow-was-removed",
</span><del>- RegionLayoutUpdated: "dom-tree-manager-region-layout-updated",
</del><span class="cx"> RegionOversetChanged: "dom-tree-manager-region-overset-changed"
</span><span class="cx"> };
</span><span class="cx">
</span><span class="lines">@@ -617,11 +616,6 @@
</span><span class="cx"> this._updateContentFlowFromPayload(this._flows.get(flowKey), flowPayload);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- regionLayoutUpdated: function(flowPayload)
- {
- this._sendNamedFlowUpdateEvents(flowPayload);
- },
-
</del><span class="cx"> regionOversetChanged: function(flowPayload)
</span><span class="cx"> {
</span><span class="cx"> this._sendNamedFlowUpdateEvents(flowPayload);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsScriptTimelineRecordjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -190,7 +190,6 @@
</span><span class="cx"> nameMap.set("webkitplaybacktargetavailabilitychanged", "Playback Target Availability Changed");
</span><span class="cx"> nameMap.set("webkitpointerlockchange", "Pointer Lock Change");
</span><span class="cx"> nameMap.set("webkitpointerlockerror", "Pointer Lock Error");
</span><del>- nameMap.set("webkitregionlayoutupdate", "Region Layout Update");
</del><span class="cx"> nameMap.set("webkitregionoversetchange", "Region Overset Change");
</span><span class="cx"> nameMap.set("webkitremovesourcebuffer", "Remove Source Buffer");
</span><span class="cx"> nameMap.set("webkitresourcetimingbufferfull", "Resource Timing Buffer Full");
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolCSSObserverjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -63,11 +63,6 @@
</span><span class="cx"> WebInspector.domTreeManager.namedFlowRemoved(documentNodeId, flowName);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- regionLayoutUpdated: function(namedFlow)
- {
- WebInspector.domTreeManager.regionLayoutUpdated(namedFlow);
- },
-
</del><span class="cx"> regionOversetChanged: function(namedFlow)
</span><span class="cx"> {
</span><span class="cx"> WebInspector.domTreeManager.regionOversetChanged(namedFlow);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolLegacy70InspectorWebBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -203,7 +203,6 @@
</span><span class="cx"> InspectorBackend.registerEvent("CSS.styleSheetChanged", ["styleSheetId"]);
</span><span class="cx"> InspectorBackend.registerEvent("CSS.namedFlowCreated", ["namedFlow"]);
</span><span class="cx"> InspectorBackend.registerEvent("CSS.namedFlowRemoved", ["documentNodeId", "flowName"]);
</span><del>-InspectorBackend.registerEvent("CSS.regionLayoutUpdated", ["namedFlow"]);
</del><span class="cx"> InspectorBackend.registerCommand("CSS.enable", [], []);
</span><span class="cx"> InspectorBackend.registerCommand("CSS.disable", [], []);
</span><span class="cx"> InspectorBackend.registerCommand("CSS.getMatchedStylesForNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "includePseudo", "type": "boolean", "optional": true}, {"name": "includeInherited", "type": "boolean", "optional": true}], ["matchedCSSRules", "pseudoElements", "inherited"]);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS70json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (168305 => 168306)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2014-05-05 18:44:59 UTC (rev 168305)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2014-05-05 18:49:54 UTC (rev 168306)
</span><span class="lines">@@ -2183,13 +2183,6 @@
</span><span class="cx"> { "name": "flowName", "type": "string", "description": "Identifier of the removed Named Flow." }
</span><span class="cx"> ],
</span><span class="cx"> "description": "Fires when a Named Flow is removed: has no associated content nodes and regions."
</span><del>- },
- {
- "name": "regionLayoutUpdated",
- "parameters": [
- { "name": "namedFlow", "$ref": "NamedFlow", "description": "The Named Flow whose layout may have changed." }
- ],
- "description": "Fires when a Named Flow's layout may have changed."
</del><span class="cx"> }
</span><span class="cx"> ]
</span><span class="cx"> },
</span></span></pre>
</div>
</div>
</body>
</html>