<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168230] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168230">168230</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-05-03 15:16:53 -0700 (Sat, 03 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Invalidate scrollbars when custom scrollbar style changes dynamically.
<https://webkit.org/b/132529>
Source/WebCore:
Add a ScrollView::styleDidChange() and call that from RenderView::styleDidChange()
so that the scrollbars are sure to get repainted with potentially different style.
Reviewed by Antti Koivisto.
Test: fast/css/scrollbar-dynamic-style-change.html
* platform/ScrollView.cpp:
(WebCore::ScrollView::styleDidChange):
* platform/ScrollView.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::styleDidChange):
LayoutTests:
Reviewed by Antti Koivisto.
* fast/css/scrollbar-dynamic-style-change-expected.html: Added.
* fast/css/scrollbar-dynamic-style-change.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformScrollViewcpp">trunk/Source/WebCore/platform/ScrollView.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformScrollViewh">trunk/Source/WebCore/platform/ScrollView.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderViewcpp">trunk/Source/WebCore/rendering/RenderView.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssscrollbardynamicstylechangeexpectedhtml">trunk/LayoutTests/fast/css/scrollbar-dynamic-style-change-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastcssscrollbardynamicstylechangehtml">trunk/LayoutTests/fast/css/scrollbar-dynamic-style-change.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (168229 => 168230)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-05-03 20:46:50 UTC (rev 168229)
+++ trunk/LayoutTests/ChangeLog 2014-05-03 22:16:53 UTC (rev 168230)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-05-03 Andreas Kling <akling@apple.com>
+
+ Invalidate scrollbars when custom scrollbar style changes dynamically.
+ <https://webkit.org/b/132529>
+
+ Reviewed by Antti Koivisto.
+
+ * fast/css/scrollbar-dynamic-style-change-expected.html: Added.
+ * fast/css/scrollbar-dynamic-style-change.html: Added.
+
</ins><span class="cx"> 2014-05-03 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> [UI-side compositing] Assertion in PlatformCAFilters::setFiltersOnLayer with animated reference filter
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssscrollbardynamicstylechangeexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/scrollbar-dynamic-style-change-expected.html (0 => 168230)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/scrollbar-dynamic-style-change-expected.html (rev 0)
+++ trunk/LayoutTests/fast/css/scrollbar-dynamic-style-change-expected.html 2014-05-03 22:16:53 UTC (rev 168230)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+<style>
+::-webkit-scrollbar {
+ background: green;
+}
+body {
+ overflow: scroll;
+}
+div {
+ overflow: scroll;
+ width: 200px;
+ height: 200px;
+}
+</style>
+<div></div>
+</script>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssscrollbardynamicstylechangehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/scrollbar-dynamic-style-change.html (0 => 168230)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/scrollbar-dynamic-style-change.html (rev 0)
+++ trunk/LayoutTests/fast/css/scrollbar-dynamic-style-change.html 2014-05-03 22:16:53 UTC (rev 168230)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+<style>
+::-webkit-scrollbar {
+ background: red;
+}
+body {
+ overflow: scroll;
+}
+div {
+ overflow: scroll;
+ width: 200px;
+ height: 200px;
+}
+</style>
+<div></div>
+<script>
+window.onload = function() {
+ document.body.offsetWidth;
+ document.styleSheets[0].cssRules[0].style.backgroundColor = 'green';
+}
+</script>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (168229 => 168230)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-03 20:46:50 UTC (rev 168229)
+++ trunk/Source/WebCore/ChangeLog 2014-05-03 22:16:53 UTC (rev 168230)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-05-03 Andreas Kling <akling@apple.com>
+
+ Invalidate scrollbars when custom scrollbar style changes dynamically.
+ <https://webkit.org/b/132529>
+
+ Add a ScrollView::styleDidChange() and call that from RenderView::styleDidChange()
+ so that the scrollbars are sure to get repainted with potentially different style.
+
+ Reviewed by Antti Koivisto.
+
+ Test: fast/css/scrollbar-dynamic-style-change.html
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::styleDidChange):
+ * platform/ScrollView.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::styleDidChange):
+
</ins><span class="cx"> 2014-05-03 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Very fuzzy layers under non-decompasable matrices
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformScrollViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ScrollView.cpp (168229 => 168230)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ScrollView.cpp 2014-05-03 20:46:50 UTC (rev 168229)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2014-05-03 22:16:53 UTC (rev 168230)
</span><span class="lines">@@ -1459,6 +1459,15 @@
</span><span class="cx"> updateScrollbars(scrollOffset());
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void ScrollView::styleDidChange()
+{
+ if (m_horizontalScrollbar)
+ m_horizontalScrollbar->styleChanged();
+
+ if (m_verticalScrollbar)
+ m_verticalScrollbar->styleChanged();
+}
+
</ins><span class="cx"> #if !PLATFORM(COCOA)
</span><span class="cx">
</span><span class="cx"> void ScrollView::platformAddChild(Widget*)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformScrollViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ScrollView.h (168229 => 168230)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ScrollView.h 2014-05-03 20:46:50 UTC (rev 168229)
+++ trunk/Source/WebCore/platform/ScrollView.h 2014-05-03 22:16:53 UTC (rev 168230)
</span><span class="lines">@@ -144,6 +144,8 @@
</span><span class="cx"> // Overridden by FrameView to create custom CSS scrollbars if applicable.
</span><span class="cx"> virtual PassRefPtr<Scrollbar> createScrollbar(ScrollbarOrientation);
</span><span class="cx">
</span><ins>+ void styleDidChange();
+
</ins><span class="cx"> // If the prohibits scrolling flag is set, then all scrolling in the view (even programmatic scrolling) is turned off.
</span><span class="cx"> void setProhibitsScrolling(bool b) { m_prohibitsScrolling = b; }
</span><span class="cx"> bool prohibitsScrolling() const { return m_prohibitsScrolling; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderView.cpp (168229 => 168230)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderView.cpp 2014-05-03 20:46:50 UTC (rev 168229)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2014-05-03 22:16:53 UTC (rev 168230)
</span><span class="lines">@@ -1260,6 +1260,8 @@
</span><span class="cx"> RenderBlockFlow::styleDidChange(diff, oldStyle);
</span><span class="cx"> if (hasRenderNamedFlowThreads())
</span><span class="cx"> flowThreadController().styleDidChange();
</span><ins>+
+ frameView().styleDidChange();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool RenderView::hasRenderNamedFlowThreads() const
</span></span></pre>
</div>
</div>
</body>
</html>