<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168209] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168209">168209</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-05-02 16:57:54 -0700 (Fri, 02 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove HistogramSupport.
<https://webkit.org/b/132354>
Prune some leftover Chromium gunk that no other ports ever used.
Reviewed by Simon Fraser.
* CMakeLists.txt:
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
* Modules/indexeddb/IDBHistograms.h: Removed.
* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::open):
(WebCore::IDBBackingStoreLevelDB::openInMemory):
(WebCore::recordInternalError): Deleted.
* Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSParser.cpp:
(WebCore::cssPropertyID):
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::histogramMutationEventUsage): Deleted.
* dom/ShadowRoot.cpp:
* fileapi/Blob.cpp:
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::append):
* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
* platform/HistogramSupport.cpp: Removed.
* platform/HistogramSupport.h: Removed.
* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::open):
(WebCore::histogramLevelDBError): Deleted.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateNeedsCompositedScrolling):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBDatabasecpp">trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBFactorycpp">trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbleveldbIDBBackingStoreLevelDBcpp">trunk/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbleveldbIDBBackingStoreTransactionLevelDBcpp">trunk/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp</a></li>
<li><a href="#trunkSourceWebCoreWebCorevcxprojWebCorevcxproj">trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj</a></li>
<li><a href="#trunkSourceWebCoreWebCorevcxprojWebCorevcxprojfilters">trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCorecssCSSParsercpp">trunk/Source/WebCore/css/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomShadowRootcpp">trunk/Source/WebCore/dom/ShadowRoot.cpp</a></li>
<li><a href="#trunkSourceWebCorefileapiBlobcpp">trunk/Source/WebCore/fileapi/Blob.cpp</a></li>
<li><a href="#trunkSourceWebCorefileapiWebKitBlobBuildercpp">trunk/Source/WebCore/fileapi/WebKitBlobBuilder.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryPageCachecpp">trunk/Source/WebCore/history/PageCache.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformleveldbLevelDBDatabasecpp">trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXMLHttpRequestcpp">trunk/Source/WebCore/xml/XMLHttpRequest.cpp</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBHistogramsh">trunk/Source/WebCore/Modules/indexeddb/IDBHistograms.h</a></li>
<li><a href="#trunkSourceWebCoreplatformHistogramSupportcpp">trunk/Source/WebCore/platform/HistogramSupport.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformHistogramSupporth">trunk/Source/WebCore/platform/HistogramSupport.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/CMakeLists.txt (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/CMakeLists.txt 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/CMakeLists.txt 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -1952,7 +1952,6 @@
</span><span class="cx"> platform/FileChooser.cpp
</span><span class="cx"> platform/FileStream.cpp
</span><span class="cx"> platform/FileSystem.cpp
</span><del>- platform/HistogramSupport.cpp
</del><span class="cx"> platform/URL.cpp
</span><span class="cx"> platform/KillRingNone.cpp
</span><span class="cx"> platform/Language.cpp
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/ChangeLog 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -1,3 +1,51 @@
</span><ins>+2014-05-02 Andreas Kling <akling@apple.com>
+
+ Remove HistogramSupport.
+ <https://webkit.org/b/132354>
+
+ Prune some leftover Chromium gunk that no other ports ever used.
+
+ Reviewed by Simon Fraser.
+
+ * CMakeLists.txt:
+ * Modules/indexeddb/IDBDatabase.cpp:
+ (WebCore::IDBDatabase::createObjectStore):
+ (WebCore::IDBDatabase::deleteObjectStore):
+ (WebCore::IDBDatabase::transaction):
+ * Modules/indexeddb/IDBFactory.cpp:
+ (WebCore::IDBFactory::openInternal):
+ (WebCore::IDBFactory::deleteDatabase):
+ * Modules/indexeddb/IDBHistograms.h: Removed.
+ * Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
+ (WebCore::IDBBackingStoreLevelDB::open):
+ (WebCore::IDBBackingStoreLevelDB::openInMemory):
+ (WebCore::recordInternalError): Deleted.
+ * Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp:
+ * WebCore.vcxproj/WebCore.vcxproj:
+ * WebCore.vcxproj/WebCore.vcxproj.filters:
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSParser.cpp:
+ (WebCore::cssPropertyID):
+ * dom/Document.cpp:
+ (WebCore::Document::~Document):
+ (WebCore::histogramMutationEventUsage): Deleted.
+ * dom/ShadowRoot.cpp:
+ * fileapi/Blob.cpp:
+ * fileapi/WebKitBlobBuilder.cpp:
+ (WebCore::BlobBuilder::append):
+ * history/PageCache.cpp:
+ (WebCore::logCanCacheFrameDecision):
+ (WebCore::logCanCachePageDecision):
+ * platform/HistogramSupport.cpp: Removed.
+ * platform/HistogramSupport.h: Removed.
+ * platform/leveldb/LevelDBDatabase.cpp:
+ (WebCore::LevelDBDatabase::open):
+ (WebCore::histogramLevelDBError): Deleted.
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateNeedsCompositedScrolling):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::send):
+
</ins><span class="cx"> 2014-05-02 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Stop flipping the ImageControlsButton
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBDatabasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -31,13 +31,11 @@
</span><span class="cx"> #include "DOMStringList.h"
</span><span class="cx"> #include "EventQueue.h"
</span><span class="cx"> #include "ExceptionCode.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "IDBAny.h"
</span><span class="cx"> #include "IDBDatabaseCallbacks.h"
</span><span class="cx"> #include "IDBDatabaseError.h"
</span><span class="cx"> #include "IDBDatabaseException.h"
</span><span class="cx"> #include "IDBEventDispatcher.h"
</span><del>-#include "IDBHistograms.h"
</del><span class="cx"> #include "IDBIndex.h"
</span><span class="cx"> #include "IDBKeyPath.h"
</span><span class="cx"> #include "IDBObjectStore.h"
</span><span class="lines">@@ -161,7 +159,6 @@
</span><span class="cx"> PassRefPtr<IDBObjectStore> IDBDatabase::createObjectStore(const String& name, const IDBKeyPath& keyPath, bool autoIncrement, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> LOG(StorageAPI, "IDBDatabase::createObjectStore");
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.FrontEndAPICalls", IDBCreateObjectStoreCall, IDBMethodsMax);
</del><span class="cx"> if (!m_versionChangeTransaction) {
</span><span class="cx"> ec = IDBDatabaseException::InvalidStateError;
</span><span class="cx"> return 0;
</span><span class="lines">@@ -201,7 +198,6 @@
</span><span class="cx"> void IDBDatabase::deleteObjectStore(const String& name, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> LOG(StorageAPI, "IDBDatabase::deleteObjectStore");
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.FrontEndAPICalls", IDBDeleteObjectStoreCall, IDBMethodsMax);
</del><span class="cx"> if (!m_versionChangeTransaction) {
</span><span class="cx"> ec = IDBDatabaseException::InvalidStateError;
</span><span class="cx"> return;
</span><span class="lines">@@ -225,7 +221,6 @@
</span><span class="cx"> PassRefPtr<IDBTransaction> IDBDatabase::transaction(ScriptExecutionContext* context, const Vector<String>& scope, const String& modeString, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> LOG(StorageAPI, "IDBDatabase::transaction");
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.FrontEndAPICalls", IDBTransactionCall, IDBMethodsMax);
</del><span class="cx"> if (!scope.size()) {
</span><span class="cx"> ec = IDBDatabaseException::InvalidAccessError;
</span><span class="cx"> return 0;
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBFactorycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -35,13 +35,11 @@
</span><span class="cx"> #include "ExceptionCode.h"
</span><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "GroupSettings.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "IDBBindingUtilities.h"
</span><span class="cx"> #include "IDBDatabase.h"
</span><span class="cx"> #include "IDBDatabaseCallbacksImpl.h"
</span><span class="cx"> #include "IDBDatabaseException.h"
</span><span class="cx"> #include "IDBFactoryBackendInterface.h"
</span><del>-#include "IDBHistograms.h"
</del><span class="cx"> #include "IDBKey.h"
</span><span class="cx"> #include "IDBKeyRange.h"
</span><span class="cx"> #include "IDBOpenDBRequest.h"
</span><span class="lines">@@ -124,7 +122,6 @@
</span><span class="cx">
</span><span class="cx"> PassRefPtr<IDBOpenDBRequest> IDBFactory::openInternal(ScriptExecutionContext* context, const String& name, uint64_t version, IndexedDB::VersionNullness versionNullness, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.FrontEndAPICalls", IDBOpenCall, IDBMethodsMax);
</del><span class="cx"> ASSERT(version >= 1 || versionNullness == IndexedDB::VersionNullness::Null);
</span><span class="cx"> if (name.isNull()) {
</span><span class="cx"> ec = TypeError;
</span><span class="lines">@@ -147,7 +144,6 @@
</span><span class="cx"> PassRefPtr<IDBOpenDBRequest> IDBFactory::deleteDatabase(ScriptExecutionContext* context, const String& name, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> LOG(StorageAPI, "IDBFactory::deleteDatabase");
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.FrontEndAPICalls", IDBDeleteDatabaseCall, IDBMethodsMax);
</del><span class="cx"> if (name.isNull()) {
</span><span class="cx"> ec = TypeError;
</span><span class="cx"> return 0;
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBHistogramsh"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/Modules/indexeddb/IDBHistograms.h (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBHistograms.h 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBHistograms.h 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -1,45 +0,0 @@
</span><del>-/*
- * Copyright (C) 2013 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- * 3. Neither the name of Apple Inc. ("Apple") nor the names of
- * its contributors may be used to endorse or promote products derived
- * from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY GOOGLE AND ITS CONTRIBUTORS "AS IS" AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef IDBHistograms_h
-#define IDBHistograms_h
-
-namespace WebCore {
-
-enum IndexedDatabaseMethods {
- IDBCreateObjectStoreCall,
- IDBDeleteObjectStoreCall,
- IDBTransactionCall,
- IDBDeleteDatabaseCall,
- IDBOpenCall,
- IDBMethodsMax,
-};
-
-}
-
-#endif
</del></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbleveldbIDBBackingStoreLevelDBcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -29,7 +29,6 @@
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE) && USE(LEVELDB)
</span><span class="cx">
</span><span class="cx"> #include "FileSystem.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "IDBDatabaseMetadata.h"
</span><span class="cx"> #include "IDBIndexWriterLevelDB.h"
</span><span class="cx"> #include "IDBKey.h"
</span><span class="lines">@@ -77,19 +76,12 @@
</span><span class="cx"> IDBLevelDBBackingStoreInternalErrorMax,
</span><span class="cx"> };
</span><span class="cx">
</span><del>-static void recordInternalError(const char* type, IDBBackingStoreLevelDBErrorSource location)
-{
- String name = String::format("WebCore.IndexedDB.BackingStore.%sError", type);
- HistogramSupport::histogramEnumeration(name.utf8().data(), location, IDBLevelDBBackingStoreInternalErrorMax);
-}
-
</del><span class="cx"> // Use to signal conditions that usually indicate developer error, but could be caused by data corruption.
</span><span class="cx"> // A macro is used instead of an inline function so that the assert and log report the line number.
</span><span class="cx"> #define REPORT_ERROR(type, location) \
</span><span class="cx"> do { \
</span><span class="cx"> LOG_ERROR("IndexedDB %s Error: %s", type, #location); \
</span><span class="cx"> ASSERT_NOT_REACHED(); \
</span><del>- recordInternalError(type, location); \
</del><span class="cx"> } while (0)
</span><span class="cx">
</span><span class="cx"> #define INTERNAL_READ_ERROR(location) REPORT_ERROR("Read", location)
</span><span class="lines">@@ -351,21 +343,6 @@
</span><span class="cx"> m_comparator = nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-enum IDBLevelDBBackingStoreOpenResult {
- IDBLevelDBBackingStoreOpenMemorySuccess,
- IDBLevelDBBackingStoreOpenSuccess,
- IDBLevelDBBackingStoreOpenFailedDirectory,
- IDBLevelDBBackingStoreOpenFailedUnknownSchema,
- IDBLevelDBBackingStoreOpenCleanupDestroyFailed,
- IDBLevelDBBackingStoreOpenCleanupReopenFailed,
- IDBLevelDBBackingStoreOpenCleanupReopenSuccess,
- IDBLevelDBBackingStoreOpenFailedIOErrCheckingSchema,
- IDBLevelDBBackingStoreOpenFailedUnknownErr,
- IDBLevelDBBackingStoreOpenMemoryFailed,
- IDBLevelDBBackingStoreOpenAttemptNonASCII,
- IDBLevelDBBackingStoreOpenMax,
-};
-
</del><span class="cx"> PassRefPtr<IDBBackingStoreLevelDB> IDBBackingStoreLevelDB::open(const SecurityOrigin& securityOrigin, const String& pathBaseArg, const String& fileIdentifier)
</span><span class="cx"> {
</span><span class="cx"> DefaultLevelDBFactory levelDBFactory;
</span><span class="lines">@@ -381,11 +358,8 @@
</span><span class="cx"> std::unique_ptr<LevelDBComparator> comparator = std::make_unique<Comparator>();
</span><span class="cx"> std::unique_ptr<LevelDBDatabase> db;
</span><span class="cx">
</span><del>- if (!pathBase.containsOnlyASCII())
- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenAttemptNonASCII, IDBLevelDBBackingStoreOpenMax);
</del><span class="cx"> if (!makeAllDirectories(pathBase)) {
</span><span class="cx"> LOG_ERROR("Unable to create IndexedDB database path %s", pathBase.utf8().data());
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenFailedDirectory, IDBLevelDBBackingStoreOpenMax);
</del><span class="cx"> return PassRefPtr<IDBBackingStoreLevelDB>();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -397,23 +371,18 @@
</span><span class="cx"> bool ok = isSchemaKnown(db.get(), known);
</span><span class="cx"> if (!ok) {
</span><span class="cx"> LOG_ERROR("IndexedDB had IO error checking schema, treating it as failure to open");
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenFailedIOErrCheckingSchema, IDBLevelDBBackingStoreOpenMax);
</del><span class="cx"> db = nullptr;
</span><span class="cx"> } else if (!known) {
</span><span class="cx"> LOG_ERROR("IndexedDB backing store had unknown schema, treating it as failure to open");
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenFailedUnknownSchema, IDBLevelDBBackingStoreOpenMax);
</del><span class="cx"> db = nullptr;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (db)
- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenSuccess, IDBLevelDBBackingStoreOpenMax);
- else {
</del><ins>+ if (!db) {
</ins><span class="cx"> LOG_ERROR("IndexedDB backing store open failed, attempting cleanup");
</span><span class="cx"> bool success = levelDBFactory->destroyLevelDB(path);
</span><span class="cx"> if (!success) {
</span><span class="cx"> LOG_ERROR("IndexedDB backing store cleanup failed");
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenCleanupDestroyFailed, IDBLevelDBBackingStoreOpenMax);
</del><span class="cx"> return PassRefPtr<IDBBackingStoreLevelDB>();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -421,15 +390,12 @@
</span><span class="cx"> db = levelDBFactory->openLevelDB(path, comparator.get());
</span><span class="cx"> if (!db) {
</span><span class="cx"> LOG_ERROR("IndexedDB backing store reopen after recovery failed");
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenCleanupReopenFailed, IDBLevelDBBackingStoreOpenMax);
</del><span class="cx"> return PassRefPtr<IDBBackingStoreLevelDB>();
</span><span class="cx"> }
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenCleanupReopenSuccess, IDBLevelDBBackingStoreOpenMax);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!db) {
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenFailedUnknownErr, IDBLevelDBBackingStoreOpenMax);
</del><span class="cx"> return PassRefPtr<IDBBackingStoreLevelDB>();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -450,10 +416,8 @@
</span><span class="cx"> std::unique_ptr<LevelDBDatabase> db = LevelDBDatabase::openInMemory(comparator.get());
</span><span class="cx"> if (!db) {
</span><span class="cx"> LOG_ERROR("LevelDBDatabase::openInMemory failed.");
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenMemoryFailed, IDBLevelDBBackingStoreOpenMax);
</del><span class="cx"> return PassRefPtr<IDBBackingStoreLevelDB>();
</span><span class="cx"> }
</span><del>- HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenMemorySuccess, IDBLevelDBBackingStoreOpenMax);
</del><span class="cx">
</span><span class="cx"> return create(identifier, std::move(db), std::move(comparator));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbleveldbIDBBackingStoreTransactionLevelDBcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE) && USE(LEVELDB)
</span><span class="cx">
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "IDBBackingStoreLevelDB.h"
</span><span class="cx"> #include "Logging.h"
</span><span class="cx"> #include <wtf/text/CString.h>
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorevcxprojWebCorevcxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -7434,7 +7434,6 @@
</span><span class="cx"> <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|x64'">true</ExcludedFromBuild>
</span><span class="cx"> <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|x64'">true</ExcludedFromBuild>
</span><span class="cx"> </ClCompile>
</span><del>- <ClCompile Include="..\platform\HistogramSupport.cpp" />
</del><span class="cx"> <ClCompile Include="..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp">
</span><span class="cx"> <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
</span><span class="cx"> <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</ExcludedFromBuild>
</span><span class="lines">@@ -19218,7 +19217,6 @@
</span><span class="cx"> <ClInclude Include="..\platform\graphics\VideoTrackPrivate.h" />
</span><span class="cx"> <ClInclude Include="..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.h" />
</span><span class="cx"> <ClInclude Include="..\platform\graphics\win\SharedGDIObject.h" />
</span><del>- <ClInclude Include="..\platform\HistogramSupport.h" />
</del><span class="cx"> <ClInclude Include="..\platform\HostWindow.h" />
</span><span class="cx"> <ClInclude Include="..\platform\KeypressCommand.h" />
</span><span class="cx"> <ClInclude Include="..\platform\KillRing.h" />
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorevcxprojWebCorevcxprojfilters"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -1089,9 +1089,6 @@
</span><span class="cx"> <ClCompile Include="..\platform\FileSystem.cpp">
</span><span class="cx"> <Filter>platform</Filter>
</span><span class="cx"> </ClCompile>
</span><del>- <ClCompile Include="..\platform\HistogramSupport.cpp">
- <Filter>platform</Filter>
- </ClCompile>
</del><span class="cx"> <ClCompile Include="..\platform\KillRingNone.cpp">
</span><span class="cx"> <Filter>platform</Filter>
</span><span class="cx"> </ClCompile>
</span><span class="lines">@@ -8038,9 +8035,6 @@
</span><span class="cx"> <ClInclude Include="..\platform\FloatConversion.h">
</span><span class="cx"> <Filter>platform</Filter>
</span><span class="cx"> </ClInclude>
</span><del>- <ClInclude Include="..\platform\HistogramSupport.h">
- <Filter>platform</Filter>
- </ClInclude>
</del><span class="cx"> <ClInclude Include="..\platform\HostWindow.h">
</span><span class="cx"> <Filter>platform</Filter>
</span><span class="cx"> </ClInclude>
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -1928,7 +1928,6 @@
</span><span class="cx"> 51D719D3181106E00016DC51 /* IDBFactory.h in Headers */ = {isa = PBXBuildFile; fileRef = 51D71989181106DF0016DC51 /* IDBFactory.h */; };
</span><span class="cx"> 51D719D5181106E00016DC51 /* IDBFactoryBackendInterface.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51D7198B181106DF0016DC51 /* IDBFactoryBackendInterface.cpp */; };
</span><span class="cx"> 51D719D6181106E00016DC51 /* IDBFactoryBackendInterface.h in Headers */ = {isa = PBXBuildFile; fileRef = 51D7198C181106E00016DC51 /* IDBFactoryBackendInterface.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><del>- 51D719D7181106E00016DC51 /* IDBHistograms.h in Headers */ = {isa = PBXBuildFile; fileRef = 51D7198D181106E00016DC51 /* IDBHistograms.h */; };
</del><span class="cx"> 51D719D8181106E00016DC51 /* IDBIndex.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51D7198E181106E00016DC51 /* IDBIndex.cpp */; };
</span><span class="cx"> 51D719D9181106E00016DC51 /* IDBIndex.h in Headers */ = {isa = PBXBuildFile; fileRef = 51D7198F181106E00016DC51 /* IDBIndex.h */; };
</span><span class="cx"> 51D719DB181106E00016DC51 /* IDBKey.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51D71991181106E00016DC51 /* IDBKey.cpp */; };
</span><span class="lines">@@ -5752,7 +5751,6 @@
</span><span class="cx"> D6E528A3149A926D00EFE1F3 /* MutationObserverInterestGroup.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D6E528A1149A926D00EFE1F3 /* MutationObserverInterestGroup.cpp */; };
</span><span class="cx"> D6E528A4149A926D00EFE1F3 /* MutationObserverInterestGroup.h in Headers */ = {isa = PBXBuildFile; fileRef = D6E528A2149A926D00EFE1F3 /* MutationObserverInterestGroup.h */; };
</span><span class="cx"> D6F7960D166FFECE0076DD18 /* JSHTMLTemplateElementCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D6F7960C166FFECE0076DD18 /* JSHTMLTemplateElementCustom.cpp */; };
</span><del>- D6FDAEF3149C06190037B1E1 /* HistogramSupport.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D6FDAEF2149C06190037B1E1 /* HistogramSupport.cpp */; };
</del><span class="cx"> D70AD65713E1342B005B50B4 /* RenderRegion.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D70AD65513E1342B005B50B4 /* RenderRegion.cpp */; };
</span><span class="cx"> D70AD65813E1342B005B50B4 /* RenderRegion.h in Headers */ = {isa = PBXBuildFile; fileRef = D70AD65613E1342B005B50B4 /* RenderRegion.h */; };
</span><span class="cx"> D72F6D79153159A3001EE44E /* FlowThreadController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D72F6D77153159A3001EE44E /* FlowThreadController.cpp */; };
</span><span class="lines">@@ -8931,7 +8929,6 @@
</span><span class="cx"> 51D7198A181106DF0016DC51 /* IDBFactory.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = IDBFactory.idl; sourceTree = "<group>"; };
</span><span class="cx"> 51D7198B181106DF0016DC51 /* IDBFactoryBackendInterface.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = IDBFactoryBackendInterface.cpp; sourceTree = "<group>"; };
</span><span class="cx"> 51D7198C181106E00016DC51 /* IDBFactoryBackendInterface.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IDBFactoryBackendInterface.h; sourceTree = "<group>"; };
</span><del>- 51D7198D181106E00016DC51 /* IDBHistograms.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IDBHistograms.h; sourceTree = "<group>"; };
</del><span class="cx"> 51D7198E181106E00016DC51 /* IDBIndex.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = IDBIndex.cpp; sourceTree = "<group>"; };
</span><span class="cx"> 51D7198F181106E00016DC51 /* IDBIndex.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IDBIndex.h; sourceTree = "<group>"; };
</span><span class="cx"> 51D71990181106E00016DC51 /* IDBIndex.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = IDBIndex.idl; sourceTree = "<group>"; };
</span><span class="lines">@@ -13128,7 +13125,6 @@
</span><span class="cx"> D3D4E971130C7CFE007BA540 /* HTMLSummaryElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTMLSummaryElement.h; sourceTree = "<group>"; };
</span><span class="cx"> D619A305144E00BE004BC302 /* ChildListMutationScope.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ChildListMutationScope.cpp; sourceTree = "<group>"; };
</span><span class="cx"> D619A306144E00BE004BC302 /* ChildListMutationScope.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ChildListMutationScope.h; sourceTree = "<group>"; };
</span><del>- D630E2AB149BF344005B2F93 /* HistogramSupport.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HistogramSupport.h; sourceTree = "<group>"; };
</del><span class="cx"> D6489D23166FFCF1007C031B /* JSHTMLTemplateElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLTemplateElement.cpp; sourceTree = "<group>"; };
</span><span class="cx"> D6489D24166FFCF1007C031B /* JSHTMLTemplateElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSHTMLTemplateElement.h; sourceTree = "<group>"; };
</span><span class="cx"> D66B2D5B186830050073C4DD /* PlatformCAFiltersMac.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = PlatformCAFiltersMac.h; path = ca/mac/PlatformCAFiltersMac.h; sourceTree = "<group>"; };
</span><span class="lines">@@ -13140,7 +13136,6 @@
</span><span class="cx"> D6EFC0BC1666DF7A003D291E /* HTMLTemplateElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTMLTemplateElement.h; sourceTree = "<group>"; };
</span><span class="cx"> D6EFC0BD1666DF7A003D291E /* HTMLTemplateElement.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = HTMLTemplateElement.idl; sourceTree = "<group>"; };
</span><span class="cx"> D6F7960C166FFECE0076DD18 /* JSHTMLTemplateElementCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLTemplateElementCustom.cpp; sourceTree = "<group>"; };
</span><del>- D6FDAEF2149C06190037B1E1 /* HistogramSupport.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = HistogramSupport.cpp; sourceTree = "<group>"; };
</del><span class="cx"> D70AD65513E1342B005B50B4 /* RenderRegion.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderRegion.cpp; sourceTree = "<group>"; };
</span><span class="cx"> D70AD65613E1342B005B50B4 /* RenderRegion.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderRegion.h; sourceTree = "<group>"; };
</span><span class="cx"> D72F6D77153159A3001EE44E /* FlowThreadController.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = FlowThreadController.cpp; sourceTree = "<group>"; };
</span><span class="lines">@@ -17798,7 +17793,6 @@
</span><span class="cx"> 51D7198B181106DF0016DC51 /* IDBFactoryBackendInterface.cpp */,
</span><span class="cx"> 51D7198C181106E00016DC51 /* IDBFactoryBackendInterface.h */,
</span><span class="cx"> 5123AF1C18918AE40031CDC9 /* IDBGetResult.h */,
</span><del>- 51D7198D181106E00016DC51 /* IDBHistograms.h */,
</del><span class="cx"> 51D7198E181106E00016DC51 /* IDBIndex.cpp */,
</span><span class="cx"> 51D7198F181106E00016DC51 /* IDBIndex.h */,
</span><span class="cx"> 51D71990181106E00016DC51 /* IDBIndex.idl */,
</span><span class="lines">@@ -21022,8 +21016,6 @@
</span><span class="cx"> 514B3F720C722047000530DF /* FileSystem.h */,
</span><span class="cx"> BC073BA90C399B1F000F5979 /* FloatConversion.h */,
</span><span class="cx"> A8748BDF12CBF2DC001FBA41 /* HashTools.h */,
</span><del>- D6FDAEF2149C06190037B1E1 /* HistogramSupport.cpp */,
- D630E2AB149BF344005B2F93 /* HistogramSupport.h */,
</del><span class="cx"> BC3BC29B0E91AB0F00835588 /* HostWindow.h */,
</span><span class="cx"> 862F129F18C1DCE4005C54AF /* HysteresisActivity.h */,
</span><span class="cx"> E15FF7D418C9553800FE4C87 /* KeypressCommand.h */,
</span><span class="lines">@@ -24181,7 +24173,6 @@
</span><span class="cx"> 51D719D6181106E00016DC51 /* IDBFactoryBackendInterface.h in Headers */,
</span><span class="cx"> 51660AB91828BB8200074CAD /* IDBFactoryBackendLevelDB.h in Headers */,
</span><span class="cx"> 5123AF1D18918AE40031CDC9 /* IDBGetResult.h in Headers */,
</span><del>- 51D719D7181106E00016DC51 /* IDBHistograms.h in Headers */,
</del><span class="cx"> 51D719D9181106E00016DC51 /* IDBIndex.h in Headers */,
</span><span class="cx"> 51ABB5B8186D0ED1008391A1 /* IDBIndexMetadata.h in Headers */,
</span><span class="cx"> 510194411836D20800925523 /* IDBIndexWriterLevelDB.h in Headers */,
</span><span class="lines">@@ -27445,7 +27436,6 @@
</span><span class="cx"> B2A015AA0AF6CD53006BCE0E /* GraphicsTypes.cpp in Sources */,
</span><span class="cx"> C50B561612119D23008B46E0 /* GroupSettings.cpp in Sources */,
</span><span class="cx"> F55B3DBF1251F12D003EF269 /* HiddenInputType.cpp in Sources */,
</span><del>- D6FDAEF3149C06190037B1E1 /* HistogramSupport.cpp in Sources */,
</del><span class="cx"> BC94D1530C275C8B006BC617 /* History.cpp in Sources */,
</span><span class="cx"> 97DCE20110807C750057D394 /* HistoryController.cpp in Sources */,
</span><span class="cx"> 51741D120B07259A00ED442C /* HistoryItem.cpp in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -62,7 +62,6 @@
</span><span class="cx"> #include "FloatConversion.h"
</span><span class="cx"> #include "HTMLParserIdioms.h"
</span><span class="cx"> #include "HashTools.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "MediaList.h"
</span><span class="cx"> #include "MediaQueryExp.h"
</span><span class="cx"> #include "Page.h"
</span><span class="lines">@@ -11942,16 +11941,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const Property* hashTableEntry = findProperty(name, length);
</span><del>- const CSSPropertyID propertyID = hashTableEntry ? static_cast<CSSPropertyID>(hashTableEntry->id) : CSSPropertyInvalid;
-
- static const int cssPropertyHistogramSize = numCSSProperties;
- if (hasPrefix(buffer, length, "-webkit-") && propertyID != CSSPropertyInvalid) {
- int histogramValue = propertyID - firstCSSProperty;
- ASSERT(0 <= histogramValue && histogramValue < cssPropertyHistogramSize);
- HistogramSupport::histogramEnumeration("CSS.PrefixUsage", histogramValue, cssPropertyHistogramSize);
- }
-
- return propertyID;
</del><ins>+ return hashTableEntry ? static_cast<CSSPropertyID>(hashTableEntry->id) : CSSPropertyInvalid;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> CSSPropertyID cssPropertyID(const String& string)
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -85,7 +85,6 @@
</span><span class="cx"> #include "HTMLTitleElement.h"
</span><span class="cx"> #include "HTTPParsers.h"
</span><span class="cx"> #include "HashChangeEvent.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "History.h"
</span><span class="cx"> #include "HitTestResult.h"
</span><span class="cx"> #include "IconController.h"
</span><span class="lines">@@ -547,16 +546,6 @@
</span><span class="cx"> m_nodeListAndCollectionCounts[i] = 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void histogramMutationEventUsage(const unsigned short& listenerTypes)
-{
- HistogramSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMSubtreeModified", static_cast<bool>(listenerTypes & Document::DOMSUBTREEMODIFIED_LISTENER), 2);
- HistogramSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMNodeInserted", static_cast<bool>(listenerTypes & Document::DOMNODEINSERTED_LISTENER), 2);
- HistogramSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMNodeRemoved", static_cast<bool>(listenerTypes & Document::DOMNODEREMOVED_LISTENER), 2);
- HistogramSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMNodeRemovedFromDocument", static_cast<bool>(listenerTypes & Document::DOMNODEREMOVEDFROMDOCUMENT_LISTENER), 2);
- HistogramSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMNodeInsertedIntoDocument", static_cast<bool>(listenerTypes & Document::DOMNODEINSERTEDINTODOCUMENT_LISTENER), 2);
- HistogramSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMCharacterDataModified", static_cast<bool>(listenerTypes & Document::DOMCHARACTERDATAMODIFIED_LISTENER), 2);
-}
-
</del><span class="cx"> #if ENABLE(FULLSCREEN_API)
</span><span class="cx"> static bool isAttributeOnAllOwners(const WebCore::QualifiedName& attribute, const WebCore::QualifiedName& prefixedAttribute, const HTMLFrameOwnerElement* owner)
</span><span class="cx"> {
</span><span class="lines">@@ -603,8 +592,6 @@
</span><span class="cx">
</span><span class="cx"> m_scriptRunner = nullptr;
</span><span class="cx">
</span><del>- histogramMutationEventUsage(m_listenerTypes);
-
</del><span class="cx"> removeAllEventListeners();
</span><span class="cx">
</span><span class="cx"> // Currently we believe that Document can never outlive the parser.
</span></span></pre></div>
<a id="trunkSourceWebCoredomShadowRootcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx"> #include "ShadowRoot.h"
</span><span class="cx">
</span><span class="cx"> #include "ElementTraversal.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "InsertionPoint.h"
</span><span class="cx"> #include "RenderElement.h"
</span><span class="cx"> #include "RuntimeEnabledFeatures.h"
</span></span></pre></div>
<a id="trunkSourceWebCorefileapiBlobcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/fileapi/Blob.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/fileapi/Blob.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/fileapi/Blob.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -33,7 +33,6 @@
</span><span class="cx">
</span><span class="cx"> #include "BlobURL.h"
</span><span class="cx"> #include "File.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "ScriptExecutionContext.h"
</span><span class="cx"> #include "ThreadableBlobRegistry.h"
</span><span class="cx"> #include <wtf/text/CString.h>
</span></span></pre></div>
<a id="trunkSourceWebCorefileapiWebKitBlobBuildercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/fileapi/WebKitBlobBuilder.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/fileapi/WebKitBlobBuilder.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/fileapi/WebKitBlobBuilder.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -35,7 +35,6 @@
</span><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "ExceptionCode.h"
</span><span class="cx"> #include "File.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "LineEnding.h"
</span><span class="cx"> #include "TextEncoding.h"
</span><span class="cx"> #include <runtime/ArrayBuffer.h>
</span><span class="lines">@@ -73,8 +72,6 @@
</span><span class="cx"> #if ENABLE(BLOB)
</span><span class="cx"> void BlobBuilder::append(ArrayBuffer* arrayBuffer)
</span><span class="cx"> {
</span><del>- HistogramSupport::histogramEnumeration("WebCore.Blob.constructor.ArrayBufferOrView", BlobConstructorArrayBuffer, BlobConstructorArrayBufferOrViewMax);
-
</del><span class="cx"> if (!arrayBuffer)
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -83,8 +80,6 @@
</span><span class="cx">
</span><span class="cx"> void BlobBuilder::append(PassRefPtr<ArrayBufferView> arrayBufferView)
</span><span class="cx"> {
</span><del>- HistogramSupport::histogramEnumeration("WebCore.Blob.constructor.ArrayBufferOrView", BlobConstructorArrayBufferView, BlobConstructorArrayBufferOrViewMax);
-
</del><span class="cx"> if (!arrayBufferView)
</span><span class="cx"> return;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryPageCachecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/PageCache.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/PageCache.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/history/PageCache.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -40,7 +40,6 @@
</span><span class="cx"> #include "FrameLoaderClient.h"
</span><span class="cx"> #include "FrameLoaderStateMachine.h"
</span><span class="cx"> #include "FrameView.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "HistoryController.h"
</span><span class="cx"> #include "HistoryItem.h"
</span><span class="cx"> #include "Logging.h"
</span><span class="lines">@@ -181,16 +180,6 @@
</span><span class="cx"> rejectReasons |= 1 << ClientDeniesCaching;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- HistogramSupport::histogramEnumeration("PageCache.FrameCacheable", !rejectReasons, 2);
- int reasonCount = 0;
- for (int i = 0; i < NumberOfReasonsFramesCannotBeInPageCache; ++i) {
- if (rejectReasons & (1 << i)) {
- ++reasonCount;
- HistogramSupport::histogramEnumeration("PageCache.FrameRejectReason", i, NumberOfReasonsFramesCannotBeInPageCache);
- }
- }
- HistogramSupport::histogramEnumeration("PageCache.FrameRejectReasonCount", reasonCount, 1 + NumberOfReasonsFramesCannotBeInPageCache);
-
</del><span class="cx"> for (Frame* child = frame->tree().firstChild(); child; child = child->tree().nextSibling())
</span><span class="cx"> rejectReasons |= logCanCacheFrameDecision(child, indentLevel + 1);
</span><span class="cx">
</span><span class="lines">@@ -267,31 +256,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PCLOG(rejectReasons ? " Page CANNOT be cached\n--------" : " Page CAN be cached\n--------");
</span><del>-
- HistogramSupport::histogramEnumeration("PageCache.PageCacheable", !rejectReasons, 2);
- int reasonCount = 0;
- for (int i = 0; i < NumberOfReasonsPagesCannotBeInPageCache; ++i) {
- if (rejectReasons & (1 << i)) {
- ++reasonCount;
- HistogramSupport::histogramEnumeration("PageCache.PageRejectReason", i, NumberOfReasonsPagesCannotBeInPageCache);
- }
- }
- HistogramSupport::histogramEnumeration("PageCache.PageRejectReasonCount", reasonCount, 1 + NumberOfReasonsPagesCannotBeInPageCache);
- const bool settingsDisabledPageCache = rejectReasons & (1 << DisabledPageCache);
- HistogramSupport::histogramEnumeration("PageCache.PageRejectReasonCountExcludingSettings", reasonCount - settingsDisabledPageCache, NumberOfReasonsPagesCannotBeInPageCache);
-
- // Report also on the frame reasons by page; this is distinct from the per frame statistics since it coalesces the
- // causes from all subframes together.
- HistogramSupport::histogramEnumeration("PageCache.FrameCacheableByPage", !frameRejectReasons, 2);
- int frameReasonCount = 0;
- for (int i = 0; i <= NumberOfReasonsFramesCannotBeInPageCache; ++i) {
- if (frameRejectReasons & (1 << i)) {
- ++frameReasonCount;
- HistogramSupport::histogramEnumeration("PageCache.FrameRejectReasonByPage", i, NumberOfReasonsFramesCannotBeInPageCache);
- }
- }
-
- HistogramSupport::histogramEnumeration("PageCache.FrameRejectReasonCountByPage", frameReasonCount, 1 + NumberOfReasonsFramesCannotBeInPageCache);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #endif // !defined(NDEBUG)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformHistogramSupportcpp"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/platform/HistogramSupport.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/HistogramSupport.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/platform/HistogramSupport.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -1,44 +0,0 @@
</span><del>-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "HistogramSupport.h"
-
-namespace WebCore {
-
-void HistogramSupport::histogramEnumeration(const char*, int, int)
-{
-}
-
-void HistogramSupport::histogramCustomCounts(const char*, int, int, int, int)
-{
-}
-
-} // namespace WebCore
</del></span></pre></div>
<a id="trunkSourceWebCoreplatformHistogramSupporth"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/platform/HistogramSupport.h (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/HistogramSupport.h 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/platform/HistogramSupport.h 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -1,44 +0,0 @@
</span><del>-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef HistogramSupport_h
-#define HistogramSupport_h
-
-namespace WebCore {
-
-class HistogramSupport {
-public:
- static void histogramEnumeration(const char* name, int sample, int boundaryValue);
- static void histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount);
-};
-
-} // namespace WebCore
-
-#endif // HistogramSupport_h
</del></span></pre></div>
<a id="trunkSourceWebCoreplatformleveldbLevelDBDatabasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx">
</span><span class="cx"> #if USE(LEVELDB)
</span><span class="cx">
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "LevelDBComparator.h"
</span><span class="cx"> #include "LevelDBIterator.h"
</span><span class="cx"> #include "LevelDBSlice.h"
</span><span class="lines">@@ -136,26 +135,6 @@
</span><span class="cx"> return s.ok();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void histogramLevelDBError(const char* histogramName, const leveldb::Status& s)
-{
- ASSERT(!s.ok());
- enum {
- LevelDBNotFound,
- LevelDBCorruption,
- LevelDBIOError,
- LevelDBOther,
- LevelDBMaxError
- };
- int levelDBError = LevelDBOther;
- if (s.IsNotFound())
- levelDBError = LevelDBNotFound;
- else if (s.IsCorruption())
- levelDBError = LevelDBCorruption;
- else if (s.IsIOError())
- levelDBError = LevelDBIOError;
- HistogramSupport::histogramEnumeration(histogramName, levelDBError, LevelDBMaxError);
-}
-
</del><span class="cx"> std::unique_ptr<LevelDBDatabase> LevelDBDatabase::open(const String& fileName, const LevelDBComparator* comparator)
</span><span class="cx"> {
</span><span class="cx"> auto comparatorAdapter = std::make_unique<ComparatorAdapter>(comparator);
</span><span class="lines">@@ -164,8 +143,6 @@
</span><span class="cx"> const leveldb::Status s = openDB(comparatorAdapter.get(), leveldb::IDBEnv(), fileName, &db);
</span><span class="cx">
</span><span class="cx"> if (!s.ok()) {
</span><del>- histogramLevelDBError("WebCore.IndexedDB.LevelDBOpenErrors", s);
-
</del><span class="cx"> LOG_ERROR("Failed to open LevelDB database from %s: %s", fileName.ascii().data(), s.ToString().c_str());
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -70,7 +70,6 @@
</span><span class="cx"> #include "HTMLFrameElement.h"
</span><span class="cx"> #include "HTMLFrameOwnerElement.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "HitTestingTransformState.h"
</span><span class="cx"> #include "HitTestRequest.h"
</span><span class="cx"> #include "HitTestResult.h"
</span><span class="lines">@@ -2178,12 +2177,6 @@
</span><span class="cx"> // layers in WebCore, because we use UIKit to composite our scroll bars.
</span><span class="cx"> m_needsCompositedScrolling = forceUseCompositedScrolling;
</span><span class="cx"> #endif
</span><del>- // We gather a boolean value for use with Google UMA histograms to
- // quantify the actual effects of a set of patches attempting to
- // relax composited scrolling requirements, thereby increasing the
- // number of composited overflow divs.
- if (acceleratedCompositingForOverflowScrollEnabled())
- HistogramSupport::histogramEnumeration("Renderer.NeedsCompositedScrolling", m_needsCompositedScrolling, 2);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (oldNeedsCompositedScrolling != m_needsCompositedScrolling) {
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXMLHttpRequestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (168208 => 168209)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2014-05-02 23:48:24 UTC (rev 168208)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2014-05-02 23:57:54 UTC (rev 168209)
</span><span class="lines">@@ -35,7 +35,6 @@
</span><span class="cx"> #include "File.h"
</span><span class="cx"> #include "HTMLDocument.h"
</span><span class="cx"> #include "HTTPParsers.h"
</span><del>-#include "HistogramSupport.h"
</del><span class="cx"> #include "InspectorInstrumentation.h"
</span><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMWindow.h"
</span><span class="lines">@@ -703,15 +702,11 @@
</span><span class="cx"> String consoleMessage("ArrayBuffer is deprecated in XMLHttpRequest.send(). Use ArrayBufferView instead.");
</span><span class="cx"> scriptExecutionContext()->addConsoleMessage(MessageSource::JS, MessageLevel::Warning, consoleMessage);
</span><span class="cx">
</span><del>- HistogramSupport::histogramEnumeration("WebCore.XHR.send.ArrayBufferOrView", XMLHttpRequestSendArrayBuffer, XMLHttpRequestSendArrayBufferOrViewMax);
-
</del><span class="cx"> sendBytesData(body->data(), body->byteLength(), ec);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void XMLHttpRequest::send(ArrayBufferView* body, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- HistogramSupport::histogramEnumeration("WebCore.XHR.send.ArrayBufferOrView", XMLHttpRequestSendArrayBufferView, XMLHttpRequestSendArrayBufferOrViewMax);
-
</del><span class="cx"> sendBytesData(body->baseAddress(), body->byteLength(), ec);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>