<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[168123] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/168123">168123</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-05-01 15:03:54 -0700 (Thu, 01 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove WKBundleSetShouldTrackVisitedLinks and associate code
https://bugs.webkit.org/show_bug.cgi?id=132441
Reviewed by Sam Weinig.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetShouldTrackVisitedLinks): Deleted.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setShouldTrackVisitedLinks): Deleted.
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/WebPage/VisitedLinkTableController.cpp:
(WebKit::VisitedLinkTableController::addVisitedLink):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::setShouldTrackVisitedLinks): Deleted.
* WebProcess/WebProcess.h:
(WebKit::WebProcess::shouldTrackVisitedLinks): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleAPIcWKBundlecpp">trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleAPIcWKBundlePrivateh">trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp">trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleInjectedBundleh">trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageVisitedLinkTableControllercpp">trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebProcesscpp">trunk/Source/WebKit2/WebProcess/WebProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebProcessh">trunk/Source/WebKit2/WebProcess/WebProcess.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (168122 => 168123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-01 22:03:54 UTC (rev 168123)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2014-05-01 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><ins>+ Remove WKBundleSetShouldTrackVisitedLinks and associate code
+ https://bugs.webkit.org/show_bug.cgi?id=132441
+
+ Reviewed by Sam Weinig.
+
+ * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+ (WKBundleSetShouldTrackVisitedLinks): Deleted.
+ * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::setShouldTrackVisitedLinks): Deleted.
+ * WebProcess/InjectedBundle/InjectedBundle.h:
+ * WebProcess/WebPage/VisitedLinkTableController.cpp:
+ (WebKit::VisitedLinkTableController::addVisitedLink):
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::WebProcess):
+ (WebKit::WebProcess::setShouldTrackVisitedLinks): Deleted.
+ * WebProcess/WebProcess.h:
+ (WebKit::WebProcess::shouldTrackVisitedLinks): Deleted.
+
+2014-05-01 Anders Carlsson <andersca@apple.com>
+
</ins><span class="cx"> window.testRunner.keepWebHistory() should update the UI process state
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=132440
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleAPIcWKBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (168122 => 168123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2014-05-01 22:03:54 UTC (rev 168123)
</span><span class="lines">@@ -63,11 +63,6 @@
</span><span class="cx"> return toAPI(toImpl(bundleRef)->webConnectionToUIProcess());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WKBundleSetShouldTrackVisitedLinks(WKBundleRef bundleRef, bool shouldTrackVisitedLinks)
-{
- toImpl(bundleRef)->setShouldTrackVisitedLinks(shouldTrackVisitedLinks);
-}
-
</del><span class="cx"> void WKBundleRemoveAllVisitedLinks(WKBundleRef bundleRef)
</span><span class="cx"> {
</span><span class="cx"> toImpl(bundleRef)->removeAllVisitedLinks();
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleAPIcWKBundlePrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h (168122 => 168123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2014-05-01 22:03:54 UTC (rev 168123)
</span><span class="lines">@@ -41,7 +41,6 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> // TestRunner only SPI
</span><del>-WK_EXPORT void WKBundleSetShouldTrackVisitedLinks(WKBundleRef bundle, bool shouldTrackVisitedLinks);
</del><span class="cx"> WK_EXPORT void WKBundleSetAlwaysAcceptCookies(WKBundleRef bundle, bool);
</span><span class="cx"> WK_EXPORT void WKBundleRemoveAllVisitedLinks(WKBundleRef bundle);
</span><span class="cx"> WK_EXPORT void WKBundleActivateMacFontAscentHack(WKBundleRef bundle);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (168122 => 168123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2014-05-01 22:03:54 UTC (rev 168123)
</span><span class="lines">@@ -130,11 +130,6 @@
</span><span class="cx"> return WebProcess::shared().webConnectionToUIProcess();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InjectedBundle::setShouldTrackVisitedLinks(bool shouldTrackVisitedLinks)
-{
- WebProcess::shared().setShouldTrackVisitedLinks(shouldTrackVisitedLinks);
-}
-
</del><span class="cx"> void InjectedBundle::setAlwaysAcceptCookies(bool accept)
</span><span class="cx"> {
</span><span class="cx"> WebProcess::shared().supplement<WebCookieManager>()->setHTTPCookieAcceptPolicy(accept ? HTTPCookieAcceptPolicyAlways : HTTPCookieAcceptPolicyOnlyFromMainDocumentDomain);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleInjectedBundleh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h (168122 => 168123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2014-05-01 22:03:54 UTC (rev 168123)
</span><span class="lines">@@ -100,7 +100,6 @@
</span><span class="cx"> WebConnection* webConnectionToUIProcess() const;
</span><span class="cx">
</span><span class="cx"> // TestRunner only SPI
</span><del>- void setShouldTrackVisitedLinks(bool);
</del><span class="cx"> void setAlwaysAcceptCookies(bool);
</span><span class="cx"> void removeAllVisitedLinks();
</span><span class="cx"> void setCacheModel(uint32_t);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageVisitedLinkTableControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp (168122 => 168123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp 2014-05-01 22:03:54 UTC (rev 168123)
</span><span class="lines">@@ -81,9 +81,6 @@
</span><span class="cx"> if (m_visitedLinkTable.isLinkVisited(linkHash))
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (!WebProcess::shared().shouldTrackVisitedLinks())
- return;
-
</del><span class="cx"> WebPage* webPage = WebPage::fromCorePage(&page);
</span><span class="cx"> if (!webPage)
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (168122 => 168123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2014-05-01 22:03:54 UTC (rev 168123)
</span><span class="lines">@@ -150,7 +150,6 @@
</span><span class="cx"> , m_viewUpdateDispatcher(ViewUpdateDispatcher::create())
</span><span class="cx"> #endif // PLATFORM(IOS)
</span><span class="cx"> , m_inDidClose(false)
</span><del>- , m_shouldTrackVisitedLinks(true)
</del><span class="cx"> , m_hasSetCacheModel(false)
</span><span class="cx"> , m_cacheModel(CacheModelDocumentViewer)
</span><span class="cx"> #if PLATFORM(COCOA)
</span><span class="lines">@@ -396,12 +395,6 @@
</span><span class="cx"> }
</span><span class="cx"> #endif // ENABLE(NETWORK_PROCESS)
</span><span class="cx">
</span><del>-void WebProcess::setShouldTrackVisitedLinks(bool shouldTrackVisitedLinks)
-{
- m_shouldTrackVisitedLinks = shouldTrackVisitedLinks;
- PageGroup::setShouldTrackVisitedLinks(shouldTrackVisitedLinks);
-}
-
</del><span class="cx"> void WebProcess::registerURLSchemeAsEmptyDocument(const String& urlScheme)
</span><span class="cx"> {
</span><span class="cx"> SchemeRegistry::registerURLSchemeAsEmptyDocument(urlScheme);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebProcessh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebProcess.h (168122 => 168123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebProcess.h 2014-05-01 21:53:47 UTC (rev 168122)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.h 2014-05-01 22:03:54 UTC (rev 168123)
</span><span class="lines">@@ -115,11 +115,6 @@
</span><span class="cx"> mach_port_t compositingRenderServerPort() const { return m_compositingRenderServerPort; }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- // FIXME: This is only used by the injected bundle for layout tests.
- // WebKitTestRunner should just post a message to change whether visited links should be added.
- bool shouldTrackVisitedLinks() const { return m_shouldTrackVisitedLinks; }
- void setShouldTrackVisitedLinks(bool);
-
</del><span class="cx"> bool shouldPlugInAutoStartFromOrigin(const WebPage*, const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
</span><span class="cx"> void plugInDidStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
</span><span class="cx"> void plugInDidReceiveUserInteraction(const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
</span><span class="lines">@@ -293,9 +288,6 @@
</span><span class="cx">
</span><span class="cx"> bool m_inDidClose;
</span><span class="cx">
</span><del>- // FIXME: Whether visited links should be tracked or not should be handled in the UI process.
- bool m_shouldTrackVisitedLinks;
-
</del><span class="cx"> HashMap<unsigned, double> m_plugInAutoStartOriginHashes;
</span><span class="cx"> HashSet<String> m_plugInAutoStartOrigins;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>