<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167993] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167993">167993</a></dd>
<dt>Author</dt> <dd>rego@igalia.com</dd>
<dt>Date</dt> <dd>2014-04-30 01:54:39 -0700 (Wed, 30 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Grid Layout] Enable runtime feature by default
https://bugs.webkit.org/show_bug.cgi?id=132189
Reviewed by Benjamin Poulain.
Source/WebCore:
* page/Settings.in: Set cssGridLayoutEnabled to true.
Source/WebKit/mac:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Remove unneeded changes that
enable/disable the runtime feature depending on the compilation flag.
And set it to true by default.
Source/WebKit2:
* Shared/WebPreferencesStore.h: Remove unneeded changes that
enable/disable the runtime feature depending on the compilation flag.
And set it to true by default.
* UIProcess/gtk/ExperimentalFeatures.cpp: Set it to true by default.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageSettingsin">trunk/Source/WebCore/page/Settings.in</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesStoreh">trunk/Source/WebKit2/Shared/WebPreferencesStore.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessgtkExperimentalFeaturescpp">trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (167992 => 167993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-30 08:37:35 UTC (rev 167992)
+++ trunk/Source/WebCore/ChangeLog 2014-04-30 08:54:39 UTC (rev 167993)
</span><span class="lines">@@ -1,5 +1,14 @@
</span><span class="cx"> 2014-04-30 Manuel Rego Casasnovas <rego@igalia.com>
</span><span class="cx">
</span><ins>+ [CSS Grid Layout] Enable runtime feature by default
+ https://bugs.webkit.org/show_bug.cgi?id=132189
+
+ Reviewed by Benjamin Poulain.
+
+ * page/Settings.in: Set cssGridLayoutEnabled to true.
+
+2014-04-30 Manuel Rego Casasnovas <rego@igalia.com>
+
</ins><span class="cx"> [CSS Grid Layout] Wrap some specific grid code under compilation flag
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=132341
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.in (167992 => 167993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.in 2014-04-30 08:37:35 UTC (rev 167992)
+++ trunk/Source/WebCore/page/Settings.in 2014-04-30 08:54:39 UTC (rev 167993)
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> acceleratedDrawingEnabled initial=false
</span><span class="cx"> acceleratedFiltersEnabled initial=false
</span><span class="cx"> regionBasedColumnsEnabled initial=false
</span><del>-cssGridLayoutEnabled initial=false
</del><ins>+cssGridLayoutEnabled initial=true
</ins><span class="cx"> useLegacyTextAlignPositionedElementBehavior initial=false
</span><span class="cx">
</span><span class="cx"> # FIXME: This should really be disabled by default as it makes platforms that don't support the feature download files
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (167992 => 167993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-04-30 08:37:35 UTC (rev 167992)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-04-30 08:54:39 UTC (rev 167993)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-04-30 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Enable runtime feature by default
+ https://bugs.webkit.org/show_bug.cgi?id=132189
+
+ Reviewed by Benjamin Poulain.
+
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]): Remove unneeded changes that
+ enable/disable the runtime feature depending on the compilation flag.
+ And set it to true by default.
+
</ins><span class="cx"> 2014-04-29 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (167992 => 167993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2014-04-30 08:37:35 UTC (rev 167992)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2014-04-30 08:54:39 UTC (rev 167993)
</span><span class="lines">@@ -482,11 +482,7 @@
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitAcceleratedCompositingEnabledPreferenceKey,
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitCSSRegionsEnabledPreferenceKey,
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitCSSCompositingEnabledPreferenceKey,
</span><del>-#if ENABLE(CSS_GRID_LAYOUT)
</del><span class="cx"> [NSNumber numberWithBool:YES], WebKitCSSGridLayoutEnabledPreferenceKey,
</span><del>-#else
- [NSNumber numberWithBool:NO], WebKitCSSGridLayoutEnabledPreferenceKey,
-#endif
</del><span class="cx"> #if PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitAcceleratedDrawingEnabledPreferenceKey,
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitCanvasUsesAcceleratedDrawingPreferenceKey,
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (167992 => 167993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-04-30 08:37:35 UTC (rev 167992)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-30 08:54:39 UTC (rev 167993)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-04-30 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Enable runtime feature by default
+ https://bugs.webkit.org/show_bug.cgi?id=132189
+
+ Reviewed by Benjamin Poulain.
+
+ * Shared/WebPreferencesStore.h: Remove unneeded changes that
+ enable/disable the runtime feature depending on the compilation flag.
+ And set it to true by default.
+ * UIProcess/gtk/ExperimentalFeatures.cpp: Set it to true by default.
+
</ins><span class="cx"> 2014-04-30 Roger Fong <roger_fong@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed. Wrong units used in offset calculation from r167961.
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesStoreh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (167992 => 167993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2014-04-30 08:37:35 UTC (rev 167992)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2014-04-30 08:54:39 UTC (rev 167993)
</span><span class="lines">@@ -100,12 +100,6 @@
</span><span class="cx"> #define DEFAULT_CANVAS_USES_ACCELERATED_DRAWING true
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if ENABLE(CSS_GRID_LAYOUT)
-#define DEFAULT_CSS_GRID_LAYOUT_ENABLED true
-#else
-#define DEFAULT_CSS_GRID_LAYOUT_ENABLED false
-#endif
-
</del><span class="cx"> #define FOR_EACH_WEBKIT_BOOL_PREFERENCE(macro) \
</span><span class="cx"> macro(JavaScriptEnabled, javaScriptEnabled, Bool, bool, true) \
</span><span class="cx"> macro(JavaScriptMarkupEnabled, javaScriptMarkupEnabled, Bool, bool, true) \
</span><span class="lines">@@ -139,7 +133,7 @@
</span><span class="cx"> macro(Accelerated2dCanvasEnabled, accelerated2dCanvasEnabled, Bool, bool, false) \
</span><span class="cx"> macro(CSSRegionsEnabled, cssRegionsEnabled, Bool, bool, true) \
</span><span class="cx"> macro(CSSCompositingEnabled, cssCompositingEnabled, Bool, bool, true) \
</span><del>- macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, DEFAULT_CSS_GRID_LAYOUT_ENABLED) \
</del><ins>+ macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, true) \
</ins><span class="cx"> macro(RegionBasedColumnsEnabled, regionBasedColumnsEnabled, Bool, bool, false) \
</span><span class="cx"> macro(ForceFTPDirectoryListings, forceFTPDirectoryListings, Bool, bool, false) \
</span><span class="cx"> macro(TabsToLinks, tabsToLinks, Bool, bool, DEFAULT_WEBKIT_TABSTOLINKS_ENABLED) \
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessgtkExperimentalFeaturescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp (167992 => 167993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp 2014-04-30 08:37:35 UTC (rev 167992)
+++ trunk/Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.cpp 2014-04-30 08:54:39 UTC (rev 167993)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> static Setting settings[] = {
</span><del>- { ExperimentalFeatures::CSSGridLayout, "CSS_GRID_LAYOUT", false },
</del><ins>+ { ExperimentalFeatures::CSSGridLayout, "CSS_GRID_LAYOUT", true },
</ins><span class="cx"> { ExperimentalFeatures::RegionBasedColumns, "REGION_BASED_COLUMNS", false }
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>