<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167954] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167954">167954</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-04-29 13:33:43 -0700 (Tue, 29 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/167906">r167906</a>?): js/dom/basic-weakmap.html is much more flaky than before
<https://webkit.org/b/132322>
Remove the part of js/dom/basic-weakmap.html that expects deterministic behavior
from our non-deterministic GC.
Rubber-stamped by Phil Pizlo.
* TestExpectations:
* js/dom/basic-weakmap-expected.txt:
* js/dom/script-tests/basic-weakmap.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsjsdombasicweakmapexpectedtxt">trunk/LayoutTests/js/dom/basic-weakmap-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdomscripttestsbasicweakmapjs">trunk/LayoutTests/js/dom/script-tests/basic-weakmap.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (167953 => 167954)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-04-29 20:28:37 UTC (rev 167953)
+++ trunk/LayoutTests/ChangeLog 2014-04-29 20:33:43 UTC (rev 167954)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-04-29 Andreas Kling <akling@apple.com>
+
+ REGRESSION (r167906?): js/dom/basic-weakmap.html is much more flaky than before
+ <https://webkit.org/b/132322>
+
+ Remove the part of js/dom/basic-weakmap.html that expects deterministic behavior
+ from our non-deterministic GC.
+
+ Rubber-stamped by Phil Pizlo.
+
+ * TestExpectations:
+ * js/dom/basic-weakmap-expected.txt:
+ * js/dom/script-tests/basic-weakmap.js:
+
</ins><span class="cx"> 2014-04-29 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><span class="cx"> String.prototype.trim removes U+200B from strings.
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (167953 => 167954)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2014-04-29 20:28:37 UTC (rev 167953)
+++ trunk/LayoutTests/TestExpectations 2014-04-29 20:33:43 UTC (rev 167954)
</span><span class="lines">@@ -106,6 +106,3 @@
</span><span class="cx">
</span><span class="cx"> # Expando properties on attribute nodes disappear
</span><span class="cx"> webkit.org/b/88045 fast/dom/gc-attribute-node.html [ Failure Pass ]
</span><del>-
-# REGRESSION (r167906?): js/dom/basic-weakmap.html is much more flaky than before
-webkit.org/b/132322 js/dom/basic-weakmap.html [ Failure Pass ]
</del></span></pre></div>
<a id="trunkLayoutTestsjsdombasicweakmapexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/basic-weakmap-expected.txt (167953 => 167954)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/basic-weakmap-expected.txt 2014-04-29 20:28:37 UTC (rev 167953)
+++ trunk/LayoutTests/js/dom/basic-weakmap-expected.txt 2014-04-29 20:33:43 UTC (rev 167954)
</span><span class="lines">@@ -38,8 +38,6 @@
</span><span class="cx"> PASS map.set(new String('foo'), 'foo') is map
</span><span class="cx"> PASS map.get(new String('foo')) is undefined
</span><span class="cx"> PASS map.has(new String('foo')) is false
</span><del>-PASS Math.abs(currentObjectCount - keyLessObjectCount) < 100 is true
-PASS (keyLessObjectCount - valueLessObjectCount) > 1500 is true
</del><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomscripttestsbasicweakmapjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/script-tests/basic-weakmap.js (167953 => 167954)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/script-tests/basic-weakmap.js 2014-04-29 20:28:37 UTC (rev 167953)
+++ trunk/LayoutTests/js/dom/script-tests/basic-weakmap.js 2014-04-29 20:33:43 UTC (rev 167954)
</span><span class="lines">@@ -41,34 +41,3 @@
</span><span class="cx"> shouldBe("map.set(new String('foo'), 'foo')", "map");
</span><span class="cx"> shouldBe("map.get(new String('foo'))", "undefined");
</span><span class="cx"> shouldBeFalse("map.has(new String('foo'))");
</span><del>-
-var keys = [];
-var values = [];
-
-var count = 2000;
-for (var i = 0; i < count; i++) {
- keys[i] = {}
- values[i] = {v : keys[i]}
- keys[i].v = values[i]
-}
-for (var i = 0; i < count; i++) {
- map.set(keys[i], values[i])
-}
-gc();
-
-if (this.GCController) {
- var currentObjectCount = GCController.getJSObjectCount()
- keys = null;
- gc();
- var keyLessObjectCount = GCController.getJSObjectCount()
- // Somewhat approximate
- shouldBeTrue("Math.abs(currentObjectCount - keyLessObjectCount) < 100");
- for (var i = 0; i < count; i++) {
- if (map.get(values[i].v) != values[i])
- fail("Key was incorrectly removed from weak map");
- }
- values = null;
- gc();
- var valueLessObjectCount = GCController.getJSObjectCount()
- shouldBeTrue("(keyLessObjectCount - valueLessObjectCount) > " + (count * 3 / 4));
-}
</del></span></pre>
</div>
</div>
</body>
</html>