<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167892] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167892">167892</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2014-04-28 10:28:13 -0700 (Mon, 28 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS WK2] Make subview rebuilding more incremental
https://bugs.webkit.org/show_bug.cgi?id=132162
<rdar://problem/16718916>
Reviewed by Sam Weinig.
Previously we did bulk replacement of subviews, but that triggers
UIKit to send spurious will/DidMoveToWindow messages, which can
interfere with UIScrollView scrolling.
Make _web_setSubviews more incremental, only removing
deleted subviews, adding new ones, and moving existing ones
into the correct order.
* Shared/mac/RemoteLayerTreePropertyApplier.mm:
(-[UIView _web_setSubviews:]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedmacRemoteLayerTreePropertyAppliermm">trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (167891 => 167892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-04-28 17:28:11 UTC (rev 167891)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-28 17:28:13 UTC (rev 167892)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2014-04-24 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ [iOS WK2] Make subview rebuilding more incremental
+ https://bugs.webkit.org/show_bug.cgi?id=132162
+ <rdar://problem/16718916>
+
+ Reviewed by Sam Weinig.
+
+ Previously we did bulk replacement of subviews, but that triggers
+ UIKit to send spurious will/DidMoveToWindow messages, which can
+ interfere with UIScrollView scrolling.
+
+ Make _web_setSubviews more incremental, only removing
+ deleted subviews, adding new ones, and moving existing ones
+ into the correct order.
+
+ * Shared/mac/RemoteLayerTreePropertyApplier.mm:
+ (-[UIView _web_setSubviews:]):
+
+2014-04-24 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> [iOS WK2] flickery scrolling with overflow-scrolling:touch
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=132150
</span><span class="cx"> <rdar://problem/16683006>
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedmacRemoteLayerTreePropertyAppliermm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm (167891 => 167892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm 2014-04-28 17:28:11 UTC (rev 167891)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm 2014-04-28 17:28:13 UTC (rev 167892)
</span><span class="lines">@@ -53,13 +53,31 @@
</span><span class="cx">
</span><span class="cx"> @implementation UIView (WKUIViewUtilities)
</span><span class="cx">
</span><del>-- (void)_web_setSubviews:(NSArray *)subviews
</del><ins>+- (void)_web_setSubviews:(NSArray *)newSubviews
</ins><span class="cx"> {
</span><del>- for (UIView* subview in self.subviews)
- [subview removeFromSuperview];
</del><ins>+ NSUInteger numOldSubviews = self.subviews.count;
+ NSUInteger numNewSubviews = newSubviews.count;
</ins><span class="cx">
</span><del>- for (UIView* view in subviews)
- [self addSubview:view];
</del><ins>+ NSUInteger currIndex = 0;
+ for (currIndex = 0; currIndex < numNewSubviews; ++currIndex) {
+ UIView *currNewSubview = [newSubviews objectAtIndex:currIndex];
+
+ if (currIndex < numOldSubviews) {
+ UIView *existingSubview = [self.subviews objectAtIndex:currIndex];
+ if (existingSubview == currNewSubview)
+ continue;
+ }
+
+ // New or moved subview.
+ [self insertSubview:currNewSubview atIndex:currIndex];
+ }
+
+ // Remove views at the end.
+ NSUInteger remainingSubviews = self.subviews.count;
+ for (NSUInteger i = currIndex; i < remainingSubviews; ++i)
+ [[self.subviews objectAtIndex:currIndex] removeFromSuperview];
+
+ ASSERT([self.subviews isEqualToArray:newSubviews]);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> @end
</span></span></pre>
</div>
</div>
</body>
</html>