<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167906] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167906">167906</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2014-04-28 14:14:48 -0700 (Mon, 28 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>
Source/JavaScriptCore: The LLInt is awesome and it should get more of the action.
Rubber stamped by Geoffrey Garen.
5% speed-up on JSBench and no meaningful regressions. Should be a PLT/DYE speed-up also.
* runtime/Options.h:
Tools: Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
"no-cjit" runs force the old-school threshold.
Rubber stamped by Mark Hahnenberg.
* Scripts/run-jsc-stress-tests:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeOptionsh">trunk/Source/JavaScriptCore/runtime/Options.h</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsrunjscstresstests">trunk/Tools/Scripts/run-jsc-stress-tests</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (167905 => 167906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-04-28 21:07:08 UTC (rev 167905)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-04-28 21:14:48 UTC (rev 167906)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-04-28 Filip Pizlo <fpizlo@apple.com>
+
+ The LLInt is awesome and it should get more of the action.
+
+ Rubber stamped by Geoffrey Garen.
+
+ 5% speed-up on JSBench and no meaningful regressions. Should be a PLT/DYE speed-up also.
+
+ * runtime/Options.h:
+
</ins><span class="cx"> 2014-04-27 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> GC should be able to remove things from the DFG worklist and cancel on-going compilations if it knows that the compilation would already be invalidated
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeOptionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Options.h (167905 => 167906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Options.h 2014-04-28 21:07:08 UTC (rev 167905)
+++ trunk/Source/JavaScriptCore/runtime/Options.h 2014-04-28 21:14:48 UTC (rev 167906)
</span><span class="lines">@@ -204,7 +204,7 @@
</span><span class="cx"> v(unsigned, maximumBinaryStringSwitchCaseLength, 50) \
</span><span class="cx"> v(unsigned, maximumBinaryStringSwitchTotalLength, 2000) \
</span><span class="cx"> \
</span><del>- v(int32, thresholdForJITAfterWarmUp, 100) \
</del><ins>+ v(int32, thresholdForJITAfterWarmUp, 500) \
</ins><span class="cx"> v(int32, thresholdForJITSoon, 100) \
</span><span class="cx"> \
</span><span class="cx"> v(int32, thresholdForOptimizeAfterWarmUp, 1000) \
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (167905 => 167906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-04-28 21:07:08 UTC (rev 167905)
+++ trunk/Tools/ChangeLog 2014-04-28 21:14:48 UTC (rev 167906)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-04-28 Filip Pizlo <fpizlo@apple.com>
+
+ Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
+ "no-cjit" runs force the old-school threshold.
+
+ Rubber stamped by Mark Hahnenberg.
+
+ * Scripts/run-jsc-stress-tests:
+
</ins><span class="cx"> 2014-04-28 Carlos Alberto Lopez Perez <clopez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] install-dependencies should also install ruby-json and ruby-highline
</span></span></pre></div>
<a id="trunkToolsScriptsrunjscstresstests"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/run-jsc-stress-tests (167905 => 167906)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/run-jsc-stress-tests 2014-04-28 21:07:08 UTC (rev 167905)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2014-04-28 21:14:48 UTC (rev 167906)
</span><span class="lines">@@ -179,9 +179,8 @@
</span><span class="cx"> $numFailures = 0
</span><span class="cx">
</span><span class="cx"> EAGER_OPTIONS = ["--thresholdForJITAfterWarmUp=10", "--thresholdForJITSoon=10", "--thresholdForOptimizeAfterWarmUp=20", "--thresholdForOptimizeAfterLongWarmUp=20", "--thresholdForOptimizeSoon=20", "--thresholdForFTLOptimizeAfterWarmUp=20", "--thresholdForFTLOptimizeSoon=20"]
</span><del>-
</del><ins>+NO_CJIT_OPTIONS = ["--enableConcurrentJIT=false", "--thresholdForJITAfterWarmUp=100"]
</ins><span class="cx"> NO_FTL_OPTIONS = ["--useFTLJIT=false"]
</span><del>-
</del><span class="cx"> FTL_OPTIONS = ["--useFTLJIT=true", "--enableExperimentalFTLCoverage=true"]
</span><span class="cx">
</span><span class="cx"> $runlist = []
</span><span class="lines">@@ -532,11 +531,11 @@
</span><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runNoCJITValidate
</span><del>- run("no-cjit", "--enableConcurrentJIT=false", "--validateBytecode=true", "--validateGraph=true")
</del><ins>+ run("no-cjit", "--validateBytecode=true", "--validateGraph=true", *NO_CJIT_OPTIONS)
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runNoCJITValidatePhases
</span><del>- run("no-cjit-validate-phases", "--enableConcurrentJIT=false", "--validateBytecode=true", "--validateGraphAtEachPhase=true")
</del><ins>+ run("no-cjit-validate-phases", "--validateBytecode=true", "--validateGraphAtEachPhase=true", *NO_CJIT_OPTIONS)
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runDefaultFTL
</span><span class="lines">@@ -544,19 +543,19 @@
</span><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runFTLNoCJIT
</span><del>- run("ftl-no-cjit", "--enableConcurrentJIT=false", *FTL_OPTIONS) if $enableFTL
</del><ins>+ run("ftl-no-cjit", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runFTLNoCJITValidate
</span><del>- run("ftl-no-cjit-validate", "--enableConcurrentJIT=false", "--validateGraph=true", *FTL_OPTIONS) if $enableFTL
</del><ins>+ run("ftl-no-cjit-validate", "--validateGraph=true", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runFTLNoCJITNoInlineValidate
</span><del>- run("ftl-no-cjit-no-inline-validate", "--enableConcurrentJIT=false", "--validateGraph=true", "--maximumInliningDepth=1", "--maximumInliningDepthForMustInline=1", *FTL_OPTIONS) if $enableFTL
</del><ins>+ run("ftl-no-cjit-no-inline-validate", "--validateGraph=true", "--maximumInliningDepth=1", "--maximumInliningDepthForMustInline=1", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runFTLNoCJITOSRValidation
</span><del>- run("ftl-no-cjit-osr-validation", "--enableConcurrentJIT=false", "--validateFTLOSRExitLiveness=true", *FTL_OPTIONS) if $enableFTL
</del><ins>+ run("ftl-no-cjit-osr-validation", "--validateFTLOSRExitLiveness=true", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runDFGEager
</span><span class="lines">@@ -564,7 +563,7 @@
</span><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runDFGEagerNoCJITValidate
</span><del>- run("dfg-eager-no-cjit-validate", "--enableConcurrentJIT=false", "--validateGraph=true", *EAGER_OPTIONS)
</del><ins>+ run("dfg-eager-no-cjit-validate", "--validateGraph=true", *(EAGER_OPTIONS + NO_CJIT_OPTIONS))
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runFTLEager
</span><span class="lines">@@ -572,11 +571,11 @@
</span><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runFTLEagerNoCJITValidate
</span><del>- run("ftl-eager-no-cjit", "--enableConcurrentJIT=false", "--validateGraph=true", *(FTL_OPTIONS + EAGER_OPTIONS)) if $enableFTL
</del><ins>+ run("ftl-eager-no-cjit", "--validateGraph=true", *(FTL_OPTIONS + EAGER_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runFTLEagerNoCJITOSRValidation
</span><del>- run("ftl-eager-no-cjit-osr-validation", "--enableConcurrentJIT=false", "--validateFTLOSRExitLiveness=true", *(FTL_OPTIONS + EAGER_OPTIONS)) if $enableFTL
</del><ins>+ run("ftl-eager-no-cjit-osr-validation", "--validateFTLOSRExitLiveness=true", *(FTL_OPTIONS + EAGER_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runAlwaysTriggerCopyPhase
</span><span class="lines">@@ -584,19 +583,19 @@
</span><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runNoCJITNoASO
</span><del>- run("no-cjit-no-aso", "--enableConcurrentJIT=false", "--enableArchitectureSpecificOptimizations=false")
</del><ins>+ run("no-cjit-no-aso", "--enableArchitectureSpecificOptimizations=false", *NO_CJIT_OPTIONS)
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runFTLNoCJITNoSimpleOpt
</span><del>- run("ftl-no-cjit-no-simple-opt", "--enableConcurrentJIT=false", "--llvmSimpleOpt=false", *FTL_OPTIONS) if $enableFTL
</del><ins>+ run("ftl-no-cjit-no-simple-opt", "--llvmSimpleOpt=false", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runNoCJITNoAccessInlining
</span><del>- run("no-cjit-no-access-inlining", "--enableConcurrentJIT=false", "--enableAccessInlining=false")
</del><ins>+ run("no-cjit-no-access-inlining", "--enableAccessInlining=false", *NO_CJIT_OPTIONS)
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runFTLNoCJITNoAccessInlining
</span><del>- run("ftl-no-cjit-no-access-inlining", "--enableConcurrentJIT=false", "--enableAccessInlining=false", *FTL_OPTIONS) if $enableFTL
</del><ins>+ run("ftl-no-cjit-no-access-inlining", "--enableAccessInlining=false", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def defaultRun
</span><span class="lines">@@ -682,11 +681,11 @@
</span><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runLayoutTestNoCJIT
</span><del>- runLayoutTest("no-cjit", "--enableConcurrentJIT=false")
</del><ins>+ runLayoutTest("no-cjit", *NO_CJIT_OPTIONS)
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runLayoutTestDFGEagerNoCJIT
</span><del>- runLayoutTest("dfg-eager-no-cjit", "--enableConcurrentJIT=false", *EAGER_OPTIONS)
</del><ins>+ runLayoutTest("dfg-eager-no-cjit", *(EAGER_OPTIONS + NO_CJIT_OPTIONS))
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runLayoutTestDefaultFTL
</span><span class="lines">@@ -694,11 +693,11 @@
</span><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runLayoutTestFTLNoCJIT
</span><del>- runLayoutTest("ftl-no-cjit", "--testTheFTL=true", "--enableConcurrentJIT=false", *FTL_OPTIONS) if $enableFTL
</del><ins>+ runLayoutTest("ftl-no-cjit", "--testTheFTL=true", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runLayoutTestFTLEagerNoCJIT
</span><del>- runLayoutTest("ftl-eager-no-cjit", "--testTheFTL=true", "--enableConcurrentJIT=false", *(FTL_OPTIONS + EAGER_OPTIONS)) if $enableFTL
</del><ins>+ runLayoutTest("ftl-eager-no-cjit", "--testTheFTL=true", *(FTL_OPTIONS + EAGER_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def noFTLRunLayoutTest
</span><span class="lines">@@ -781,11 +780,11 @@
</span><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runMozillaTestDFGEagerNoCJITValidatePhases(mode, *extraFiles)
</span><del>- runMozillaTest("dfg-eager-no-cjit-validate-phases", mode, extraFiles, "--enableConcurrentJIT=false", "--validateBytecode=true", "--validateGraphAtEachPhase=true", *EAGER_OPTIONS)
</del><ins>+ runMozillaTest("dfg-eager-no-cjit-validate-phases", mode, extraFiles, "--validateBytecode=true", "--validateGraphAtEachPhase=true", *(EAGER_OPTIONS + NO_CJIT_OPTIONS))
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def runMozillaTestFTLEagerNoCJITValidatePhases(mode, *extraFiles)
</span><del>- runMozillaTest("ftl-eager-no-cjit-validate-phases", mode, extraFiles, "--enableConcurrentJIT=false", "--validateBytecode=true", "--validateGraphAtEachPhase=true", *(FTL_OPTIONS + EAGER_OPTIONS)) if $enableFTL
</del><ins>+ runMozillaTest("ftl-eager-no-cjit-validate-phases", mode, extraFiles, "--validateBytecode=true", "--validateGraphAtEachPhase=true", *(FTL_OPTIONS + EAGER_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL
</ins><span class="cx"> end
</span><span class="cx">
</span><span class="cx"> def defaultRunMozillaTest(mode, *extraFiles)
</span></span></pre>
</div>
</div>
</body>
</html>