<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167840] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167840">167840</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-04-25 21:41:42 -0700 (Fri, 25 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/167689">r167689</a>): Hovering file name in a file input causes a crash
https://bugs.webkit.org/show_bug.cgi?id=132214
Reviewed by Andreas Kling.
Source/WebCore:
The bug was caused by callDefaultEventHandlersInTheBubblingOrder unconditionally
accessing path.contextAt(0) even if the event path was empty.
Fixed the bug by exiting early when the event path is empty.
Test: fast/events/shadow-event-path-2.html
* dom/EventDispatcher.cpp:
(WebCore::callDefaultEventHandlersInTheBubblingOrder):
LayoutTests:
Add a regression test.
* fast/events/shadow-event-path-2-expected.txt: Added.
* fast/events/shadow-event-path-2.html: Added.
* fast/events/shadow-event-path.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventsshadoweventpathhtml">trunk/LayoutTests/fast/events/shadow-event-path.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomEventDispatchercpp">trunk/Source/WebCore/dom/EventDispatcher.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasteventsshadoweventpath2expectedtxt">trunk/LayoutTests/fast/events/shadow-event-path-2-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsshadoweventpath2html">trunk/LayoutTests/fast/events/shadow-event-path-2.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (167839 => 167840)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-04-26 03:54:33 UTC (rev 167839)
+++ trunk/LayoutTests/ChangeLog        2014-04-26 04:41:42 UTC (rev 167840)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-04-25 Ryosuke Niwa <rniwa@webkit.org>
+
+ REGRESSION (r167689): Hovering file name in a file input causes a crash
+ https://bugs.webkit.org/show_bug.cgi?id=132214
+
+ Reviewed by Andreas Kling.
+
+ Add a regression test.
+
+ * fast/events/shadow-event-path-2-expected.txt: Added.
+ * fast/events/shadow-event-path-2.html: Added.
+ * fast/events/shadow-event-path.html:
+
</ins><span class="cx"> 2014-04-25 Oliver Hunt <oliver@apple.com>
</span><span class="cx">
</span><span class="cx"> Need earlier cell test
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsshadoweventpath2expectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/shadow-event-path-2-expected.txt (0 => 167840)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/shadow-event-path-2-expected.txt         (rev 0)
+++ trunk/LayoutTests/fast/events/shadow-event-path-2-expected.txt        2014-04-26 04:41:42 UTC (rev 167840)
</span><span class="lines">@@ -0,0 +1,1246 @@
</span><ins>+This test records target and relatedTarget at each element while dispatching a mouse click event at an input element.
+
+
+Content:<div id="detailsContainer"><input id="target" type="file"></div>
+
+mouseover@html
+ target:html
+ relatedTarget:null
+
+mouseover@document
+ target:html
+ relatedTarget:null
+
+mouseover@window
+ target:html
+ relatedTarget:null
+
+mouseenter@html
+ target:html
+ relatedTarget:null
+
+mousemove@html
+ target:html
+ relatedTarget:null
+
+mousemove@document
+ target:html
+ relatedTarget:null
+
+mousemove@window
+ target:html
+ relatedTarget:null
+
+mouseout@html
+ target:html
+ relatedTarget:input#target
+
+mouseout@document
+ target:html
+ relatedTarget:input#target
+
+mouseout@window
+ target:html
+ relatedTarget:input#target
+
+mouseover@input#target
+ target:input#target
+ relatedTarget:html
+
+mouseover@div#detailsContainer
+ target:input#target
+ relatedTarget:html
+
+mouseover@body
+ target:input#target
+ relatedTarget:html
+
+mouseover@html
+ target:input#target
+ relatedTarget:html
+
+mouseover@document
+ target:input#target
+ relatedTarget:html
+
+mouseover@window
+ target:input#target
+ relatedTarget:html
+
+mouseenter@input#target
+ target:input#target
+ relatedTarget:html
+
+mouseenter@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:html
+
+mouseenter@body
+ target:body
+ relatedTarget:html
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mousemove@input#target
+ target:input#target
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:input#target
+ relatedTarget:null
+
+mousemove@body
+ target:input#target
+ relatedTarget:null
+
+mousemove@html
+ target:input#target
+ relatedTarget:null
+
+mousemove@document
+ target:input#target
+ relatedTarget:null
+
+mousemove@window
+ target:input#target
+ relatedTarget:null
+
+mouseout@input#target
+ target:input#target
+ relatedTarget:div#detailsContainer
+
+mouseout@div#detailsContainer
+ target:input#target
+ relatedTarget:div#detailsContainer
+
+mouseout@body
+ target:input#target
+ relatedTarget:div#detailsContainer
+
+mouseout@html
+ target:input#target
+ relatedTarget:div#detailsContainer
+
+mouseout@document
+ target:input#target
+ relatedTarget:div#detailsContainer
+
+mouseout@window
+ target:input#target
+ relatedTarget:div#detailsContainer
+
+mouseleave@input#target
+ target:input#target
+ relatedTarget:div#detailsContainer
+
+mouseover@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:input#target
+
+mouseover@body
+ target:div#detailsContainer
+ relatedTarget:input#target
+
+mouseover@html
+ target:div#detailsContainer
+ relatedTarget:input#target
+
+mouseover@document
+ target:div#detailsContainer
+ relatedTarget:input#target
+
+mouseover@window
+ target:div#detailsContainer
+ relatedTarget:input#target
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@div#detailsContainer
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@body
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@html
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@document
+ target:div#detailsContainer
+ relatedTarget:null
+
+mousemove@window
+ target:div#detailsContainer
+ relatedTarget:null
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventsshadoweventpath2html"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/shadow-event-path-2.html (0 => 167840)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/shadow-event-path-2.html         (rev 0)
+++ trunk/LayoutTests/fast/events/shadow-event-path-2.html        2014-04-26 04:41:42 UTC (rev 167840)
</span><span class="lines">@@ -0,0 +1,23 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<p>This test records target and relatedTarget at each element while dispatching a mouse click event at an input element.</p>
+<div id="detailsContainer"><input id="target" type="file"></div>
+<pre id="log"></pre>
+<script src="resources/shadow-event-path-shared.js"></script>
+<script>
+
+var detailsContainer = document.getElementById('detailsContainer');
+log('Content:' + detailsContainer.outerHTML + '\n');
+
+if (window.testRunner && !window.eventSender)
+ log('This test requires eventSender.');
+else if (window.eventSender) {
+ var target = document.getElementById('target');
+ for (var x = -10; x <= 500; x += 10)
+ eventSender.mouseMoveTo(target.offsetLeft + x, target.offsetTop + target.offsetHeight / 2);
+}
+
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventsshadoweventpathhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/shadow-event-path.html (167839 => 167840)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/shadow-event-path.html        2014-04-26 03:54:33 UTC (rev 167839)
+++ trunk/LayoutTests/fast/events/shadow-event-path.html        2014-04-26 04:41:42 UTC (rev 167840)
</span><span class="lines">@@ -4,62 +4,22 @@
</span><span class="cx"> <p>This test records target and relatedTarget at each element while dispatching a mouse click event at an input element.</p>
</span><span class="cx"> <div id="detailsContainer"><details><summary><div id="divInsideSummary"><input id="target" type="text" size="10"></summary></div></detials></div>
</span><span class="cx"> <pre id="log"></pre>
</span><ins>+<script src="resources/shadow-event-path-shared.js"></script>
</ins><span class="cx"> <script>
</span><span class="cx">
</span><del>-if (window.testRunner)
- testRunner.dumpAsText();
</del><ins>+var detailsContainer = document.getElementById('detailsContainer');
+log('Content:' + detailsContainer.outerHTML + '\n');
</ins><span class="cx">
</span><del>-function targetIdentifier(target) {
- if (target === undefined || target === null)
- return target;
- if (target === window)
- return 'window';
- if (target === document)
- return 'document';
- return target.localName + (target.id ? '#' + target.id : '');
-}
-
-function attachListeners(eventname) {
- var targets = Array.prototype.slice.call(document.querySelectorAll('*'));
- targets.push(window);
- targets.push(document);
- targets.forEach(function (target) {
- target.addEventListener(eventname, function (event) {
- log.textContent += eventname + '@' + targetIdentifier(target) + '\n'
- + ' target:' + targetIdentifier(event.target) + '\n'
- + ' relatedTarget:' + targetIdentifier(event.relatedTarget) + '\n\n';
- });
- });
-}
-
-var log = document.getElementById('log');
-log.textContent = 'Content:' + detailsContainer.outerHTML + '\n\n';
-var target = document.getElementById('target');
-
-attachListeners('mousemove');
-attachListeners('mousedown');
-attachListeners('mouseover');
-attachListeners('mouseout');
-attachListeners('mouseenter');
-attachListeners('mouseleave');
-attachListeners('mouseup');
-attachListeners('click');
-
-function runTest() {
- testRunner.waitUntilDone();
</del><ins>+if (window.testRunner && !window.eventSender)
+ log('This test requires eventSender.');
+else if (window.eventSender) {
+ var target = document.getElementById('target');
</ins><span class="cx"> eventSender.mouseMoveTo(target.offsetLeft + target.offsetWidth / 2, target.offsetTop + target.offsetHeight / 2);
</span><span class="cx"> eventSender.mouseMoveTo(target.offsetLeft + target.offsetWidth + 100, target.offsetTop + target.offsetHeight / 2);
</span><span class="cx"> eventSender.mouseDown();
</span><span class="cx"> eventSender.mouseUp();
</span><del>- testRunner.notifyDone();
</del><span class="cx"> }
</span><span class="cx">
</span><del>-if (window.testRunner && !window.eventSender)
- log.textContent += 'This test requires eventSender.';
-else if (window.eventSender) {
- window.onload = runTest;
-}
-
</del><span class="cx"> </script>
</span><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (167839 => 167840)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-04-26 03:54:33 UTC (rev 167839)
+++ trunk/Source/WebCore/ChangeLog        2014-04-26 04:41:42 UTC (rev 167840)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-04-25 Ryosuke Niwa <rniwa@webkit.org>
+
+ REGRESSION (r167689): Hovering file name in a file input causes a crash
+ https://bugs.webkit.org/show_bug.cgi?id=132214
+
+ Reviewed by Andreas Kling.
+
+ The bug was caused by callDefaultEventHandlersInTheBubblingOrder unconditionally
+ accessing path.contextAt(0) even if the event path was empty.
+
+ Fixed the bug by exiting early when the event path is empty.
+
+ Test: fast/events/shadow-event-path-2.html
+
+ * dom/EventDispatcher.cpp:
+ (WebCore::callDefaultEventHandlersInTheBubblingOrder):
+
</ins><span class="cx"> 2014-04-25 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r167828): http/tests/media/hls/video-controls-live-stream.html fails
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventDispatchercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (167839 => 167840)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventDispatcher.cpp        2014-04-26 03:54:33 UTC (rev 167839)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp        2014-04-26 04:41:42 UTC (rev 167840)
</span><span class="lines">@@ -262,6 +262,9 @@
</span><span class="cx">
</span><span class="cx"> static void callDefaultEventHandlersInTheBubblingOrder(Event& event, const EventPath& path)
</span><span class="cx"> {
</span><ins>+ if (path.isEmpty())
+ return;
+
</ins><span class="cx"> // Non-bubbling events call only one default event handler, the one for the target.
</span><span class="cx"> path.contextAt(0).node()->defaultEventHandler(&event);
</span><span class="cx"> ASSERT(!event.defaultPrevented());
</span></span></pre>
</div>
</div>
</body>
</html>