<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167819] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167819">167819</a></dd>
<dt>Author</dt> <dd>msaboff@apple.com</dd>
<dt>Date</dt> <dd>2014-04-25 13:34:47 -0700 (Fri, 25 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Crash in platform/mac/accessibility/table-visible-rows.html
https://bugs.webkit.org/show_bug.cgi?id=132146
Reviewed by Mark Lam.
Changed to use a local JSValueRef array temporary instead of a
std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
JSValues are visited during garbage collection when the stack is scanned. Otherwise,
the temporary values could be collected.
* DumpRenderTree/AccessibilityUIElement.cpp:
(convertElementsToObjectArray):
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::contextClick):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::convertElementsToObjectArray):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreeAccessibilityUIElementcpp">trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleEventSendingControllercpp">trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundlemacAccessibilityUIElementMacmm">trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (167818 => 167819)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-04-25 20:30:07 UTC (rev 167818)
+++ trunk/Tools/ChangeLog 2014-04-25 20:34:47 UTC (rev 167819)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-04-25 Michael Saboff <msaboff@apple.com>
+
+ Crash in platform/mac/accessibility/table-visible-rows.html
+ https://bugs.webkit.org/show_bug.cgi?id=132146
+
+ Reviewed by Mark Lam.
+
+ Changed to use a local JSValueRef array temporary instead of a
+ std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
+ JSValues are visited during garbage collection when the stack is scanned. Otherwise,
+ the temporary values could be collected.
+
+ * DumpRenderTree/AccessibilityUIElement.cpp:
+ (convertElementsToObjectArray):
+ * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
+ (WTR::EventSendingController::contextClick):
+ * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+ (WTR::convertElementsToObjectArray):
+
</ins><span class="cx"> 2014-04-24 Eduardo Lima Mitev <elima@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed GTK gardening
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeAccessibilityUIElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp (167818 => 167819)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp 2014-04-25 20:30:07 UTC (rev 167818)
+++ trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp 2014-04-25 20:34:47 UTC (rev 167819)
</span><span class="lines">@@ -519,11 +519,11 @@
</span><span class="cx"> static JSValueRef convertElementsToObjectArray(JSContextRef context, Vector<AccessibilityUIElement>& elements, JSValueRef* exception)
</span><span class="cx"> {
</span><span class="cx"> size_t elementCount = elements.size();
</span><del>- auto valueElements = std::make_unique<JSValueRef[]>(elementCount);
</del><ins>+ JSValueRef valueElements[elementCount];
</ins><span class="cx"> for (size_t i = 0; i < elementCount; ++i)
</span><span class="cx"> valueElements[i] = AccessibilityUIElement::makeJSAccessibilityUIElement(context, elements[i]);
</span><span class="cx">
</span><del>- return JSObjectMakeArray(context, elementCount, valueElements.get(), exception);
</del><ins>+ return JSObjectMakeArray(context, elementCount, valueElements, exception);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static JSValueRef columnHeadersCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleEventSendingControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp (167818 => 167819)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp 2014-04-25 20:30:07 UTC (rev 167818)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp 2014-04-25 20:34:47 UTC (rev 167819)
</span><span class="lines">@@ -438,7 +438,7 @@
</span><span class="cx">
</span><span class="cx"> WKRetainPtr<WKArrayRef> menuEntries = adoptWK(WKBundlePageCopyContextMenuItems(page));
</span><span class="cx"> size_t entriesSize = WKArrayGetSize(menuEntries.get());
</span><del>- auto jsValuesArray = std::make_unique<JSValueRef[]>(entriesSize);
</del><ins>+ JSValueRef jsValuesArray[entriesSize];
</ins><span class="cx"> for (size_t i = 0; i < entriesSize; ++i) {
</span><span class="cx"> ASSERT(WKGetTypeID(WKArrayGetItemAtIndex(menuEntries.get(), i)) == WKContextMenuItemGetTypeID());
</span><span class="cx">
</span><span class="lines">@@ -447,7 +447,7 @@
</span><span class="cx"> jsValuesArray[i] = JSObjectMake(context, getMenuItemClass(), privateData);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return JSObjectMakeArray(context, entriesSize, jsValuesArray.get(), 0);
</del><ins>+ return JSObjectMakeArray(context, entriesSize, jsValuesArray, 0);
</ins><span class="cx"> #else
</span><span class="cx"> return JSValueMakeUndefined(context);
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundlemacAccessibilityUIElementMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm (167818 => 167819)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2014-04-25 20:30:07 UTC (rev 167818)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2014-04-25 20:34:47 UTC (rev 167819)
</span><span class="lines">@@ -179,11 +179,11 @@
</span><span class="cx"> static JSValueRef convertElementsToObjectArray(JSContextRef context, Vector<RefPtr<AccessibilityUIElement>>& elements)
</span><span class="cx"> {
</span><span class="cx"> size_t elementCount = elements.size();
</span><del>- auto valueElements = std::make_unique<JSValueRef[]>(elementCount);
</del><ins>+ JSValueRef valueElements[elementCount];
</ins><span class="cx"> for (size_t i = 0; i < elementCount; ++i)
</span><span class="cx"> valueElements[i] = JSObjectMake(context, elements[i]->wrapperClass(), elements[i].get());
</span><span class="cx">
</span><del>- return JSObjectMakeArray(context, elementCount, valueElements.get(), nullptr);
</del><ins>+ return JSObjectMakeArray(context, elementCount, valueElements, nullptr);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static JSStringRef concatenateAttributeAndValue(NSString* attribute, NSString* value)
</span></span></pre>
</div>
</div>
</body>
</html>