<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167796] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167796">167796</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-04-25 01:04:28 -0700 (Fri, 25 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Incomplete body painting when using blend modes
https://bugs.webkit.org/show_bug.cgi?id=131889
Source/WebCore:
The incomplete painting was caused by the transparency layer created for
the root renderer. We can safely skip creating this transparency layer at
the root level, as there is nothing else being painted behind this layer that
could be used erroneously as a backdrop.
Patch by Ion Rosca <rosca@adobe.com> on 2014-04-25
Reviewed by Simon Fraser.
Test: css3/compositing/blend-mode-with-body.html
* rendering/RenderLayer.h:
Changing RenderLayer::paintsWithTransparency so that it will not
return true when the root renderer needs to isolate blending.
LayoutTests:
Patch by Ion Rosca <rosca@adobe.com> on 2014-04-25
Reviewed by Simon Fraser.
* css3/compositing/blend-mode-with-body-expected.html: Added.
* css3/compositing/blend-mode-with-body.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerh">trunk/Source/WebCore/rendering/RenderLayer.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscss3compositingblendmodewithbodyexpectedhtml">trunk/LayoutTests/css3/compositing/blend-mode-with-body-expected.html</a></li>
<li><a href="#trunkLayoutTestscss3compositingblendmodewithbodyhtml">trunk/LayoutTests/css3/compositing/blend-mode-with-body.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (167795 => 167796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-04-25 07:58:31 UTC (rev 167795)
+++ trunk/LayoutTests/ChangeLog 2014-04-25 08:04:28 UTC (rev 167796)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-04-25 Ion Rosca <rosca@adobe.com>
+
+ Incomplete body painting when using blend modes
+ https://bugs.webkit.org/show_bug.cgi?id=131889
+
+ Reviewed by Simon Fraser.
+
+ * css3/compositing/blend-mode-with-body-expected.html: Added.
+ * css3/compositing/blend-mode-with-body.html: Added.
+
</ins><span class="cx"> 2014-04-24 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r167441.
</span></span></pre></div>
<a id="trunkLayoutTestscss3compositingblendmodewithbodyexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/compositing/blend-mode-with-body-expected.html (0 => 167796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/compositing/blend-mode-with-body-expected.html (rev 0)
+++ trunk/LayoutTests/css3/compositing/blend-mode-with-body-expected.html 2014-04-25 08:04:28 UTC (rev 167796)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+<!DOCTYPE HTML>
+<head>
+ <style>
+ body {
+ background-color: #0000ff;
+ }
+ div {
+ width: 100px;
+ height: 100px;
+ }
+ </style>
+</head>
+<body>
+ <p>This test passes if background-color fills the entire view port.</p>
+ <div></div>
+</body>
</ins></span></pre></div>
<a id="trunkLayoutTestscss3compositingblendmodewithbodyhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/compositing/blend-mode-with-body.html (0 => 167796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/compositing/blend-mode-with-body.html (rev 0)
+++ trunk/LayoutTests/css3/compositing/blend-mode-with-body.html 2014-04-25 08:04:28 UTC (rev 167796)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<!DOCTYPE HTML>
+<head>
+ <style>
+ body {
+ background-color: #0000ff;
+ }
+ div {
+ width: 100px;
+ height: 100px;
+ mix-blend-mode: difference;
+ }
+ </style>
+</head>
+<body>
+ <p>This test passes if background-color fills the entire view port.</p>
+ <div></div>
+</body>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (167795 => 167796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-25 07:58:31 UTC (rev 167795)
+++ trunk/Source/WebCore/ChangeLog 2014-04-25 08:04:28 UTC (rev 167796)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-04-25 Ion Rosca <rosca@adobe.com>
+
+ Incomplete body painting when using blend modes
+ https://bugs.webkit.org/show_bug.cgi?id=131889
+
+ The incomplete painting was caused by the transparency layer created for
+ the root renderer. We can safely skip creating this transparency layer at
+ the root level, as there is nothing else being painted behind this layer that
+ could be used erroneously as a backdrop.
+
+ Reviewed by Simon Fraser.
+
+ Test: css3/compositing/blend-mode-with-body.html
+
+ * rendering/RenderLayer.h:
+ Changing RenderLayer::paintsWithTransparency so that it will not
+ return true when the root renderer needs to isolate blending.
+
</ins><span class="cx"> 2014-04-25 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> ASSERTION FAILED: "!m_isolatedWorld->isNormal() || m_wrapper || !m_jsFunction" in svg/custom/use-instanceRoot-event-listeners.xhtml
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.h (167795 => 167796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.h 2014-04-25 07:58:31 UTC (rev 167795)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2014-04-25 08:04:28 UTC (rev 167796)
</span><span class="lines">@@ -833,7 +833,7 @@
</span><span class="cx">
</span><span class="cx"> bool paintsWithTransparency(PaintBehavior paintBehavior) const
</span><span class="cx"> {
</span><del>- return (isTransparent() || hasBlendMode() || isolatesBlending()) && ((paintBehavior & PaintBehaviorFlattenCompositingLayers) || !isComposited());
</del><ins>+ return (isTransparent() || hasBlendMode() || (isolatesBlending() && !renderer().isRoot())) && ((paintBehavior & PaintBehaviorFlattenCompositingLayers) || !isComposited());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool paintsWithTransform(PaintBehavior) const;
</span></span></pre>
</div>
</div>
</body>
</html>