<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167752] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167752">167752</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-04-24 00:17:15 -0700 (Thu, 24 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] HTML Media capture attribute is a boolean since <a href="http://trac.webkit.org/projects/webkit/changeset/163958">r163958</a>
https://bugs.webkit.org/show_bug.cgi?id=132061
Reviewed by Gustavo Noronha Silva.
Add new methods webkit_dom_html_input_element_get_capture_enabled
and webkit_dom_html_input_element_set_capture_enabled using a
boolean and deprecate the old methods.
* bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_html_input_element_get_capture):
(webkit_dom_html_input_element_set_capture):
* bindings/gobject/WebKitDOMDeprecated.h:
* bindings/gobject/WebKitDOMDeprecated.symbols:
* bindings/gobject/webkitdom.symbols:
* bindings/scripts/CodeGeneratorGObject.pm:
(GetEffectiveFunctionName): Helper function to rename API methods
for special cases.
(GenerateFunction): Use GetEffectiveFunctionName().</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedcpp">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedh">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedsymbols">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectwebkitdomsymbols">trunk/Source/WebCore/bindings/gobject/webkitdom.symbols</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (167751 => 167752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-24 07:07:06 UTC (rev 167751)
+++ trunk/Source/WebCore/ChangeLog 2014-04-24 07:17:15 UTC (rev 167752)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2014-04-23 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [GTK] HTML Media capture attribute is a boolean since r163958
+ https://bugs.webkit.org/show_bug.cgi?id=132061
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Add new methods webkit_dom_html_input_element_get_capture_enabled
+ and webkit_dom_html_input_element_set_capture_enabled using a
+ boolean and deprecate the old methods.
+
+ * bindings/gobject/WebKitDOMDeprecated.cpp:
+ (webkit_dom_html_input_element_get_capture):
+ (webkit_dom_html_input_element_set_capture):
+ * bindings/gobject/WebKitDOMDeprecated.h:
+ * bindings/gobject/WebKitDOMDeprecated.symbols:
+ * bindings/gobject/webkitdom.symbols:
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (GetEffectiveFunctionName): Helper function to rename API methods
+ for special cases.
+ (GenerateFunction): Use GetEffectiveFunctionName().
+
</ins><span class="cx"> 2014-04-23 Praveen R Jadhav <praveen.j@samsung.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream] Implement MediaStream active attribute
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp (167751 => 167752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2014-04-24 07:07:06 UTC (rev 167751)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2014-04-24 07:17:15 UTC (rev 167752)
</span><span class="lines">@@ -657,3 +657,16 @@
</span><span class="cx"> {
</span><span class="cx"> g_warning("%s: Access to the DOM Shadow Root has been removed from WebKit, this function does nothing.", __func__);
</span><span class="cx"> }
</span><ins>+
+// WebKitDOMHTMLInputElement
+
+gchar* webkit_dom_html_input_element_get_capture(WebKitDOMHTMLInputElement*)
+{
+ g_warning("The WebKitDOMHTMLInputElement:capture property has converted to a boolean according to the specification. This method will always return NULL. Use webkit_dom_html_input_element_get_capture_enabled() instead.");
+ return nullptr;
+}
+
+void webkit_dom_html_input_element_set_capture(WebKitDOMHTMLInputElement*, const gchar*)
+{
+ g_warning("The WebKitDOMHTMLInputElement:capture property has converted to a boolean according to the specification. This method does nothing. Use webkit_dom_html_input_element_set_capture_enabled() instead.");
+}
</ins></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h (167751 => 167752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2014-04-24 07:07:06 UTC (rev 167751)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2014-04-24 07:17:15 UTC (rev 167752)
</span><span class="lines">@@ -765,7 +765,27 @@
</span><span class="cx"> WEBKIT_DEPRECATED void
</span><span class="cx"> webkit_dom_shadow_root_set_reset_style_inheritance(WebKitDOMShadowRoot* self, gboolean value);
</span><span class="cx">
</span><ins>+/**
+ * webkit_dom_html_input_element_get_capture:
+ * @self: A #WebKitDOMHTMLInputElement
+ *
+ * Returns: A #gchar
+ *
+ * Deprecated: 2.6: Use webkit_dom_html_input_element_get_capture_enabled() instead.
+ */
+WEBKIT_DEPRECATED_FOR(webkit_dom_html_input_element_get_capture_enabled) gchar*
+webkit_dom_html_input_element_get_capture(WebKitDOMHTMLInputElement* self);
</ins><span class="cx">
</span><ins>+/**
+ * webkit_dom_html_input_element_set_capture:
+ * @self: A #WebKitDOMHTMLInputElement
+ * @value: A #gchar
+ *
+ * Deprecated: 2.6: Use webkit_dom_html_input_element_set_capture_enabled() instead.
+ */
+WEBKIT_DEPRECATED_FOR(webkit_dom_html_input_element_set_capture_enabled) void
+webkit_dom_html_input_element_set_capture(WebKitDOMHTMLInputElement* self, const gchar* value);
+
</ins><span class="cx"> G_END_DECLS
</span><span class="cx">
</span><span class="cx"> #endif /* WEBKIT_DISABLE_DEPRECATED */
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedsymbols"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols (167751 => 167752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2014-04-24 07:07:06 UTC (rev 167751)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2014-04-24 07:17:15 UTC (rev 167752)
</span><span class="lines">@@ -4,6 +4,8 @@
</span><span class="cx"> gchar* webkit_dom_html_element_get_class_name(WebKitDOMHTMLElement*)
</span><span class="cx"> void webkit_dom_html_element_set_class_name(WebKitDOMHTMLElement*, const gchar*)
</span><span class="cx"> WebKitDOMDOMTokenList* webkit_dom_html_element_get_class_list(WebKitDOMHTMLElement*)
</span><ins>+gchar* webkit_dom_html_input_element_get_capture(WebKitDOMHTMLInputElement*)
+void webkit_dom_html_input_element_set_capture(WebKitDOMHTMLInputElement*, const gchar*)
</ins><span class="cx"> void webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement*)
</span><span class="cx"> void webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement*)
</span><span class="cx"> gboolean webkit_dom_webkit_named_flow_get_overflow(WebKitDOMWebKitNamedFlow*)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectwebkitdomsymbols"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/webkitdom.symbols (167751 => 167752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2014-04-24 07:07:06 UTC (rev 167751)
+++ trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2014-04-24 07:17:15 UTC (rev 167752)
</span><span class="lines">@@ -802,6 +802,8 @@
</span><span class="cx"> void webkit_dom_html_image_element_set_vspace(WebKitDOMHTMLImageElement*, glong)
</span><span class="cx"> glong webkit_dom_html_image_element_get_width(WebKitDOMHTMLImageElement*)
</span><span class="cx"> void webkit_dom_html_image_element_set_width(WebKitDOMHTMLImageElement*, glong)
</span><ins>+gboolean webkit_dom_html_input_element_get_capture_enabled(WebKitDOMHTMLInputElement*)
+void webkit_dom_html_input_element_set_capture_enabled(WebKitDOMHTMLInputElement*, gboolean)
</ins><span class="cx"> gboolean webkit_dom_html_image_element_get_complete(WebKitDOMHTMLImageElement*)
</span><span class="cx"> gchar* webkit_dom_html_image_element_get_lowsrc(WebKitDOMHTMLImageElement*)
</span><span class="cx"> void webkit_dom_html_image_element_set_lowsrc(WebKitDOMHTMLImageElement*, const gchar*)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (167751 => 167752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-04-24 07:07:06 UTC (rev 167751)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-04-24 07:17:15 UTC (rev 167752)
</span><span class="lines">@@ -930,6 +930,21 @@
</span><span class="cx"> return ($version, $replacement);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+sub GetEffectiveFunctionName {
+ my $functionName = shift;
+
+ # Rename webkit_dom_html_input_element_[set|get]_capture functions since they were changed to set/receive a
+ # boolean instead of a string in r163958. The old methods are now manually added as deprecated.
+ if ($functionName eq "webkit_dom_html_input_element_set_capture") {
+ return "webkit_dom_html_input_element_set_capture_enabled";
+ }
+ if ($functionName eq "webkit_dom_html_input_element_get_capture") {
+ return "webkit_dom_html_input_element_get_capture_enabled";
+ }
+
+ return $functionName;
+}
+
</ins><span class="cx"> sub GenerateFunction {
</span><span class="cx"> my ($object, $interfaceName, $function, $prefix, $parentNode) = @_;
</span><span class="cx">
</span><span class="lines">@@ -941,7 +956,7 @@
</span><span class="cx">
</span><span class="cx"> my ($deprecationVersion, $deprecationReplacement) = GetFunctionDeprecationInformation($function, $parentNode);
</span><span class="cx"> my $functionSigType = $prefix eq "set_" ? "void" : $function->signature->type;
</span><del>- my $functionName = "webkit_dom_" . $decamelize . "_" . $prefix . decamelize($function->signature->name);
</del><ins>+ my $functionName = GetEffectiveFunctionName("webkit_dom_" . $decamelize . "_" . $prefix . decamelize($function->signature->name));
</ins><span class="cx"> my $returnType = GetGlibTypeName($functionSigType);
</span><span class="cx"> my $returnValueIsGDOMType = IsGDOMClassType($functionSigType);
</span><span class="cx"> my $raisesException = $function->signature->extendedAttributes->{"RaisesException"};
</span></span></pre>
</div>
</div>
</body>
</html>