<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167737] trunk/Source/WebKit/efl</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167737">167737</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-04-23 19:25:08 -0700 (Wed, 23 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL][WK1] Add *const* keyword to _get() APIs
https://bugs.webkit.org/show_bug.cgi?id=132094
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2014-04-23
Reviewed by Gyuyoung Kim.
Some _get() EFL APIs don't have *const* keyword though the _get() APIs don't modify passed argument.
We need to add *const* keyword to those APIs.
* ewk/ewk_history.cpp:
(ewk_history_limit_get):
* ewk/ewk_history.h:
* ewk/ewk_js.cpp:
(ewk_js_object_type_get):
* ewk/ewk_js.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKiteflChangeLog">trunk/Source/WebKit/efl/ChangeLog</a></li>
<li><a href="#trunkSourceWebKiteflewkewk_historycpp">trunk/Source/WebKit/efl/ewk/ewk_history.cpp</a></li>
<li><a href="#trunkSourceWebKiteflewkewk_historyh">trunk/Source/WebKit/efl/ewk/ewk_history.h</a></li>
<li><a href="#trunkSourceWebKiteflewkewk_jscpp">trunk/Source/WebKit/efl/ewk/ewk_js.cpp</a></li>
<li><a href="#trunkSourceWebKiteflewkewk_jsh">trunk/Source/WebKit/efl/ewk/ewk_js.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKiteflChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/ChangeLog (167736 => 167737)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/ChangeLog 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ChangeLog 2014-04-24 02:25:08 UTC (rev 167737)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-04-23 Hyowon Kim <hw1008.kim@samsung.com>
+
+ [EFL][WK1] Add *const* keyword to _get() APIs
+ https://bugs.webkit.org/show_bug.cgi?id=132094
+
+ Reviewed by Gyuyoung Kim.
+
+ Some _get() EFL APIs don't have *const* keyword though the _get() APIs don't modify passed argument.
+ We need to add *const* keyword to those APIs.
+
+ * ewk/ewk_history.cpp:
+ (ewk_history_limit_get):
+ * ewk/ewk_history.h:
+ * ewk/ewk_js.cpp:
+ (ewk_js_object_type_get):
+ * ewk/ewk_js.h:
+
</ins><span class="cx"> 2014-04-22 Ryuan Choi <ryuan.choi@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL][WK1] There are many failures in fast/forms since r163033
</span></span></pre></div>
<a id="trunkSourceWebKiteflewkewk_historycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/ewk/ewk_history.cpp (167736 => 167737)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/ewk/ewk_history.cpp 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_history.cpp 2014-04-24 02:25:08 UTC (rev 167737)
</span><span class="lines">@@ -219,7 +219,7 @@
</span><span class="cx"> return core->backListCount();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-int ewk_history_limit_get(Ewk_History* history)
</del><ins>+int ewk_history_limit_get(const Ewk_History* history)
</ins><span class="cx"> {
</span><span class="cx"> EWK_HISTORY_CORE_GET_OR_RETURN(history, core, 0);
</span><span class="cx"> return core->capacity();
</span></span></pre></div>
<a id="trunkSourceWebKiteflewkewk_historyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/ewk/ewk_history.h (167736 => 167737)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/ewk/ewk_history.h 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_history.h 2014-04-24 02:25:08 UTC (rev 167737)
</span><span class="lines">@@ -251,7 +251,7 @@
</span><span class="cx"> *
</span><span class="cx"> * @return maximum number of entries this history will hold.
</span><span class="cx"> */
</span><del>-EAPI int ewk_history_limit_get(Ewk_History *history);
</del><ins>+EAPI int ewk_history_limit_get(const Ewk_History *history);
</ins><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * Set maximum capacity of given history.
</span></span></pre></div>
<a id="trunkSourceWebKiteflewkewk_jscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/ewk/ewk_js.cpp (167736 => 167737)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/ewk/ewk_js.cpp 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_js.cpp 2014-04-24 02:25:08 UTC (rev 167737)
</span><span class="lines">@@ -693,7 +693,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Ewk_JS_Object_Type ewk_js_object_type_get(Ewk_JS_Object* jsObject)
</del><ins>+Ewk_JS_Object_Type ewk_js_object_type_get(const Ewk_JS_Object* jsObject)
</ins><span class="cx"> {
</span><span class="cx"> #if ENABLE(NETSCAPE_PLUGIN_API)
</span><span class="cx"> EINA_SAFETY_ON_NULL_RETURN_VAL(jsObject, EWK_JS_OBJECT_OBJECT);
</span></span></pre></div>
<a id="trunkSourceWebKiteflewkewk_jsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/efl/ewk/ewk_js.h (167736 => 167737)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/efl/ewk/ewk_js.h 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_js.h 2014-04-24 02:25:08 UTC (rev 167737)
</span><span class="lines">@@ -191,7 +191,7 @@
</span><span class="cx"> * @return @c EWK_JS_OBJECT if it is an object, @c EWK_JS_ARRAY if it is an array and
</span><span class="cx"> * @c EWK_JS_FUNCTION if it is a function.
</span><span class="cx"> */
</span><del>-EAPI Ewk_JS_Object_Type ewk_js_object_type_get(Ewk_JS_Object *obj);
</del><ins>+EAPI Ewk_JS_Object_Type ewk_js_object_type_get(const Ewk_JS_Object *obj);
</ins><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * Sets the type this object represents.
</span></span></pre>
</div>
</div>
</body>
</html>