<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167582] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167582">167582</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-04-20 22:21:45 -0700 (Sun, 20 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: RenderLayer's size is set using enclosingRect() which can result in cruft.
https://bugs.webkit.org/show_bug.cgi?id=131468
Reviewed by Darin Adler.
Layers marked opaque may not paint edge pixels, when RenderLayer bounds are non-integral and
get device pixel snapped.
For details see this: https://trac.webkit.org/<a href="http://trac.webkit.org/projects/webkit/changeset/159463">r159463</a>
Source/WebCore:
Test: compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
LayoutTests:
* compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background-expected.html: Added.
* compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerBackingcpp">trunk/Source/WebCore/rendering/RenderLayerBacking.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscompositinghidpinonsimplecompositinglayerwithfractionalsizeandbackgroundexpectedhtml">trunk/LayoutTests/compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background-expected.html</a></li>
<li><a href="#trunkLayoutTestscompositinghidpinonsimplecompositinglayerwithfractionalsizeandbackgroundhtml">trunk/LayoutTests/compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (167581 => 167582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-04-21 04:43:46 UTC (rev 167581)
+++ trunk/LayoutTests/ChangeLog 2014-04-21 05:21:45 UTC (rev 167582)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-04-20 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: RenderLayer's size is set using enclosingRect() which can result in cruft.
+ https://bugs.webkit.org/show_bug.cgi?id=131468
+
+ Reviewed by Darin Adler.
+
+ Layers marked opaque may not paint edge pixels, when RenderLayer bounds are non-integral and
+ get device pixel snapped.
+ For details see this: https://trac.webkit.org/r159463
+
+ * compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background-expected.html: Added.
+ * compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html: Added.
+
</ins><span class="cx"> 2014-04-19 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Simple layout can get confused by coordinate overflow
</span></span></pre></div>
<a id="trunkLayoutTestscompositinghidpinonsimplecompositinglayerwithfractionalsizeandbackgroundexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background-expected.html (0 => 167582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background-expected.html 2014-04-21 05:21:45 UTC (rev 167582)
</span><span class="lines">@@ -0,0 +1,35 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that a non simple render backing layer with fractional CSS pixel size paints the background with no cruft.</title>
+<head>
+<style>
+ div {
+ background: green;
+ position: absolute;
+ border: 0.5px solid red;
+ }
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ adjustment = 0.1;
+ w = 2; h = 2;
+ for (i = 0; i < 30; ++i) {
+ adjustment += 0.1;
+ for (j = 0; j < 40; ++j) {
+ var e = document.createElement("div");
+ e.style.top = ((w + 2) * i + j * adjustment) + "px";
+ e.style.left = ((w + 2) * j + i * adjustment) + "px";
+ e.style.width = w + "px";
+ e.style.height = h + "px";
+ container.appendChild(e);
+ w += 0.01;
+ h += 0.01;
+ }
+ }
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestscompositinghidpinonsimplecompositinglayerwithfractionalsizeandbackgroundhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html (0 => 167582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html (rev 0)
+++ trunk/LayoutTests/compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html 2014-04-21 05:21:45 UTC (rev 167582)
</span><span class="lines">@@ -0,0 +1,36 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that a non simple render backing layer with fractional CSS pixel size paints the background with no cruft.</title>
+<head>
+<style>
+ div {
+ background: green;
+ position: absolute;
+ border: 0.5px solid red;
+ -webkit-transform: translateZ(0);
+ }
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ adjustment = 0.1;
+ w = 2; h = 2;
+ for (i = 0; i < 30; ++i) {
+ adjustment += 0.1;
+ for (j = 0; j < 40; ++j) {
+ var e = document.createElement("div");
+ e.style.top = ((w + 2) * i + j * adjustment) + "px";
+ e.style.left = ((w + 2) * j + i * adjustment) + "px";
+ e.style.width = w + "px";
+ e.style.height = h + "px";
+ container.appendChild(e);
+ w += 0.01;
+ h += 0.01;
+ }
+ }
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (167581 => 167582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-21 04:43:46 UTC (rev 167581)
+++ trunk/Source/WebCore/ChangeLog 2014-04-21 05:21:45 UTC (rev 167582)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-04-20 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: RenderLayer's size is set using enclosingRect() which can result in cruft.
+ https://bugs.webkit.org/show_bug.cgi?id=131468
+
+ Reviewed by Darin Adler.
+
+ Layers marked opaque may not paint edge pixels, when RenderLayer bounds are non-integral and
+ get device pixel snapped.
+ For details see this: https://trac.webkit.org/r159463
+
+ Test: compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+
</ins><span class="cx"> 2014-04-19 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Simple layout can get confused by coordinate overflow
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerBackingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (167581 => 167582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2014-04-21 04:43:46 UTC (rev 167581)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2014-04-21 05:21:45 UTC (rev 167582)
</span><span class="lines">@@ -712,7 +712,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /*
</span><del>- * GraphicsLayer: device pixel positioned. Floored, enclosing rect.
</del><ins>+ * GraphicsLayer: device pixel positioned, enclosing rect.
</ins><span class="cx"> * RenderLayer: subpixel positioned.
</span><span class="cx"> * Offset from renderer (GraphicsLayer <-> RenderLayer::renderer()): subpixel based offset.
</span><span class="cx"> *
</span><span class="lines">@@ -730,7 +730,7 @@
</span><span class="cx"> *
</span><span class="cx"> * localCompositingBounds: this RenderLayer relative to its renderer().
</span><span class="cx"> * relativeCompositingBounds: this RenderLayer relative to its parent compositing layer.
</span><del>- * enclosingRelativeCompositingBounds: this RenderLayer relative to its parent but floored to device pixel position.
</del><ins>+ * enclosingRelativeCompositingBounds: this RenderLayer relative to its parent, device pixel enclosing.
</ins><span class="cx"> * rendererOffsetFromGraphicsLayer: RenderLayer::renderer()'s offset from its enclosing GraphicsLayer.
</span><span class="cx"> * devicePixelOffsetFromRenderer: rendererOffsetFromGraphicsLayer's device pixel part. (6.9px -> 6.5px in case of 2x display)
</span><span class="cx"> * devicePixelFractionFromRenderer: rendererOffsetFromGraphicsLayer's fractional part (6.9px -> 0.4px in case of 2x display)
</span><span class="lines">@@ -823,7 +823,7 @@
</span><span class="cx"> if (!m_isMainFrameRenderViewLayer) {
</span><span class="cx"> // For non-root layers, background is always painted by the primary graphics layer.
</span><span class="cx"> ASSERT(!m_backgroundLayer);
</span><del>- bool hadSubpixelRounding = !m_devicePixelFractionFromRenderer.isZero();
</del><ins>+ bool hadSubpixelRounding = enclosingRelativeCompositingBounds != relativeCompositingBounds;
</ins><span class="cx"> m_graphicsLayer->setContentsOpaque(!hadSubpixelRounding && m_owningLayer.backgroundIsKnownToBeOpaqueInRect(localCompositingBounds));
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>