<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167545] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167545">167545</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-04-19 13:40:39 -0700 (Sat, 19 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Slap ALWAYS_INLINE on Element attribute lookup things.
<https://webkit.org/b/131892>
Most of the "inline" helpers for setting/getting attributes were not
actually getting inlined by the compiler, so let's make that happen.
Reviewed by Geoffrey Garen.
* dom/Element.cpp:
(WebCore::Element::synchronizeAttribute):
* dom/ElementData.h:
(WebCore::ElementData::findAttributeByName):
(WebCore::ElementData::findAttributeIndexByName):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementDatah">trunk/Source/WebCore/dom/ElementData.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (167544 => 167545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-19 20:36:58 UTC (rev 167544)
+++ trunk/Source/WebCore/ChangeLog 2014-04-19 20:40:39 UTC (rev 167545)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-04-19 Andreas Kling <akling@apple.com>
+
+ Slap ALWAYS_INLINE on Element attribute lookup things.
+ <https://webkit.org/b/131892>
+
+ Most of the "inline" helpers for setting/getting attributes were not
+ actually getting inlined by the compiler, so let's make that happen.
+
+ Reviewed by Geoffrey Garen.
+
+ * dom/Element.cpp:
+ (WebCore::Element::synchronizeAttribute):
+ * dom/ElementData.h:
+ (WebCore::ElementData::findAttributeByName):
+ (WebCore::ElementData::findAttributeIndexByName):
+
</ins><span class="cx"> 2014-04-19 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Telephone number detection should respect its setting consistently
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (167544 => 167545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2014-04-19 20:36:58 UTC (rev 167544)
+++ trunk/Source/WebCore/dom/Element.cpp 2014-04-19 20:40:39 UTC (rev 167545)
</span><span class="lines">@@ -377,7 +377,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline void Element::synchronizeAttribute(const QualifiedName& name) const
</del><ins>+ALWAYS_INLINE void Element::synchronizeAttribute(const QualifiedName& name) const
</ins><span class="cx"> {
</span><span class="cx"> if (!elementData())
</span><span class="cx"> return;
</span><span class="lines">@@ -393,7 +393,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline void Element::synchronizeAttribute(const AtomicString& localName) const
</del><ins>+ALWAYS_INLINE void Element::synchronizeAttribute(const AtomicString& localName) const
</ins><span class="cx"> {
</span><span class="cx"> // This version of synchronizeAttribute() is streamlined for the case where you don't have a full QualifiedName,
</span><span class="cx"> // e.g when called from DOM API.
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementDatah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ElementData.h (167544 => 167545)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ElementData.h 2014-04-19 20:36:58 UTC (rev 167544)
+++ trunk/Source/WebCore/dom/ElementData.h 2014-04-19 20:40:39 UTC (rev 167545)
</span><span class="lines">@@ -262,7 +262,7 @@
</span><span class="cx"> return AttributeIteratorAccessor(static_cast<const ShareableElementData*>(this)->m_attributeArray, arraySize());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline const Attribute* ElementData::findAttributeByName(const AtomicString& name, bool shouldIgnoreAttributeCase) const
</del><ins>+ALWAYS_INLINE const Attribute* ElementData::findAttributeByName(const AtomicString& name, bool shouldIgnoreAttributeCase) const
</ins><span class="cx"> {
</span><span class="cx"> unsigned index = findAttributeIndexByName(name, shouldIgnoreAttributeCase);
</span><span class="cx"> if (index != attributeNotFound)
</span><span class="lines">@@ -270,7 +270,7 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline unsigned ElementData::findAttributeIndexByName(const QualifiedName& name) const
</del><ins>+ALWAYS_INLINE unsigned ElementData::findAttributeIndexByName(const QualifiedName& name) const
</ins><span class="cx"> {
</span><span class="cx"> const Attribute* attributes = attributeBase();
</span><span class="cx"> for (unsigned i = 0, count = length(); i < count; ++i) {
</span><span class="lines">@@ -282,7 +282,7 @@
</span><span class="cx">
</span><span class="cx"> // We use a boolean parameter instead of calling shouldIgnoreAttributeCase so that the caller
</span><span class="cx"> // can tune the behavior (hasAttribute is case sensitive whereas getAttribute is not).
</span><del>-inline unsigned ElementData::findAttributeIndexByName(const AtomicString& name, bool shouldIgnoreAttributeCase) const
</del><ins>+ALWAYS_INLINE unsigned ElementData::findAttributeIndexByName(const AtomicString& name, bool shouldIgnoreAttributeCase) const
</ins><span class="cx"> {
</span><span class="cx"> const Attribute* attributes = attributeBase();
</span><span class="cx"> bool doSlowCheck = shouldIgnoreAttributeCase;
</span><span class="lines">@@ -302,7 +302,7 @@
</span><span class="cx"> return attributeNotFound;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline const Attribute* ElementData::findAttributeByName(const QualifiedName& name) const
</del><ins>+ALWAYS_INLINE const Attribute* ElementData::findAttributeByName(const QualifiedName& name) const
</ins><span class="cx"> {
</span><span class="cx"> const Attribute* attributes = attributeBase();
</span><span class="cx"> for (unsigned i = 0, count = length(); i < count; ++i) {
</span></span></pre>
</div>
</div>
</body>
</html>