<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167392] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167392">167392</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2014-04-16 15:39:05 -0700 (Wed, 16 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Enable system library calls in FTL for ARM64
https://bugs.webkit.org/show_bug.cgi?id=130154
Patch by Juergen Ributzka <juergen@apple.com> on 2014-04-16
Reviewed by Geoffrey Garen and Filip Pizlo.
* ftl/FTLIntrinsicRepository.h:
* ftl/FTLOutput.h:
(JSC::FTL::Output::doubleRem):
(JSC::FTL::Output::doubleSin):
(JSC::FTL::Output::doubleCos):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreftlFTLIntrinsicRepositoryh">trunk/Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreftlFTLOutputh">trunk/Source/JavaScriptCore/ftl/FTLOutput.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (167391 => 167392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-04-16 22:21:43 UTC (rev 167391)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-04-16 22:39:05 UTC (rev 167392)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-04-16 Juergen Ributzka <juergen@apple.com>
+
+ Enable system library calls in FTL for ARM64
+ https://bugs.webkit.org/show_bug.cgi?id=130154
+
+ Reviewed by Geoffrey Garen and Filip Pizlo.
+
+ * ftl/FTLIntrinsicRepository.h:
+ * ftl/FTLOutput.h:
+ (JSC::FTL::Output::doubleRem):
+ (JSC::FTL::Output::doubleSin):
+ (JSC::FTL::Output::doubleCos):
+
</ins><span class="cx"> 2014-04-16 peavo@outlook.com <peavo@outlook.com>
</span><span class="cx">
</span><span class="cx"> Fix JSC Debug Regressions on Windows
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreftlFTLIntrinsicRepositoryh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h (167391 => 167392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h 2014-04-16 22:21:43 UTC (rev 167391)
+++ trunk/Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h 2014-04-16 22:39:05 UTC (rev 167392)
</span><span class="lines">@@ -59,7 +59,6 @@
</span><span class="cx"> macro(C_JITOperation_EJssJssJss, functionType(intPtr, intPtr, intPtr, intPtr, intPtr)) \
</span><span class="cx"> macro(C_JITOperation_ESt, functionType(intPtr, intPtr, intPtr)) \
</span><span class="cx"> macro(D_JITOperation_D, functionType(doubleType, doubleType)) \
</span><del>- macro(D_JITOperation_DD, functionType(doubleType, doubleType, doubleType)) \
</del><span class="cx"> macro(I_JITOperation_EJss, functionType(intPtr, intPtr, intPtr)) \
</span><span class="cx"> macro(J_JITOperation_E, functionType(int64, intPtr)) \
</span><span class="cx"> macro(J_JITOperation_EA, functionType(int64, intPtr, intPtr)) \
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreftlFTLOutputh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ftl/FTLOutput.h (167391 => 167392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ftl/FTLOutput.h 2014-04-16 22:21:43 UTC (rev 167391)
+++ trunk/Source/JavaScriptCore/ftl/FTLOutput.h 2014-04-16 22:39:05 UTC (rev 167392)
</span><span class="lines">@@ -126,13 +126,7 @@
</span><span class="cx"> LValue doubleSub(LValue left, LValue right) { return buildFSub(m_builder, left, right); }
</span><span class="cx"> LValue doubleMul(LValue left, LValue right) { return buildFMul(m_builder, left, right); }
</span><span class="cx"> LValue doubleDiv(LValue left, LValue right) { return buildFDiv(m_builder, left, right); }
</span><del>- LValue doubleRem(LValue left, LValue right)
- {
- // FIXME: LLVM may soften float operations by expanding them to libcalls.
- // We cannot allow that on all platforms yet.
- // <rdar://16196412> MachO large code model support.
- return isX86() ? buildFRem(m_builder, left, right) : call(operation(fmod), left, right);
- }
</del><ins>+ LValue doubleRem(LValue left, LValue right) { return buildFRem(m_builder, left, right); }
</ins><span class="cx"> LValue doubleNeg(LValue value) { return buildFNeg(m_builder, value); }
</span><span class="cx">
</span><span class="cx"> LValue bitAnd(LValue left, LValue right) { return buildAnd(m_builder, left, right); }
</span><span class="lines">@@ -176,12 +170,11 @@
</span><span class="cx">
</span><span class="cx"> LValue doubleSin(LValue value)
</span><span class="cx"> {
</span><del>- return call(isX86() ? doubleSinIntrinsic() : operation(sin), value);
-
</del><ins>+ return call(doubleSinIntrinsic(), value);
</ins><span class="cx"> }
</span><span class="cx"> LValue doubleCos(LValue value)
</span><span class="cx"> {
</span><del>- return call(isX86() ? doubleCosIntrinsic() : operation(cos), value);
</del><ins>+ return call(doubleCosIntrinsic(), value);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> LValue doubleSqrt(LValue value)
</span></span></pre>
</div>
</div>
</body>
</html>