<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167299] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167299">167299</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-04-14 23:24:42 -0700 (Mon, 14 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/167261">r167261</a>.
https://bugs.webkit.org/show_bug.cgi?id=131667
broke many navigation tests (Requested by ap on #webkit).
Reverted changeset:
"Web Replay: memoize fallback time values for
document.lastModified"
https://bugs.webkit.org/show_bug.cgi?id=131318
http://trac.webkit.org/changeset/167261</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCorereplayWebInputsjson">trunk/Source/WebCore/replay/WebInputs.json</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestshttptestsinspectorreplaydocumentlastmodifiedfallbackvaluehtml">trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (167298 => 167299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-04-15 06:13:58 UTC (rev 167298)
+++ trunk/LayoutTests/ChangeLog        2014-04-15 06:24:42 UTC (rev 167299)
</span><span class="lines">@@ -1,5 +1,19 @@
</span><span class="cx"> 2014-04-14 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><ins>+ Unreviewed, rolling out r167261.
+ https://bugs.webkit.org/show_bug.cgi?id=131667
+
+ broke many navigation tests (Requested by ap on #webkit).
+
+ Reverted changeset:
+
+ "Web Replay: memoize fallback time values for
+ document.lastModified"
+ https://bugs.webkit.org/show_bug.cgi?id=131318
+ http://trac.webkit.org/changeset/167261
+
+2014-04-14 Commit Queue <commit-queue@webkit.org>
+
</ins><span class="cx"> Unreviewed, rolling out r167272.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=131666
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsinspectorreplaydocumentlastmodifiedfallbackvaluehtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html (167298 => 167299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html        2014-04-15 06:13:58 UTC (rev 167298)
+++ trunk/LayoutTests/http/tests/inspector/replay/document-last-modified-fallback-value.html        2014-04-15 06:24:42 UTC (rev 167299)
</span><span class="lines">@@ -1,33 +0,0 @@
</span><del>-<html>
-<head>
-<script type="text/javascript" src="../inspector-test.js"></script>
-<script type="text/javascript" src="./replay-test.js"></script>
-<script>
-
-function appendFrameWithLastModifiedDate(text) {
- document.write('<iframe src="../resources/last-modified.php?date=' + escape(text) + '"></iframe>');
-}
-
-appendFrameWithLastModifiedDate('');
-
-function dumpNondeterministicState()
-{
- return Date.parse(frames[0].document.body.textContent);
-}
-
-function test()
-{
- function statesAreEqual(a, b)
- {
- return a === b;
- }
-
- InspectorTest.Replay.runSingleSegmentRefTest(statesAreEqual);
-}
-
-</script>
-</head>
-<body onload="runTest()">
-<p>Tests that we can capture and replay nondeterminism in fallback values for document.lastModified</p>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (167298 => 167299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-04-15 06:13:58 UTC (rev 167298)
+++ trunk/Source/WebCore/ChangeLog        2014-04-15 06:24:42 UTC (rev 167299)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-04-14 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r167261.
+ https://bugs.webkit.org/show_bug.cgi?id=131667
+
+ broke many navigation tests (Requested by ap on #webkit).
+
+ Reverted changeset:
+
+ "Web Replay: memoize fallback time values for
+ document.lastModified"
+ https://bugs.webkit.org/show_bug.cgi?id=131318
+ http://trac.webkit.org/changeset/167261
+
</ins><span class="cx"> 2014-04-14 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS WK2] Pages often blank on first load if page loaded by typing the URL
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (167298 => 167299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp        2014-04-15 06:13:58 UTC (rev 167298)
+++ trunk/Source/WebCore/dom/Document.cpp        2014-04-15 06:24:42 UTC (rev 167299)
</span><span class="lines">@@ -220,7 +220,6 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if ENABLE(WEB_REPLAY)
</span><del>-#include "WebReplayInputs.h"
</del><span class="cx"> #include <replay/EmptyInputCursor.h>
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -3892,20 +3891,8 @@
</span><span class="cx"> // FIXME: If this document came from the file system, the HTML5
</span><span class="cx"> // specificiation tells us to read the last modification date from the file
</span><span class="cx"> // system.
</span><del>- if (!foundDate) {
- double fallbackDate = currentTimeMS();
-#if ENABLE(WEB_REPLAY)
- InputCursor& cursor = inputCursor();
- if (cursor.isCapturing())
- cursor.appendInput<DocumentLastModifiedDate>(fallbackDate);
- else if (cursor.isReplaying()) {
- if (DocumentLastModifiedDate* input = cursor.fetchInput<DocumentLastModifiedDate>())
- fallbackDate = input->fallbackValue();
- }
-#endif
- date.setMillisecondsSinceEpochForDateTime(fallbackDate);
- }
-
</del><ins>+ if (!foundDate)
+ date.setMillisecondsSinceEpochForDateTime(currentTimeMS());
</ins><span class="cx"> return String::format("%02d/%02d/%04d %02d:%02d:%02d", date.month() + 1, date.monthDay(), date.fullYear(), date.hour(), date.minute(), date.second());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorereplayWebInputsjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/replay/WebInputs.json (167298 => 167299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/replay/WebInputs.json        2014-04-15 06:13:58 UTC (rev 167298)
+++ trunk/Source/WebCore/replay/WebInputs.json        2014-04-15 06:24:42 UTC (rev 167299)
</span><span class="lines">@@ -165,14 +165,6 @@
</span><span class="cx"> "members": [ ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "DocumentLastModifiedDate",
- "description": "A fallback value used for the document's last modified date if the Last-Modified header can't be found or used.",
- "queue": "SCRIPT_MEMOIZED",
- "members": [
- { "name": "fallbackValue", "type": "double" }
- ]
- },
- {
</del><span class="cx"> "name": "EndSegmentSentinel",
</span><span class="cx"> "description": "A sentinel input to signal the end of a segment.",
</span><span class="cx"> "queue": "EVENT_LOOP",
</span></span></pre>
</div>
</div>
</body>
</html>