<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167089] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167089">167089</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-04-10 14:44:36 -0700 (Thu, 10 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: AXI: expose aria-busy state of current and ancestor nodes
https://bugs.webkit.org/show_bug.cgi?id=130826
Patch by James Craig <jcraig@apple.com> on 2014-04-10
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
Expose if node is contained by any "busy" ancestor nodes, too.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
LayoutTests:
Expose if node is contained by any "busy" ancestor nodes, too.
* inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
* inspector-protocol/dom/getAccessibilityPropertiesForNode.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodeexpectedtxt">trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodehtml">trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgentcpp">trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (167088 => 167089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-04-10 21:27:21 UTC (rev 167088)
+++ trunk/LayoutTests/ChangeLog 2014-04-10 21:44:36 UTC (rev 167089)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-04-10 James Craig <jcraig@apple.com>
+
+ Web Inspector: AXI: expose aria-busy state of current and ancestor nodes
+ https://bugs.webkit.org/show_bug.cgi?id=130826
+
+ Reviewed by Timothy Hatcher.
+
+ Expose if node is contained by any "busy" ancestor nodes, too.
+
+ * inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
+ * inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
+
</ins><span class="cx"> 2014-04-10 Brian J. Burg <burg@cs.washington.edu>
</span><span class="cx">
</span><span class="cx"> Web Replay: memoize plugin data for navigator.mimeTypes and navigator.plugins
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt (167088 => 167089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt 2014-04-10 21:27:21 UTC (rev 167088)
+++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt 2014-04-10 21:44:36 UTC (rev 167089)
</span><span class="lines">@@ -4,10 +4,10 @@
</span><span class="cx"> exists: true
</span><span class="cx"> label:
</span><span class="cx"> role:
</span><del>- childNodeIds.length: 42
</del><ins>+ childNodeIds.length: 43
</ins><span class="cx">
</span><span class="cx">
</span><del>-Total elements to be tested: 63.
</del><ins>+Total elements to be tested: 65.
</ins><span class="cx">
</span><span class="cx"> <div onclick="void(0);">click</div>
</span><span class="cx"> exists: true
</span><span class="lines">@@ -54,6 +54,20 @@
</span><span class="cx"> parentNodeId: exists
</span><span class="cx"> selectedChildNodeIds.length: 1
</span><span class="cx">
</span><ins>+<div role="option" aria-busy="true">busy (self)</div>
+ exists: true
+ label:
+ role: option
+ busy: true
+ parentNodeId: exists
+
+<div role="option">busy (parent)</div>
+ exists: true
+ label:
+ role: option
+ busy: true
+ parentNodeId: exists
+
</ins><span class="cx"> <div role="listbox" aria-multiselectable="true">
</span><span class="cx"> <div role="option" aria-selected="true">selected</div>
</span><span class="cx"> <div role="option" aria-selected="false">not selected</div>
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorprotocoldomgetAccessibilityPropertiesForNodehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html (167088 => 167089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html 2014-04-10 21:27:21 UTC (rev 167088)
+++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html 2014-04-10 21:44:36 UTC (rev 167089)
</span><span class="lines">@@ -107,6 +107,11 @@
</span><span class="cx"> <div role="option" aria-selected="true">selected</div>
</span><span class="cx"> </div>
</span><span class="cx">
</span><ins>+<div role="listbox" aria-busy="true">
+ <div class="ex" role="option">busy (parent)</div>
+ <div class="ex" role="option" aria-busy="true">busy (self)</div>
+</div>
+
</ins><span class="cx"> <ul role="tree" class="ex" id="flowedTo1" aria-activedescendant="activedescendant">
</span><span class="cx"> <li class="ex" role="treeitem" aria-expanded="true">expanded</li>
</span><span class="cx"> <li class="ex" role="treeitem" aria-expanded="false" id="activedescendant" aria-selected="true">collapsed</li>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (167088 => 167089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-10 21:27:21 UTC (rev 167088)
+++ trunk/Source/WebCore/ChangeLog 2014-04-10 21:44:36 UTC (rev 167089)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-04-10 James Craig <jcraig@apple.com>
+
+ Web Inspector: AXI: expose aria-busy state of current and ancestor nodes
+ https://bugs.webkit.org/show_bug.cgi?id=130826
+
+ Reviewed by Timothy Hatcher.
+
+ Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
+
+ Expose if node is contained by any "busy" ancestor nodes, too.
+
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
+
</ins><span class="cx"> 2014-04-10 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Remove unused ruler in overlay code
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (167088 => 167089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-04-10 21:27:21 UTC (rev 167088)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-04-10 21:44:36 UTC (rev 167089)
</span><span class="lines">@@ -1478,7 +1478,12 @@
</span><span class="cx"> if (AccessibilityObject* activeDescendant = axObject->activeDescendant())
</span><span class="cx"> activeDescendantNode = activeDescendant->node();
</span><span class="cx">
</span><del>- busy = axObject->ariaLiveRegionBusy();
</del><ins>+ // An AX object is "busy" if it or any ancestor has aria-busy="true" set.
+ AccessibilityObject* current = axObject;
+ while (!busy && current) {
+ busy = current->ariaLiveRegionBusy();
+ current = current->parentObject();
+ }
</ins><span class="cx">
</span><span class="cx"> supportsChecked = axObject->supportsChecked();
</span><span class="cx"> if (supportsChecked) {
</span></span></pre>
</div>
</div>
</body>
</html>