<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[167012] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/167012">167012</a></dd>
<dt>Author</dt> <dd>mario.prada@samsung.com</dd>
<dt>Date</dt> <dd>2014-04-09 08:08:17 -0700 (Wed, 09 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails
https://bugs.webkit.org/show_bug.cgi?id=131380
Reviewed by Chris Fleizach.
Source/WebCore:
Don't emit signals for added objects that we know won't be exposed
to the accessibility hierarchy (e.g. static text).
* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::attachWrapper): Add extra check and early return.
LayoutTests:
Updated TestExpectations file and update layout test that was not
correctly written, and expecting the signals in the wrong order.
* platform/gtk/TestExpectations: Removed failure expectations.
* accessibility/children-changed-sends-notification.html: Updated
test to make sure we touch the accessibility tree after adding a
<button> so we get the 'add' signal at the right moment.
* accessibility/children-changed-sends-notification-expected.txt:
Updated expectations to expect the 'add' and 'remove' signals in
the right order.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilitychildrenchangedsendsnotificationexpectedtxt">trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitychildrenchangedsendsnotificationhtml">trunk/LayoutTests/accessibility/children-changed-sends-notification.html</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkAXObjectCacheAtkcpp">trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (167011 => 167012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-04-09 15:05:58 UTC (rev 167011)
+++ trunk/LayoutTests/ChangeLog 2014-04-09 15:08:17 UTC (rev 167012)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2014-04-09 Mario Sanchez Prada <mario.prada@samsung.com>
</span><span class="cx">
</span><ins>+ [GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=131380
+
+ Reviewed by Chris Fleizach.
+
+ Updated TestExpectations file and update layout test that was not
+ correctly written, and expecting the signals in the wrong order.
+
+ * platform/gtk/TestExpectations: Removed failure expectations.
+
+ * accessibility/children-changed-sends-notification.html: Updated
+ test to make sure we touch the accessibility tree after adding a
+ <button> so we get the 'add' signal at the right moment.
+
+ * accessibility/children-changed-sends-notification-expected.txt:
+ Updated expectations to expect the 'add' and 'remove' signals in
+ the right order.
+
+2014-04-09 Mario Sanchez Prada <mario.prada@samsung.com>
+
</ins><span class="cx"> [AX][GTK] No new lines in some AX tests output
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=131294
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitychildrenchangedsendsnotificationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt (167011 => 167012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt 2014-04-09 15:05:58 UTC (rev 167011)
+++ trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt 2014-04-09 15:08:17 UTC (rev 167012)
</span><span class="lines">@@ -6,10 +6,10 @@
</span><span class="cx"> Plain text paragraph
</span><span class="cx">
</span><span class="cx"> End of test
</span><ins>+PARAGRAPH notification: AXChildrenAdded
+GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph
</ins><span class="cx"> PARAGRAPH notification: AXChildrenRemoved
</span><span class="cx"> GLOBAL notification: AXChildrenRemoved on element with role AXRole: AXParagraph
</span><del>-PARAGRAPH notification: AXChildrenAdded
-GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph
</del><span class="cx"> PASS paragraphNotificationCount is globalNotificationCount
</span><span class="cx"> PASS globalNotificationCount is 2
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitychildrenchangedsendsnotificationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/children-changed-sends-notification.html (167011 => 167012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/children-changed-sends-notification.html 2014-04-09 15:05:58 UTC (rev 167011)
+++ trunk/LayoutTests/accessibility/children-changed-sends-notification.html 2014-04-09 15:08:17 UTC (rev 167012)
</span><span class="lines">@@ -57,6 +57,9 @@
</span><span class="cx"> window.newChild = document.createElement('button');
</span><span class="cx"> par.appendChild(newChild);
</span><span class="cx">
</span><ins>+ // Ensure the new child is added.
+ touchAccessibilityTree(axWebArea);
+
</ins><span class="cx"> window.setTimeout(function() {
</span><span class="cx"> var link = document.getElementById('testLink');
</span><span class="cx"> link.style.display = 'none';
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (167011 => 167012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-09 15:05:58 UTC (rev 167011)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-09 15:08:17 UTC (rev 167012)
</span><span class="lines">@@ -1057,9 +1057,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/106340 accessibility/img-fallsback-to-title.html [ Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/131380 accessibility/children-changed-sends-notification.html [ Failure ]
-webkit.org/b/131380 accessibility/notification-listeners.html [ Failure ]
-
</del><span class="cx"> # svg/ failures
</span><span class="cx"> webkit.org/b/42457 svg/custom/embedded-svg-allowed-in-dashboard.xml [ Failure ]
</span><span class="cx"> webkit.org/b/42457 svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html [ Failure ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (167011 => 167012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-04-09 15:05:58 UTC (rev 167011)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 15:08:17 UTC (rev 167012)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2014-04-09 Mario Sanchez Prada <mario.prada@samsung.com>
</span><span class="cx">
</span><ins>+ [GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=131380
+
+ Reviewed by Chris Fleizach.
+
+ Don't emit signals for added objects that we know won't be exposed
+ to the accessibility hierarchy (e.g. static text).
+
+ * accessibility/atk/AXObjectCacheAtk.cpp:
+ (WebCore::AXObjectCache::attachWrapper): Add extra check and early return.
+
+2014-04-09 Mario Sanchez Prada <mario.prada@samsung.com>
+
</ins><span class="cx"> [AX][GTK] No new lines in some AX tests output
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=131294
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkAXObjectCacheAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp (167011 => 167012)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-04-09 15:05:58 UTC (rev 167011)
+++ trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-04-09 15:08:17 UTC (rev 167012)
</span><span class="lines">@@ -76,7 +76,11 @@
</span><span class="cx"> if (!document || document->childNeedsStyleRecalc())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- // Don't emit the signal for objects that we already know won't be exposed directly.
</del><ins>+ // Don't emit the signal when the actual object being added is not going to be exposed.
+ if (obj->accessibilityIsIgnoredByDefault())
+ return;
+
+ // Don't emit the signal for objects whose parents won't be exposed directly.
</ins><span class="cx"> AccessibilityObject* coreParent = obj->parentObjectUnignored();
</span><span class="cx"> if (!coreParent || coreParent->accessibilityIsIgnoredByDefault())
</span><span class="cx"> return;
</span></span></pre>
</div>
</div>
</body>
</html>